From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF9F1B6CE9 for ; Sat, 11 Apr 2026 05:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884664; cv=none; b=fNbCLBHryR/GpkOuGbVRvVsPZhkiq0q+f5gwfY46KzhnXcC04JlaYDIjpBIYUgtSFA53I+uMjDB5lWfZ0JXCPG4L34GgRaDe5DUlCY9nNhM2Vb8TV92CZ8BMBYULx8j0rWOMCZe+y/BNLITm+3FoYXN4ZyzJAnV5avK+X+rXa2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884664; c=relaxed/simple; bh=ZTNxYcl4br40HpvemEVYTm0MazZv42JwgYPDPSJKJIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=abF1Qfo/bD7K/xDrWGXbVZGOapico7UabBmbIuHsu8h2nkClOOVFCBrQOiD1jkHxTLxaKzpwS8fZ3QnCA5Ox9Ek/K0REOvQ9GCac05K8t20cXg3F4VvJBm82Cx2Ki+x/eMNN85WrX9P6TjkE2ILIW3qawjFQ+PT0pJiUG/2f0Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=s/A92jkW; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="s/A92jkW" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c76b0cda2aeso1223946a12.2 for ; Fri, 10 Apr 2026 22:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775884662; x=1776489462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kwHnbYKH+TONFDehgHpQ+nIp48wdb6f+qWIpTgXdCQ4=; b=s/A92jkWuFsKO9WfXH6CSvrGX36BozV8gY+uHgmNvIrfsA8whkjhY5iO3yfTpywUdJ 6l6w2SUMRpLLnHBRdoG/YYL/nhcn93+X75brjoLgxw9M/y3FEWeU8DhGbhxzwULq2Lov /7YJyWOX+NLsMiSXcSeSyJZ8F5InJri3l5nsIGJuunYhK4hDLOl+FaJG6Ac4vd3uoln5 kJ+xciauX/0JPdYJOuzsPDOH3SGAfIFucHBZvNRjp2bcbudSy9W157aJdVrQpP8gOBbK 69+xmkcb8DqfeWZPFnsdNaWW4Ipzhquf7AjIBKS1z4XuXBOtf5LLbb482eOBvQy1yBTb 4gWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775884662; x=1776489462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kwHnbYKH+TONFDehgHpQ+nIp48wdb6f+qWIpTgXdCQ4=; b=BWkTMCU5b/JanTofg0PDklEy/tmw+1lJ6tACO2JR0jiazZDk1EpBqrIGEwT/DNxgoY mofaZrs6ifapNKg1SNwnIy8TCpvt++Y3Mu/HxMR7AgDVWVBkUDjESEt1uIgTSaQedZ9U 2wKBY9YY19zq2l+8b7YdgEpiY8Pj4On9UUTj0FUwSFxz7ic9iQvmssZQnXJfXRM5T03a oLl8kiU0Oe4x9TBe0UhcAC9BboaevT+O+mbR6byhuMEM9UJTgutr02u0w0y9K65ITyNu 6k83MlvuPUeyi0Pa5vVyKMcw+73GgToj7auXwJsiTZ6AxPdWOE7HwhbzXMLhoLbb0IhL ddFQ== X-Forwarded-Encrypted: i=1; AJvYcCWYXPhtcR0X0y0tfEA9WpdoiExm7F6KC2Qu6zJQVtR/mjp8RPQGmmQWIFGwbQVUuLJVDlcgT4ecX8CBLDU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4T3ls4l+ELJhptF4FMg4qDQUe7CQwdzdV4zUKVXgEA0VSwPUW vMpcHzAny0ijYEn+xWm2SEEQjc6M0hYUbkqVSPj3IkJV3xOBETh2ISQ4KeoNuG6Ohgs= X-Gm-Gg: AeBDieu9MC87WGrF3kygwtBbR6vlkjzioG3F34u+T6rOoZmesm2RIeTcL8oePgDpJPb 4lGj7DN1BKKzciyWuZxkWYBWHndV9GF3Nm8ZuOxOFM2PRT4qGaEuNHICIzHm7VlCS0MvGCGhHLT Cm6VgGWxh16SQZ3bpUud+vN1osXr9ORnW/0lBow+nucWIWKzs+ZbPGgNHCdlraz4h1jsT2Tx3oZ BzVnM+9b1TwyIQjhzTLBc+sorM8ouSi12iuo9FltCeXih5sJ+pBlYPS1cAYL5ngTN4DR9qfeaKt POfamiXA3F9QxjVjJ/EDSApVslHWfbpVyorNl2Vi1Hq+wjvAz5sYumgEM4WqxZacSz86J4aCYnw G18BTElSDQLy8bvfauSXFuPx5xQy+Kld2BpQDIa3uVG9ihNDMXm1JxgL8Y7DjoqnaGJdlSKsIeo oEib+z5+cBvqsfrTjTZa0aieUvAM2IjAWB X-Received: by 2002:a05:6a20:6a1d:b0:39f:461f:be7e with SMTP id adf61e73a8af0-39fe4002686mr6865742637.44.1775884662436; Fri, 10 Apr 2026 22:17:42 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a1ef00sm3855700a12.28.2026.04.10.22.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:17:42 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Oskolkov , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v5 6/8] net/sched: netem: null-terminate tfifo linear queue tail Date: Fri, 10 Apr 2026 22:15:55 -0700 Message-ID: <20260411051700.311679-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411051700.311679-1-stephen@networkplumber.org> References: <20260411051700.311679-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When tfifo_enqueue() appends a packet to the linear queue tail, nskb->next is never set to NULL. The list terminates correctly only by accident if the skb arrived with next already NULL. Explicitly null-terminate the tail to prevent list corruption. Fixes: d66280b12bd7 ("net: netem: use a list in addition to rbtree") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 98931bb4354b..14d22fc7365d 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -398,6 +398,7 @@ static void tfifo_enqueue(struct sk_buff *nskb, struct Qdisc *sch) q->t_tail->next = nskb; else q->t_head = nskb; + nskb->next = NULL; q->t_tail = nskb; } else { struct rb_node **p = &q->t_root.rb_node, *parent = NULL; -- 2.53.0