From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE8C2D592C for ; Sat, 11 Apr 2026 05:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884676; cv=none; b=QVIksCzVRL+RA/gKQuXoaebdRl5R1nPKhxHDKLFTAZqy8hxs2zZVgWbz3rqSGlaZlv+lXusmm2d8n5YfnhU7sFHiEQej4DfYZn7uYXT7qyP9VFUj4cj8YkpinQP6APG1ThDCc6hkCJupqVGtZsn8QwoFVF3e8DlI2eKBtivIaok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884676; c=relaxed/simple; bh=WS1gt+XCorljBOXpBR8SOXGA7679bm4YgmPp9vko5wE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UIhf9Z7TPJCnYVgpo6cz/xDVUT2IGZ9EFYx+YoFWF1vDR5egK1MKJiPx0jZrNLf6Kh3fZ/q0SvZIqRVfkIgVP2bfpKkLLsEyo/zmUii8Htd3OJlc1GWhRWDFFVqTR+cKrvHDXDN53eRsXYMIA72DpnkV0r3kuRUn66KItziYL5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=bbn+9Xtq; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="bbn+9Xtq" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c6dd5b01e14so1070871a12.0 for ; Fri, 10 Apr 2026 22:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775884675; x=1776489475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G4cg21lgYYt40QuLQd5kc+RjBMnnTeniExtdTY1DO68=; b=bbn+9XtqQFCNI3dVeBrvEdWCiwuN53YN7GdYCYav44XuYtiujb1/dA35epvPLGI6H6 l121AthqsfevpIjEF95v7L6McHO8b4iFqKxH8Pvw3ecRLSPfm+/tOpnkunh1F2QpFHb0 /qBY0BAW4RuWIe+OTiG7kgr5euY4DcaqbTkkQwOW35GXM/o+bDLhMb8+t+J2GiMNhtV3 aO3tp+DYqYGAtDQTrAM4B+pjSloRF9VYsNeNZTOrFdnyWqlnQb9dr1ubGFwfhRo2bZQ5 9PJI6woNMVKyBiR+eeZwgF2jKL3ELS0tqQIxp2dh8y7wYCM8Vfz4Gpa/JizaJsFb6gHS vZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775884675; x=1776489475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G4cg21lgYYt40QuLQd5kc+RjBMnnTeniExtdTY1DO68=; b=ktBr06FJpWD3cXqOS2UXRbbVG+wvRnlYawIYI2XPGyhVlNYDkk7ETzlLMEUyqrAu6e tML+2ytrgOhHWNpHvoX4ttNB2Kg34VhDFwwgbMDQPsoc/aUdYfnAOtZkEUJwIjxKzuyT qpDR4Noz80Ocs51pm6+S8lXD2wHVdLMDjR8ZM+LpuG4M2n8GGTjZuIRBCp9x58LKT2jY OugMPKcTuhtzgrkMwhUhlwnxtk2V+sQNHq9y2X1NrwbZbfzoVx9TjU9nw0IZshFk9cm6 uD1rmjXLBrgz8hW4yyebbNYJJaQVAGXjDdfcMzLHW7TVBhBKwR0BjVz7N2myfjbEREA4 giqg== X-Forwarded-Encrypted: i=1; AJvYcCWS4tEquCwPb1T4AuPwFFKLdxF/65VRYD84UQbaHpU1twMDSWz4XP3r3mcWn90hT/QERfggAnYfa/w+1lA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5fsz1jTaWCaA6JA7/L4W7wErit/qsYCmj4MyZefijuk6LVqZ1 QNqkcMM1uCavd2Al+3hsm+MRO2QG5kOBGN15VBwbDuh73BFLp0LaqE8Egpot/XFu/pg= X-Gm-Gg: AeBDietDXai1IY0I2EL7l1ALshr6vJpHL9b8gBvE5NyvhD6/UUSYHEs25k0NlRH/GYf Ap/8m0Tzj6Zt3wvtQdOkl3REqyGSMDcUQ5hUoKh7ZdJLuuhC3QccDTXDDCV4Cmzh7WUk9U5HVDr c7ODA4Fs6e94I8FD5wZTCNJABVOhVm22e+ym3OanMe1T2JW1w40aB5Ilpaj15SBFW+aH+aB4R+E wC0mlAxTJRujbP3ff9qxLFd6f8U/fpcqVRxBUqCclm1jafbGPe4YdaoEXBVTUzx33MY317C6hRi hhdmEU1m35IH+h1Lrzc+wiRLUcCU1nt2NgCMHCqK3iBa7Xqe8ouZqA42sZzxE8oVWD54HoXpUME zYpw66rRTFrGpbmjo5dk7t98QAmzRI4MCQL+7z1i6Bw8MygaMuRRI7b8LHSPwGUPupxJQ1CZJ0O IIEAowvfrmGNhDclc11/ca/dmoOvSxWbgQ X-Received: by 2002:a05:6a20:7289:b0:398:7ed3:a005 with SMTP id adf61e73a8af0-39fe3f15059mr7124353637.29.1775884674957; Fri, 10 Apr 2026 22:17:54 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a1ef00sm3855700a12.28.2026.04.10.22.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:17:54 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Neal Cardwell , Yousuk Seung , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v5 8/8] net/sched: netem: fix slot delay calculation overflow Date: Fri, 10 Apr 2026 22:15:57 -0700 Message-ID: <20260411051700.311679-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411051700.311679-1-stephen@networkplumber.org> References: <20260411051700.311679-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit get_slot_next() computes a random delay between min_delay and max_delay using: get_random_u32() * (max_delay - min_delay) >> 32 This overflows signed 64-bit arithmetic when the delay range exceeds approximately 2.1 seconds (2^31 nanoseconds), producing a negative result that effectively disables slot-based pacing. This is a realistic configuration for WAN emulation (e.g., slot 1s 5s). Use mul_u64_u32_shr() which handles the widening multiply without overflow. Fixes: 0a9fe5c375b5 ("netem: slotting with non-uniform distribution") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index ef4965f20f17..6a09627bafa0 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -660,9 +660,8 @@ static void get_slot_next(struct netem_sched_data *q, u64 now) if (!q->slot_dist) next_delay = q->slot_config.min_delay + - (get_random_u32() * - (q->slot_config.max_delay - - q->slot_config.min_delay) >> 32); + mul_u64_u32_shr(q->slot_config.max_delay - q->slot_config.min_delay, + get_random_u32(), 32); else next_delay = tabledist(q->slot_config.dist_delay, (s32)(q->slot_config.dist_jitter), -- 2.53.0