From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D691B334C1F for ; Sat, 11 Apr 2026 08:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897087; cv=none; b=kAmrFRD4Pr3hBV3RBfNDnUup3djjLrFP/xqw0xNgZs9Iuu0qVNOimJnMWvE2VBClJabIVFKGcrAl6pjzqQVuAfZFTLMzQUR3etLwQCfsO6S2Mji/6QwCz5UMhdkAOQhiU7RvmDz+zpKde5ePtikKS4qX+KXXTXjHG1R4qti0zfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897087; c=relaxed/simple; bh=7Q5mva72tlCTFYBzwEvO2ZFGsF1JnnlsFqj/wvcMAdE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RJU0bEisrzpfXVNngBpP3QdfQpYZRkM7s/UUJ7/PZUryM+M5ppaC0D9ExwXwqwhcuy3AGyi2++U0mHKb+u63haHzFfrfa2HLetl/J3w5NbI+yLV4WGPwwFYDrsbDFTDW9LWiCecQDB/aacsmMXMEWC8p+XtVJBZxW/7qcPQVZ3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cCLUnWYO; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cCLUnWYO" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a29e6110so31347055e9.3 for ; Sat, 11 Apr 2026 01:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775897083; x=1776501883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/z9NrwlpQUG/cW4s7HQM8LOZblhF59Jnsa4w00A3aEw=; b=cCLUnWYOaWvscflo1cpsUYUSKEz7WS4USid8mJo9Jv2MA6xfiDVJfKQoz6XAzmSeVK StP8rA6vw22CXKequhIVZUspZqeynQbUbPOZ2p+RtGIGmcbZl6Zl8sO6ZngO7qPaf4ZZ /ThkAyHrgIaMvZsmTUx/Mru9xtNkv/UhlHyX+yU+x400L0GB9iWt9tHoGjKea+DRYDDl 597XMZAhV0qq06n4Uh7nOqcDsYVSWbvwVW+HT+5kbAUC95yeCF3BYdfp5zLEI3ruqjac qmvT54XIOaN45zO9CrEWHylB+gT1jDFEDkaMWQ9KSYF7bli1LI4+0L0gTtSB2jhnwbpW EJGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775897083; x=1776501883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/z9NrwlpQUG/cW4s7HQM8LOZblhF59Jnsa4w00A3aEw=; b=I9b4y9QoQ0zRiM3UfVwza1dyiF40jaNcaCnnB8ddicEtQBpCJxSSeKH+PkBYcPrw6f D2T1wxj0bpPsEjzwUx9BMxyiS5F43uBBYd+kMJ+Kq2C2+JmftB0hPlUYtCy0QZhw/EIf AQPwi0peKIsngvNqZplyQ6x6qPg9laEePr5nku1DLUdmMM78KN+tvBAIl67DRxOYJUJT YZFKGn1a4c5X02rus8zj0nJK+SOfUZLSZK8qoIKD8qdOlvN7V0lMiEzaOwnWcDSxbDz4 HtmF0FoJvz9v1PO3ClChk5cd60LSL9GmhObVK5WI8K7UbiyCLhWVSy1y03UCyFpjBvur 6lGQ== X-Forwarded-Encrypted: i=1; AJvYcCXsvNM4oyvIo27MCL9KSLTKCLQMeF3MGlooUEjyKVIb7TpzJJEXGOChx6Oh/Ewo7VtK1qrwVx8U1aCq47g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8CDqsQvvPpu0ljOR70xgOdpDZsGi/itOptOPdbs/oIk0xHdLW 5eOl5ZUDXdpEo9IQMk70r/BCOjEA8jcvftsCXrNaWSpbCdaV1RGsa0Vi X-Gm-Gg: AeBDieshyNH5F7qE2Xq8c18OyqJeG1djgphxSL6Gcn9tAbFEye8vDlB5cAaH5BnhNBQ 6Tgr9KpMjylYYnAnhV8EWhHr4yz8t/hEPSjv/wIa3Zs5IkrnewGPIQjLMoesYJcKiRzsJsYykJt 1ignMbySMoSx70DM2GLcPlPluYOnD6ApBM9FaCvP0HsMWQRBvBCWFsvwOT7FRuydhurPDepKUYN NKmwllNlycEeVj/jDECFuqjombwX8P8fXgNvRyiMgdP0ZdWIZvRCsBIrBHbkpLr+9lPIpPTngyJ KnH4wr3WIgZaLDY/mCDbltvJ7RYt8EiRNSiu4LOcoCHYyf9rQRBTjq7ws7VF92VneP6nCBGuyPN BsCbexsgA5K1JzSa6L6EK1KUpJ5/c0QZipQdcby5UFB7L3QaILWt3m/70JVMuNfUNZua2V3XhmB T2hMdPL7YcR+yKLttV0Hri7H62SFy0vh8CdCdmY3YDf3NS0LMuznp7oBSIu+zflAnjvmdBaKSUu 1CszUUvH96weLoimmxQBZZ9605/QY6AuZM7Du9A2UObPqIz5hpgqbWNltFmu0b5rDdPJBnoCsrj qnrCvr3SvdekSt4CRA0= X-Received: by 2002:a05:600d:4:b0:480:69b6:dfed with SMTP id 5b1f17b1804b1-488d68ab2bfmr66116265e9.24.1775897083054; Sat, 11 Apr 2026 01:44:43 -0700 (PDT) Received: from localhost.localdomain (ip-86-49-246-182.bb.vodafone.cz. [86.49.246.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d689110asm41117715e9.35.2026.04.11.01.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 01:44:42 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Date: Sat, 11 Apr 2026 10:44:02 +0200 Message-Id: <20260411084402.71837-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260411084402.71837-1-joshua.crofts1@gmail.com> References: <20260411084402.71837-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts --- v2: - changed ull to u64 type drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index 8873a6d11e..4221e51dc4 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -112,8 +112,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i; + do_div(freqreg, mclk); return freqreg; } -- 2.34.1