From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9208B339705 for ; Sat, 11 Apr 2026 08:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897962; cv=none; b=hiQficoafYHDFsxBrin3DOJWaWRx1FNvf5eeSk0dGnrjKEp5rp/Xp7GXDdN5kSZCtbyFpjm8o5Tj3Pq/YU9r92Ch7KZbYFuh+q5hP6myRMniuCk+57S/YMJUUF0IZuNq+FDLWwIQfrgF9syiffSSYXCYDoWeWNeqDfPFlS1prMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897962; c=relaxed/simple; bh=7Q5mva72tlCTFYBzwEvO2ZFGsF1JnnlsFqj/wvcMAdE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lf9l4r+3B/zwMtYOVbLkSv4daiDH09KNGc0xflme18U1RDUX+Xn/kN4THf9wCFfSEKKC7Weyspjz/qdHZInM4MYFACPkhm/qnoRVVchan9eoWkcYw2GrruZYzbn8+NDrzpim4I2EeI6aLlGgo5YpdKdOODz0ehDQgAPOfblbMIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dJ8JvKUg; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dJ8JvKUg" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43d17bb1c65so1850943f8f.0 for ; Sat, 11 Apr 2026 01:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775897959; x=1776502759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/z9NrwlpQUG/cW4s7HQM8LOZblhF59Jnsa4w00A3aEw=; b=dJ8JvKUgHpRiKHM2cdpKDwLdwTk+d8LQiXDkbFoQxF0McJLP7Y0kpchbvGLt8xrvtm HMXltQDVK7/i5/wIgq5HZX88aoFGB0tEIt9dLb/DPyFhpCweQzDUesN90E4Moy90RM/p 3w+M1JASSymFipFaHq87C4kJM+rozEqGzPGD9U/8plwj+fuDrjx5uGs8IhhyBXUN9gum blKGbyVlKeUPNlmQRlMiXETZLmaT1/fme0a5kDaaVBJLjGCjomiTZm92pjIH2QYtIbcs TLkp7etj26I4sY5fKUGOWdJrNqF5o2ToOYH3rEllzkQBQiBBWKUQBP2i72oXfhF0wnD6 pfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775897959; x=1776502759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/z9NrwlpQUG/cW4s7HQM8LOZblhF59Jnsa4w00A3aEw=; b=A59lGuPomxHy3ya7pbISNhPmCiESRYdB+GPVFnJEGp6BfivTLJJE304zQ88TVnZts4 UCCzxZf8xymWP5gYmaCJXGGp0Pj43umQGCM+5x8YF163sOxUOetgd5YqeZzqujEiJh7d qJt+TUOo6lFPbAhBQ8nbNk8lktw0GbTd/H3iGDX3LdE7rElVECEgGAb9gZUk9l2O3Vlb 7YQvohfDgJOwC35rrTiK6kpzqkmQtDFtVJ5DG1ILWLjPnCLI24fdn2cnxYYxEFBk05rm xJrr3UZuk+dgPRY/5Lc6YMrGBWle1OcLEjbsjb9QCuXgFr1lv9m0hVyOwpXXmQZvah6p uEOQ== X-Forwarded-Encrypted: i=1; AJvYcCXuOvW6P16QR3lbLrspT/e4SrMbXToZd2wklwWgqVCvHawMmbNoKSROa6gxtpm+Pe8Xed8b/iHkMjsPiiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh2ulVOUJTGxX9FmvMH9Rfu71dehrqjMlkpNK3pVRHb/5sNR/U 8mQPAxnmv0fHvOgIbm5b9+RuK4fAi00Ek37dsAtuRGOmjU9u7eBtR6cb X-Gm-Gg: AeBDietGFrbmm1m1I8swjt9LETsAmcFl+icC8Xl8BRzaV1OA0YGRvcZikam2miWiehH ncAesjrYLuDzqVgnsGtnq1ZbW2ssupiE1AX6dCWVMW7hVN2oo82dIXMHwAwah+dzhJ1jhGcWlGD AZfouY/Xp6pZJZ0niTSM7kWryySSbHjl9z/0qesSSgXElOyrwS4s/hQ9up6IcnQaC1aBvgCXyzN bIm8+znKNmdw6bjyqqslYd7JD/2zDEp4yJWkT4NSh512baS0mSpJ1zq0Q2IVJhu4U7mMw7pbjFy H7KOc/CPEal7GNZsyPU/BtURiTsEIIJPXTJkZxEoQ6IZdbgMIwaBWXTPA27a3kDU02dMg7dNER5 /lDGQUNvkVZ64jGj6tJW1xDOf8WRb3M/Ftkzq4rQUN4Ad2ias13vpTES3aQqpJTHx4jgpfTTSS7 Ok9BDXHiswRIIWfQp7NFDvh9vrzYf8MNc+dRiRfvezkoyp0Nqe6FbhgHtQzJ248a2FrWq5iyrdu vulCeR+Hr3vHcTKhkJ2Y0r/mN+mAxU3u82Wl7ZRn3xaUal027WQVSf8xIpOM0AmPYfJHS7s5CS/ qwAYtVM1WyiMUWwwE34= X-Received: by 2002:a05:6000:1a86:b0:43d:6e0:9458 with SMTP id ffacd0b85a97d-43d642c08b5mr9723343f8f.39.1775897958932; Sat, 11 Apr 2026 01:59:18 -0700 (PDT) Received: from localhost.localdomain (ip-86-49-246-182.bb.vodafone.cz. [86.49.246.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63de2a69sm14483593f8f.4.2026.04.11.01.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 01:59:18 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Date: Sat, 11 Apr 2026 10:58:48 +0200 Message-Id: <20260411085848.75381-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260411085848.75381-1-joshua.crofts1@gmail.com> References: <20260411085848.75381-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts --- v2: - changed ull to u64 type drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index 8873a6d11e..4221e51dc4 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -112,8 +112,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i; + do_div(freqreg, mclk); return freqreg; } -- 2.34.1