From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ACED1A239A for ; Sat, 11 Apr 2026 12:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775910956; cv=none; b=hBv7nNuIdbaIF8xq+FMJwI2qJuVIBTbdVs0F2YRUMQgc8+0nXK9ItKbDDrBosn6iaLFOEat4lA+YcmSsuZtQFA3IJznt5DAG8wbUv9kElWSWu0SIdx1bIRBw7+o4V6dmf0rMKGR/OKTAMqD4h6zyPO1Mhw6kFBql8VXPZiMOCXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775910956; c=relaxed/simple; bh=efT4gFsu/j92HZWkfQpIUd+RFDi8g5WcBoyNbiB7f6E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r+qzGYoc6MEBkH5aXfulMbaPTKHPu7cz6TDa7RPKS6pa65hLFt4km6ofwycW3BvffhWrxlVheehiKdy1D3WUJ6w9Z4JbYB+N5qS1rmSSF1LzD9IeCZ2g1sixovK80fFjkrcU1ZCNAwylMX44GNEH1Uo9c5RKUYTb1knNxfn+oyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E3qdKu2Y; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E3qdKu2Y" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a29e6110so32625025e9.3 for ; Sat, 11 Apr 2026 05:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775910953; x=1776515753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X85TaJiSk03ThcLTorKFKgIn8WKe/qweX0BaBKvuylU=; b=E3qdKu2YcX54wkQcq2ULBOe3g+WDaBZ5K1+RRD4/8e6eFY/C/BX/rKPxlGnqmqyyg3 aUSbOv0irJKqWYdQ+KQxDatSocw/9yX39MSrO6Ntkv5FesTyOwVgcIlt9dWJ0ytrQ4V6 Vveoh1em9Q1G3mFms7YXEqjlYss2qsiiYCE8rQg4jb0e0cpzbnTI6AVNqvH1j8IAHmgs cCl3OXBThObIKk6P+ki89lhNC5Vq23EHVe/avlafzI/UOKAs42wELqsjXsLWyyhkXmGV OZ1pLIsXubUx9b6xhSs18Natp94zfuEJegHxR9zRgpJrJKUWp2bvBh7geCM2PEZO8E0U 0L4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775910953; x=1776515753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X85TaJiSk03ThcLTorKFKgIn8WKe/qweX0BaBKvuylU=; b=izepwgjqsE6siYzRwkyBodh5mTbT60QBUMwMv2kUEMreMQkKKYDS39hzXAWzZ6BGGd wYyFNJYrTg6liQoOnU1E0OCGC+jP/qYZXe2O5hTmkVsQFVI+gCOpaKJ3yDqZ/kynlVos 3FRuEmCFslh7Y41E4ZsHSp/5oeSNRZOjLwIhelIlMQjjixwwQhb+dWNSE4tSSah+Ep9O bIPmS810RtmJkeLmNbLZ14gMiR7q+LOhYIzbey6NGlzvoX9y/TOaPKpXEj6xMLjbXM1F 9vCbGYG08pzwrdpP2ALu1Q7DBhe6ajsjijEJ1qEBX3RwfanMaqxzelvmNP8BmiiH+8Z2 J7gw== X-Forwarded-Encrypted: i=1; AJvYcCVX2l3RWqk7TiPyURXGXhy2N8ahuzmOoyznlSvXvlVKnOPFiz3qLWckJG2jFP4xJ2GyNiU5dZXQikZGiqg=@vger.kernel.org X-Gm-Message-State: AOJu0YwzjDWL4dKgyNhgNI5Im23mEtYpPkTi8kyiYqb9icD33QH6zwnB V2AIr28ph0TCQZoufrV2KjDBd6TKuX+jc7z8htDBfWH2CNjkR5Af0sQq X-Gm-Gg: AeBDieuUU5nCLd4EOLoN8MYPmDGtNp9xpePEX7CWgzk2IlzCqic03aSfJhdqpY6Hne0 VGCGho50zYZZlMQ6Q9BnqAoqag1vgnqK/EVPKltyxVGlXJSYOM5ewv2E+wTzFH/Y2WzaX8JCX2v fLfRe6vFRXEqHJT1SIQ3G6u8ffNkJDtJa1aF4OqdDgQOfkdZzZ24bkKxw7DG/G1m+aG1hL7Pibw m19+OAkCixvwBRrJJ5FTVXcg/+ADv8aqcp9UMAR5r+Jk3wi1hx5oNYszU6iN7F7EcMxGXf5BSw3 B0pp6MAYkAzfhsyBfAwALrNj1XxmxVY7xmPZMRs5pGWSJ1BmJle07UO8kPFuq4WeHpVCQWLY6rF hXmK6Ibca3qL6iXRvewnaHzBZTPbEdE1j3yGXFW9djIMgXNVPREallFabKfl46osoXxxQY5W3Oq AnDSsiBMpAO38cM/BPF+X+8cA4m3Ysau7jkWB6y6ornzzaQcdvx/tqFvAuCuzn1nhpojk5sLt4W nmiQwmSUZ2zccT7XeExp/F7oycHjLccJbZzcOz9eJKJMERqUnghiMN8pooJr4nmFxIzfv2xdmNz Qh35DsedpAJJ0aSBBO3rtBVuBULWN4B4DXth+mdWAOUKIEubiuwX+LNu6MfEOmn3fjO0URcJu6c = X-Received: by 2002:a05:600c:5397:b0:488:b8bc:6a32 with SMTP id 5b1f17b1804b1-488d68a4765mr95095325e9.23.1775910952548; Sat, 11 Apr 2026 05:35:52 -0700 (PDT) Received: from localhost.localdomain (ip-86-49-246-182.bb.vodafone.cz. [86.49.246.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d67ce3e4sm103104385e9.5.2026.04.11.05.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 05:35:52 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH v3 2/2] iio: frequency: ad9832: simplify bitwise math Date: Sat, 11 Apr 2026 14:35:12 +0200 Message-Id: <20260411123512.84739-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260411123512.84739-1-joshua.crofts1@gmail.com> References: <20260411123512.84739-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts --- v2: - changed ull to u64 type v3: - removed rogue vim typo drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index 8873a6d11e..778aaa8747 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -112,8 +112,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS); + do_div(freqreg, mclk); return freqreg; } -- 2.34.1