From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AEA83CD8C6 for ; Sat, 11 Apr 2026 19:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775935099; cv=none; b=DsYFH2cLVUF0/5dShw9GRcogZk4jrogIkzhJ3umUKznZBot/MlSHULsO/n1ZH2Mn6M4BAutD4OIm/hb8OOuept7dC4HF4NI9F4a8fiavLjifCVEjZL8GINa4DaJWWeXws2QEJbiMGs/9TAlmEAaGx+/XkJU+0J4aOXReqHAQhKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775935099; c=relaxed/simple; bh=bF2MTsPG8O5qt3z4+q+wqvjiW9g2BEL8MEkV3/7cMyw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ka4T5yDjkhg+b9LP9DfB7GKOV3/owSEEhxWVAQuZs5gqYHlizbVQ1dwhRpjJICubMZXTBsl+gbOIyteK/oApubzmPFhn+F6TTj3j6xnv8Fp09NMKMTo4rKjGVA8MSofgwkG0949CA7zTbnRUgvSNzZAcTiJ1jkxpJWCkIfpiFZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Km0zNC4e; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Km0zNC4e" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-12bf921cf49so12377978c88.1 for ; Sat, 11 Apr 2026 12:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775935097; x=1776539897; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hNvTyU3Q21vQ5oShsgnoSzW70om6RQ7VClowwcBZ1hE=; b=Km0zNC4eS9EnPtR+2wcUwbX2jMqeCv5eaezQrAyLhM7nvgscbEqBIdCZ7XPurq5la0 jQl/I0UkKoSd+0XpPz6wIyfxMH5czhmw7mlkTZP5iY+83tDk0e/98zQWRr/56JWtmzrv 99E6g2gJTxx0K4qCzR+neTF8FePOJUG+mZDg9FlLkb9515llqpHX7VhL1sAeFLxw+4jZ PouoppjOAexuzzVKXPzgDZCpiC2/ubSzH4KBw/C6YiqqKbjnuxVvactpcCB5SQ75XmE+ lYHrvrwQ84AVf010o5RW7qTSCrP7Gt+dRC3qk7r14zx9QCOqo5578t7kQE7wXFVv5jDd mNGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775935097; x=1776539897; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hNvTyU3Q21vQ5oShsgnoSzW70om6RQ7VClowwcBZ1hE=; b=ZLowp75jDX775UHgKu3ASzGHg9EWG6IPKo4arW1CanZONXjzypfBcpHsig9U7sheGx 0aO+0+npj9ZYpWbX9jrbMc393hPIj9Pw7KNwr64kRTpHDJshpFVBo9Pk+5tHvk9byIeq ZfdSWV6ipy9HUvZRAdbYCD43wSSV1WqYYqSb2B4YVlkXo6A7QLLBJHD+jNCtFioWnNK4 Hv2BaajJqXPGOGt+B2ikM34+Hu+FPqUJOho9H0T9iF6a6b6XW/A25J1XG8+G65O7nX6O wwWs4zRzRmeqcbtWw7B/YVZYjpU3PcsQ4j6mHSeCEpdVYQpxphmTGie65eR1Jc4ZXmQv MlDA== X-Forwarded-Encrypted: i=1; AJvYcCUir8Dhtgm1GWS4X1/tleLN2flmclD7bOx8eZTShpUqtc41whGELrP6GCuXOEx/Zvu4+pr01E1yj8ZdERk=@vger.kernel.org X-Gm-Message-State: AOJu0YyxUBu+ft7IkVbX8CnMee5wXW8iw+6t7oT1Ecbe533cpGAz5zdi 1eihrbX5uvPtfiy1PL4ZhiBPnvnsAPZ7oHNC9eXJ/LTPZuuH62af5eDsq9q/cTR8qFCeaxd6fri 7b5tyaa/Ivg== X-Received: from dlbou15.prod.google.com ([2002:a05:7022:110f:b0:128:e0dc:644a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:fd01:b0:127:3b1e:7e0e with SMTP id a92af1059eb24-12c34edeef6mr4817662c88.20.1775935097046; Sat, 11 Apr 2026 12:18:17 -0700 (PDT) Date: Sat, 11 Apr 2026 12:17:08 -0700 In-Reply-To: <20260411191710.524998-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260411065718.372240-1-irogers@google.com> <20260411191710.524998-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260411191710.524998-28-irogers@google.com> Subject: [PATCH v9 27/29] perf evsel: Add bounds checking to trace point raw data accessors From: Ian Rogers To: namhyung@kernel.org Cc: irogers@google.com, acme@kernel.org, adrian.hunter@intel.com, ajones@ventanamicro.com, ak@linux.intel.com, alex@ghiti.fr, alexander.shishkin@linux.intel.com, anup@brainfault.org, aou@eecs.berkeley.edu, atrajeev@linux.ibm.com, blakejones@google.com, ctshao@google.com, dapeng1.mi@linux.intel.com, derek.foreman@collabora.com, dvyukov@google.com, howardchu95@gmail.com, hrishikesh123s@gmail.com, james.clark@linaro.org, jolsa@kernel.org, krzysztof.m.lopatowski@gmail.com, leo.yan@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux@treblig.org, mingo@redhat.com, nichen@iscas.ac.cn, palmer@dabbelt.com, peterz@infradead.org, pjw@kernel.org, ravi.bangoria@amd.com, swapnil.sapkal@amd.com, tanze@kylinos.cn, thomas.falcon@intel.com, tianyou.li@intel.com, yujie.liu@intel.com, zhouquan@iscas.ac.cn Content-Type: text/plain; charset="UTF-8" Avoid a tracepoint field accidentally reading out of bounds by checking the size of read fits. Signed-off-by: Ian Rogers --- tools/perf/util/evsel.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 3c10b840778e..1e0bb4cb995d 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -3727,6 +3727,11 @@ void *perf_sample__rawptr(struct perf_sample *sample, const char *name) return NULL; offset = field->offset; + if ((u32)(offset + field->size) > sample->raw_size) { + pr_warning("Invalid trace point field offset %d for field of length %d in sample raw data of size %u\n", + offset, field->size, sample->raw_size); + return NULL; + } if (field->flags & TEP_FIELD_IS_DYNAMIC) { offset = *(int *)(sample->raw_data + field->offset); @@ -3744,6 +3749,12 @@ u64 format_field__intval(struct tep_format_field *field, struct perf_sample *sam u64 value; void *ptr = sample->raw_data + field->offset; + if ((u32)(field->offset + field->size) > sample->raw_size) { + pr_warning("Invalid trace point field offset %d for field of length %d in sample raw data of size %u\n", + field->offset, field->size, sample->raw_size); + return 0; + } + switch (field->size) { case 1: return *(u8 *)ptr; -- 2.53.0.1213.gd9a14994de-goog