From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 511863822A5 for ; Sun, 12 Apr 2026 15:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776006421; cv=none; b=NhTC2gndo1yCxGZh+ivxG1EU0pCl1QLY+x3qbcQLxU9wwv8V4Zcp+aL5UHzSibCK6c9wQdeucu/+ekJ2oYakuF9gT4c3hV4zBNLGcJlQGkDzAdQM05tYE8vLDf9pEQJ3DyOhvqjLmHoedqZ5KuBEGWaHtscTrcYpelCURhHWku0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776006421; c=relaxed/simple; bh=m7xWSxb9TyiYOvigyaVN7HrPkQL13ia6i1hMvKs6mLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FHoBAaZd+E6NxbC/x0G3m4Qft68r5sfE3TD88LexKdPV2IkeB6GZkzr0QsS+BTlr3HMJL/I7MUQIAXkW1MoUWRKqElQi3/rvDWuUSfYdq+PLBVRzzJkrzHygnrP5KVasmGHbspL3Jf8iBxh0W5aoiVmiN6TzOb1ZzcrnVMSHTGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BpnydoaP; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BpnydoaP" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d0deb7ad5so2773384f8f.2 for ; Sun, 12 Apr 2026 08:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776006419; x=1776611219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O4fBwbwXG7US67w+58dVfuhNqdsLmf5NrveVGQWD/3A=; b=BpnydoaPHPbj6FEPz9zUoKmgMu0RYhiML1O9ya0AuhE0BEsrmrlgTEcSvFvWXS/WSr Dpbuc3enq4Vh7GmlhHrp3NNGxDB7UkkB4IqmFUqaLznfOjj5e53M8oWgPpWFDvbWXsCE xQ2mv55uz1Hcea6n/TrLDQvTgHMqtTtk/iBNQOQ5GiU6Qfb4WQRL2UDSLV3TnZ98JPHb vtB5BosrqxOCVMYpwQXu7KDLjAmxU0vZO267e2SubrPjDfSoo2euN89Z+u37FgF3BJcC 39M9j60mfkq2BUuOI821s1/ZgbAxssLHSLMVYMZA/YUy260OZ9NIDbjZUrCll+JqfTQ0 z1qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776006419; x=1776611219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O4fBwbwXG7US67w+58dVfuhNqdsLmf5NrveVGQWD/3A=; b=NhtLPW1mv0qq2yjPoqCIRsIontIdrQB2Vz9JYH/JgE8Nn2t6rhArk1NzT8lSMbfNsK mm1zJUxiiZmmqjHHeLsoKOt6YjIjjAF5EnvD1LClPT9uEGTdhngSBjHbPdTLEC3q038i 6lR3aRDfBBl3vNvXHifDR6ULp2jIcrZhnE+mlskHzEjBIp6XTB1dWcHUZEUc+XD8uAGS v6IbbaNZ2JfaStRiTlJHOx1iaMk9Cv4D6kUuVgAuwOekfbjRf24M8rgs9Pk2wyOGEdcy bNjsZrX22pOLn/LvuzJs7NhKR2kEfXs1IxkwdxeOTTyfV5yAmAEdLoTl4apuOGBDEp/3 epuQ== X-Forwarded-Encrypted: i=1; AFNElJ+NFDqhJ7llGQQWfAJrAitUZhgP9d2WnKc/Vxw0j+bwUBM2VOGrx7HVXcTSs+3vNt3QZ9nW6/7QxKAgksI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9Z3YiohoB5lcxj84redLY9rR4s43BKDr2FwfJBjpCbqlHEOva yp3yfXwJdWuJg27+NEXfRaTIJgtt8x5UU7bW45uhjqUl9141SIrr3wrr X-Gm-Gg: AeBDietqMZgxZbsaxVWxNO9dwCQApwI1EwAXA/fF4AllbnuScQ51U0+rifMrtzH1box wmsy09qN3FIUrk8vrIjnh65+uxw8vuWCL+d+FMmmiv1qTbMxqAZTC4A9fwEHUzlZhgo3ADVYyzi V5Sg5WcJKTmjuKTe+f7sRvw5Q+KkG5CEhK3hAp4U+vtMggk+hI9L9JSfDDxZ0TQT5xt4MU605g2 gj3ZorvGzu5dIQ6z3IrtAkmJ8laZaffzqK9tdT+JpSrKNS7aH0CumgO5vpUxRtaQ+bdXo8RDJGb D/h94We0EtzFs0iZU6r+16Yb2MBg8H21Y83tpV0saxzbXi6H26Lqa1KRIzfFoGV4Mw70HSA4vf5 3BCnIYaCYPbsDIR7OwthbjVLiURnNIHwsl/cL1AFw2J/+Uo4M8jLnTKPT4NXuDVxoET/lojMfhE V3Tz2OmAvnIxMcvRNd8GicNGlQHI2o+PE9NGMWAnFuuZQJejXYZTeY0gYEzjWOhvnASTqEH6jwE 7V3n7ALzexh X-Received: by 2002:a05:6000:2c07:b0:439:abcd:b314 with SMTP id ffacd0b85a97d-43d6424cbccmr14385438f8f.18.1776006418635; Sun, 12 Apr 2026 08:06:58 -0700 (PDT) Received: from fedora ([2a00:23c5:4a5d:3701:b24c:c1d6:5c61:a2ed]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5ccdasm26760351f8f.34.2026.04.12.08.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 08:06:58 -0700 (PDT) From: Josh Hesketh To: Greg Kroah-Hartman Cc: Michael Straube , Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Hesketh Subject: [PATCH v2 3/3] staging: rtl8723bs: remove unnecessary else after return in sdio_halinit.c Date: Sun, 12 Apr 2026 16:06:33 +0100 Message-ID: <20260412150633.12071-3-josh.hesketh@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260412150633.12071-1-josh.hesketh@gmail.com> References: <20260412150633.12071-1-josh.hesketh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove else branch following a conditional return statement Signed-off-by: Josh Hesketh --- v2: - Rebased on staging-next - Split from original patch 1/2 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index 4a4f6b03253a..ed82860ae9b6 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -641,11 +641,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) padapter->bFWReady = false; pHalData->fw_ractrl = false; return ret; - } else { - padapter->bFWReady = true; - pHalData->fw_ractrl = true; } + padapter->bFWReady = true; + pHalData->fw_ractrl = true; + rtl8723b_InitializeFirmwareVars(padapter); if (pwrctrlpriv->reg_rfoff) -- 2.53.0