From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D900038238A for ; Sun, 12 Apr 2026 15:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776007479; cv=none; b=YX7CpG1HirklvdQ3Pz2RCT2h9u0OOmkkDhVe4TC8lv7xyq99v2pwjIsLl8lbd1sSBz37eXovkakdH+1zASQ8Uh2D2z5bWJCl7y5cPSjwt8V/dT553yZvFSIdX1N/jZioy26Jsaqju6pAVTJxSzxXIQLGzEZ6XT8bD6h2BKo2IuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776007479; c=relaxed/simple; bh=s4lztYW+o3nGIxFjsxucEcD/mHJsr45a8yPmtPrgowY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aH8e/RX0H5dQK6oamKI2NDPjfhPItvEc2CdJHiyskD2O7zb6WBOmHED8N5ml1qn1RscsYO8/T+yyiCiLT2kbegkYG+RuK6WCg7VtwBYLMHzEERmkeKs6VwyOwi+/kPDIQVmBxmOtjIIsj8p514wDnPWYgHcFNCDcHztDKjdXkN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=xzW6xrEx; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="xzW6xrEx" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-47018d34159so2649038b6e.2 for ; Sun, 12 Apr 2026 08:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1776007477; x=1776612277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ia5I7mTnznx5IS5yxdTatjnN99ECF6Uimb8GJ43NewE=; b=xzW6xrExZzOhiWSZh9NAGzkSpdP2Wtk6VVHyZn3pPlQx+5+xKJcjTkc+MSX6AbuhmC FuXfldIQR4AO9rd3cX2tH3q+UEnKGKxH7NdN2RlYP9VBvZp+kZTlWMQklk14ZOA2PpnD Lk2hkzprPdQa9s0bdpk710A5VP3a5p6uvb5bj0gjzvzsgcnwW3qTkoT/dojzd3JpMp7v V1iDLjCdDd6VJbPY8EP23VvpjEJyxi9eyXcGgY0iHvDqnphjHFLjtmKZaChwm+YMY5ds BhQ5NI9e15sNRPOwVAajgb9kYueYLQdH/U9w6XSEbawFjy8iLVC6Lt7Hu9bWz5WfdJMW v+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776007477; x=1776612277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ia5I7mTnznx5IS5yxdTatjnN99ECF6Uimb8GJ43NewE=; b=kdN0+GSybrvoVQnCIE1+o0mmgNyjZa5ORDMH8pkH7sLT/Q3YZ/hTdsHYl1DNerZHjS E2RTGf53mpdN0VfA3wCto9InWne0z/tobFooEj7wDOFJdSMO6V1ulkLMmdQ6ONwTpDp/ Fh3/wkEISgPuckK7atmM+cqiEK7juyTnb8SxynBBkLqtcgqs33Hcj6UWSC5D9GMsvFGM L1ELJHMbDRGIPPQBCTPIX9tGfR4+kW6ZJfh7YgtiXbXOrtngQcULliFAF+rke827faF8 a+QlWIc3pi3G+6mC4UsVIe/Ua34r3rlXLAqUlhd6BhQJ2Vt9KrPhmeXzKsk2t27YsCYC 7B/A== X-Forwarded-Encrypted: i=1; AJvYcCVEBzlP/pNnhn0BAwj8Gjv/IYWg1B+Z9wBwb/8+Ew7ZCyz69gyRMu8wlU+pSNgh4hC6I0DMYkKfOCLyneo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+h151fAIauFKaUlR2TKqQWrQa8mM119FDpmW3vI1moZ3PV+66 xtObxd+ROiPf/8lIjXZlqTOXgmBSphB/fu5hjllGIu6zc4e5ziIzjxre+hazfx4LYpM= X-Gm-Gg: AeBDietYqNeRQBXdBVfFBtqcms0hMMmbBaQ0yJcWaNpA8TM5/65ihZ5na68F9qLL4CC AoSkj0lZUsLbg2bwXol5WZUusfNKqYb4+OyYdkicmup3NbZIBGz3+GTNFz6s0TrWlRsJ3noDbMa vIQIH9BBRG8cDUbSM7YEul8+NSt/QXuYfeEWuZ6G21dRG7zuvyhv0PCaVuT4GH1wz/W8whHxlHH 3kNyYKi0N0wwIYiLX6eNDuI5J7vpOBOoMLyj3gk9mSndtLx2V9McZPXCnc8crnJliWTGppZvRmI cH4M5QnYQKgptZKX1UDwGmpdgm9P1hfjriuEnh20hs8BT9S9mUNhrgnk6JIUqKebIwcGAJxO0ur Sv+Ua5sWWdCC9zcLXbwy6M31Dq6/LzQCM2a4WhH1TAh53QuZEuua/5QgR69XcRGHTGSxYtZZyJT pjBuN7E5MnUwaDwaLoOFkLFwxbCssuZa7k X-Received: by 2002:a05:6808:528e:b0:467:f9ff:7c54 with SMTP id 5614622812f47-4789f906ef6mr5327880b6e.45.1776007476784; Sun, 12 Apr 2026 08:24:36 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5614622812f47-478a2f557b5sm4911726b6e.11.2026.04.12.08.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 08:24:36 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v6 2/5] net/sched: netem: fix queue limit check to include reordered packets Date: Sun, 12 Apr 2026 08:23:52 -0700 Message-ID: <20260412152429.143474-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260412152429.143474-1-stephen@networkplumber.org> References: <20260412152429.143474-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The queue limit check in netem_enqueue() uses q->t_len which only counts packets in the internal tfifo. Packets placed in sch->q by the reorder path (__qdisc_enqueue_head) are not counted, allowing the total queue occupancy to exceed sch->limit under reordering. Include sch->q.qlen in the limit check. Fixes: 50612537e9ab ("netem: fix classful handling") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 8ee72cac1faf..d400a730eadd 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -524,7 +524,7 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, 1 << get_random_u32_below(8); } - if (unlikely(q->t_len >= sch->limit)) { + if (unlikely(sch->q.qlen >= sch->limit)) { /* re-link segs, so that qdisc_drop_all() frees them all */ skb->next = segs; qdisc_drop_all(skb, sch, to_free); -- 2.53.0