From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1731382F20 for ; Sun, 12 Apr 2026 15:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776007483; cv=none; b=M6iG8mxFuU76zZjHwAdq4XtfKHp8kRki3kd2Jg0P5CI8kijvOEhtFy/leSFeyW1o8PDKoqCVDejiCrZF+PXXA+6b9tuFsxH64fagSSAaYroiKQSfc0yDnS9bUPe7P/aXhdgkNuxSHTTr67MiBlqog86w4ZCdIPGzcClYs8TWitQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776007483; c=relaxed/simple; bh=I09+T99cRHxHXCfO6vMWl5KaObArwL5OPn+xV2JmRVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OBNDakqiapQfPNzdnd3UV3h9mszILOD7sT88TrQRT6gRKj7YT2B246z50FVsxT0ZZ1/dTrIp5oZR22UmGB3LQByTIJYXZdlahb7lyb5+Q15ogwsM4uBHFHB1tW2zczZVikiP8quv+KA9RyBbKP6t3PvN6GMVCApWMfPCM1m6QDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=AWbaLvgx; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="AWbaLvgx" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-47952228f05so129975b6e.0 for ; Sun, 12 Apr 2026 08:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1776007481; x=1776612281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9WINlmEl8Y50KfKycZZYh2811Z7NSDaIahrEzQUkOfs=; b=AWbaLvgxi+cJX/SpKsZQOEDoqnLcLwrxGIQ274O9PrHY5wL7aRoDjkIRXveXugDBKP KSa2Mywz9x6gbHHRxiNnHTtMSHROoIuNU19Tc0aedBJ6pdS09Qn0iEx+cGhL+RBRhk1l gjTh3niMEJMjTKuuPJ4/uF1/WC+SffflVZY2aSSwJW/9UPnZO1hI8M+GpzkAtf73lhsH BhBrB+/++9hxEIO2xvTmdO9wRvnp5AM0eugHs1eoc7RUGB6EBkK5++4bMY9uz/ZUxZGc cFahiA/uRStgdvGiaw8WRZVstjB4CKwVHsyszcDID9Ml3PDYBqwC+0tGbw8BPhy0BhY3 n9rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776007481; x=1776612281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9WINlmEl8Y50KfKycZZYh2811Z7NSDaIahrEzQUkOfs=; b=T6kS/F7WQU50vBHMzhNouwFDVqKKtMwbfl8v4lDnH74SseAhrmrW/+CoQZjuL1fEUq +QbDuMwnHnDdoJx2SHm5xam1UHiZ06tFyipDjRAPWFPJ5Lk4VSSiWEnl2HxfO9S/6QQT HzBQfYuAvWmAJktAMFsNAl2t9hLPsxgByWp8KYR18SWJi9quRc5PcIMMOAU/DJG62Knz XTr7O4OXp2hKO6bsQTjmOp0bZYPrim0RY/ib99dSNHtQZDl9ip0fXaa3AhTzsr27ARyr 7pkpZauHiJKTaF8OC0XC07M9vZV4FbOJxdQDHgnPtn4eCmJsNOlbYa0DNBOcqZpgO5ts f8cQ== X-Forwarded-Encrypted: i=1; AJvYcCVE9G5ryffDRsdkyARPIebPn5IxC7/HNvEI4ntlBtvu/heZTB3ZRiJaD2m2vmH2zG7Cau8MPNXdODtexdU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1hpVlKr2YPpHD1UtmgGa/eTGpa/boXt33WpvtfDL5Oh/16v7O 2JxKuz7/ZtokBdRtr0f05gHLTsDa5VwyTgwD6ecZAx8st+pk+AbsHDmr+DWcJ2V6hx0= X-Gm-Gg: AeBDiev/5NeT/gugggBHcXaJRpuT/M8FFBp74zabXf7hOj1gyuFcKBfryaQYnEom4Z8 O+oFC/nf4SAMc4s39JfyE32zUEZKvaOmxz5eDEMWptb0wdTiPFrPIikGF8/ZftbM2z3E7x6WUvI SErT9cS6ocNX4wyQbqMkLs31OL8qi7KWLeJgtG8vU9zcV8rrA8f5Kb0LUuUZx0iGa2Rw1JJXMsU B6qbMrGzF25Z2rvxNtvfjuC/Qhm2ThtjNr1IJ6HEzcbHKb8IhEVSq+VpDtqsBDd2VdBeTwXdULE zqwYo6O2lpeT+knJSakO1mTfHNOTfqyL2QHVW1wjeW3aZLerHsfOLrR/i8BjMM3+mt//EqXSsfu vG/IFrhFngvtzUsCHWqL4i4ByWADgl+9PhXM+7mMD45pZjK6y/VHxMgvlhWcwYcwFG852CSbby5 YOd9Mlv7ZxW/GM94W6sQsD3WA33O0//zAK X-Received: by 2002:a05:6808:1495:b0:45e:f888:695e with SMTP id 5614622812f47-478b70a7648mr5449396b6e.11.1776007480943; Sun, 12 Apr 2026 08:24:40 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5614622812f47-478a2f557b5sm4911726b6e.11.2026.04.12.08.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 08:24:40 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Neal Cardwell , Yousuk Seung , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v6 4/5] net/sched: netem: check for invalid slot range Date: Sun, 12 Apr 2026 08:23:54 -0700 Message-ID: <20260412152429.143474-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260412152429.143474-1-stephen@networkplumber.org> References: <20260412152429.143474-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reject slot configuration where min_delay exceeds max_delay. The delay range computation in get_slot_next() underflows in this case, producing bogus results. Fixes: 0a9fe5c375b5 ("netem: slotting with non-uniform distribution") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 556f9747f0e7..16368948bde9 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -827,6 +827,18 @@ static int get_dist_table(struct disttable **tbl, const struct nlattr *attr) return 0; } +static int validate_slot(const struct nlattr *attr, + struct netlink_ext_ack *extack) +{ + const struct tc_netem_slot *c = nla_data(attr); + + if (c->min_delay > c->max_delay) { + NL_SET_ERR_MSG(extack, "slot min delay greater than max delay"); + return -EINVAL; + } + return 0; +} + static void get_slot(struct netem_sched_data *q, const struct nlattr *attr) { const struct tc_netem_slot *c = nla_data(attr); @@ -1040,6 +1052,12 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, goto table_free; } + if (tb[TCA_NETEM_SLOT]) { + ret = validate_slot(tb[TCA_NETEM_SLOT], extack); + if (ret) + goto table_free; + } + sch_tree_lock(sch); /* backup q->clg and q->loss_model */ old_clg = q->clg; -- 2.53.0