From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B7137FF5A for ; Sun, 12 Apr 2026 20:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776027171; cv=none; b=NUb9xOuj4U1i8oZkZIgGDVVadYpNlmMCDoYRFvtpfVPPBQT/XrMnnPxONecnu0q/sWttXxxmne3qNAU9NPnIVNrV9fbCq8osuowgR3eSIl31oOJCctdN3Kwpf3/Yk6Fg0dD9f71leLpxOv/3eyiNv1DS3FG5SmbROXIj5HbKZS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776027171; c=relaxed/simple; bh=V3bsKhIGaACHg6eM2xcGs/HQit58c7w+q2E2j1CAkeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cCeT61LXwV2WGHfDeruvR56MDJJN4y8w8O/xZdpARrhcOt5rC7k2qvI5HpUjmUlS2WqgJLFDjemLmbFMuHEuvFtzgOejOJnqgzsOqZpsTXkoCCCytbVxFGt2YvglUfIkdzp0yhHIOYJqIwV8J5KQmSKjakNseQHqBgE3gE6rfgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hgPxzRch; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hgPxzRch" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b9d9971d059so240131766b.2 for ; Sun, 12 Apr 2026 13:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776027169; x=1776631969; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZsyBN8eqgGgLu6vT6sEQv8tzWdzbqq6eDTPaal4nWic=; b=hgPxzRchTAuPXQGf+g7xsJUR487jBlBPP+t988slnWuQPcc/3AexiH5o7vut8s2wJA HO7RAukpTJapG4GeoTOYyP0TS6t7B/wZ7Z/fXbx6klaIazKM3CxV/6GUkfqD30f0Nqob HmIvJLMbpUDYK5oEkH7D/bQ5qhHkGvfJ6I/VFk3IBXCsJithZcO/YmYRNx9lhxTR/G7D WWshUNwzuK6KomO1qBGSM6Kt5zu/++lQsY+s63J8/fWwADaYPPXdQgwpDgNgJKk8ql2l c/OOqdR08MB6rObv6PDMvpVBjZIt1DeiS8uKx7SWJRFCJJokZNWOt2WIxKGXUTqYdn83 9LkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776027169; x=1776631969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZsyBN8eqgGgLu6vT6sEQv8tzWdzbqq6eDTPaal4nWic=; b=Aox0sSNDUxTwfDcg9FQ0I4q8XwWqpim+UhhPlpekZh3G+n4qb+URPiqNw9CqT9UcJ6 1YfTXssy8ydhmIFALWkk6vtuaCOQL2/NAJMWqZT/dJ7umbPusvX567aY75T+pwJ38aCG k6GL8QVINyNx6CKTX3YK7zwIRkJO06DcZ+qiFJujeZCd/gKzVoit3t3YWuMbsdMhkecy jg0kcBTZBSTj/yLlwb/j260Rg7mLHbSoiI/USTJi8AC2fwbT/GYtzryac5wOd8B+z7hT VI8nPPBiRfROLsmdkL56NxNCs4qYhfL286arJrK7lQ2noMkqQRE8JUHISpv8VeMVLWo4 jeIg== X-Forwarded-Encrypted: i=1; AFNElJ9UcE4G7Qg8JRwJr41F5nOHNUK68+EFkTB9mG5ho1sqOyNR/Ji/Ip0Xwn3GY59Qt3fi7CK5ZeRQidpQJ3s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf7E+8rpwBxL4qyMEXyot8kpr5PKVCLY/tOcgDM850ySUiGtg1 I64EYCaEaD7TqtdwaBKfUhhj463FttDLzJbce+Jxt4XIWLe9tEFPzrrJE75ZsinX9ew= X-Gm-Gg: AeBDievKHV1X2gj6QRhBXE7xr9RHCxe0QGCH7UvE0C5pjbapEoR9ZLAfi8vmRzhY1ld 7wHIXIQAbXtJfmfub299BJVOxvtC8LXkUsR6MI2XIFNFzJ8HM6X24M2Z1vEk1czlTGGqghcC8jy +LLdAWev5HLQCfnRcMbNXIhTj/4YNui5wciLaUCDTX1YnRCQo/kSGh/DYUowaA7UiiUJ3pj+8zu u2a7Jb9e4ipmt9m8u0pzDTMEE/INtgg7rdeVl3wxht4Q9baaqDlzeRea9SqNhuNB3jbCG3MOlfq KMabWDelKGKRsn6IdlT0WCbe9hn8iWedqQpAuZ3lVg9MZojXNIY7cNUNcA95O6cLrYMTKvG5Msv SXWVj3xTRVSUDwtNLA2i+jUBLk7FQneGllDCwka6xy8ArQ+pJtASRNgOrBoXjytOAcXwLITTcRX hgjkO9myGyeDms45RM035j/zQ3rOiT31SNArBh0A0lBeE5v0Hvg3GiIh9eKh6K2qrTtW7bPTty3 CJJn8kAc6EEVO4QdaLtilFBTfsrspzCQRPjmzlrsehyKAkT8SEiIHNxxKdxWh4cXcUY3Nyn1tel RrX5/w== X-Received: by 2002:a17:907:a603:b0:b97:c5e2:d7c9 with SMTP id a640c23a62f3a-b9d729bd51dmr596748166b.44.1776027168505; Sun, 12 Apr 2026 13:52:48 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6dfd78f6sm263126266b.26.2026.04.12.13.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 13:52:47 -0700 (PDT) From: Alexandru Hossu To: linux-tegra@vger.kernel.org Cc: marvin24@gmx.de, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alexandru Hossu Subject: [PATCH 4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove() Date: Sun, 12 Apr 2026 22:51:17 +0200 Message-ID: <20260412205117.387125-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260412205117.387125-1-hossu.alexandru@gmail.com> References: <20260412205117.387125-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove() function unconditionally sets pm_power_off to NULL regardless of whether this driver instance was the one that set it. There is even a FIXME comment acknowledging this. Additionally, nvec_power_handle is never cleared on removal, leaving a dangling pointer to freed device data. Fix both issues: check that pm_power_off still points to nvec_power_off before clearing it, and also clear nvec_power_handle at the same time. Signed-off-by: Alexandru Hossu --- drivers/staging/nvec/nvec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 75877038847f..9fe9b7a3491d 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -907,8 +907,10 @@ static void tegra_nvec_remove(struct platform_device *pdev) nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier); cancel_work_sync(&nvec->rx_work); cancel_work_sync(&nvec->tx_work); - /* FIXME: needs check whether nvec is responsible for power off */ - pm_power_off = NULL; + if (pm_power_off == nvec_power_off) { + pm_power_off = NULL; + nvec_power_handle = NULL; + } } #ifdef CONFIG_PM_SLEEP -- 2.53.0