From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E0A37E30D for ; Mon, 13 Apr 2026 08:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067362; cv=none; b=RJQ+A11p84HR1OeRS74RjkYzYSgYKmsJ3WkFm1DDOlvOHMDbSh0uZwJXbxCjZ50SfoQsB5K1BPPd0WLXxqBrw7tlpKxyICYZuF9DG0wE6Zao1fBi1ReiVLZN7yMz1oVgPxsFyFtsTyXS7tj3W3nJgdI7838ig8HzJBWEMtWlnw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067362; c=relaxed/simple; bh=BQj/LtLtvJAa8qPvNururbfdiFEeQmxim48bMkau+Ek=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mdc/27v3x6oURSlVu2FPo30mGL4FuJo4eR6yMHxO1kWaLxKC1S0NAIYZ8Mt/mahScGQ4/a5X719wG5xjNw2ScwkaSdHoUdIKfjpRywgRRBYn6skRdRiFR7nkUINr1AVli6lf1r0xle0S3RSVDT+e4W2t2CiDDJnB1GQV5Dgb7eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sDxwhHPC; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sDxwhHPC" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfde3c3f3so4100664f8f.3 for ; Mon, 13 Apr 2026 01:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776067359; x=1776672159; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ej5PuXGxv2ijMAzQ8gpPPur0ekJN7jy1Kje2MEZFQ7M=; b=sDxwhHPC/kAaUPifrhWH+QNatj5I7JEzbeao/+4Tv37OLdp8MJgt6FPk8KfEY3XELl +dLTH+ec4tpG/x94DRRBIGmUAuGT6WcPB7Vh5PI3oUONYSEF6if+lB9sNWm3ehbUZdpI FJm3pwee9nL5lpUkClaXjWHVONFotu/xayjJ00POFgqAX3lI5zWvgL4JXSeUP0pAholT VCWEso+dQB9nTMsfFkdKJoi55NBL8HyR8i8Cl+0VxrV7Fh8ndvYyGb0gT8TBMdBYFDdC 5KHxGxrJ647epSeainwOK8FAvW80cpPZR/vsIjCfX7xP41/KiJVcK+fZpbhT9zShgncL QtUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776067359; x=1776672159; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ej5PuXGxv2ijMAzQ8gpPPur0ekJN7jy1Kje2MEZFQ7M=; b=qoM2spNEeyqWOPXL727q93bw4/TGfm0ajNt+ubNmiKAiDb0Xwo5c4TsDdAVVBNJ5x6 MvZ9u0A34mO6utTnq/fmW4zZhCp3/S6hwgjvC3ABuiyGXSl8EgAleeVf+WROeePzSb0E wXvcmudMFu/18QLay20kAp6MWkOM3F0WQYFnaSLegwLEcC5bqypMI02+6nb2Osj/kOOR QEKgHmtNPtJtjKodjYQgmmoicNlUcwOK3SvvKIFzihHlrqNydOrfB+QYRcAl1eqYvMHU 9tIqK+6E/70UrQEGArIEDHRHRW9+brdBY/V9MtU0+PhesvQ1Q9iUQhRdAY8eH+bSBdMz LlVg== X-Forwarded-Encrypted: i=1; AFNElJ/EP2VNMVc4yqGQNc3NpkcQ3g3OII5pPwvk4w6sAfIebAloD3lAOdA3SOPewqptbgo1WJ/layAi9bq6phM=@vger.kernel.org X-Gm-Message-State: AOJu0YyV2mROANe+12CY9PTan/FkqIrcH28gNOemJH2mcQYH29fqQIIJ vyxWfEIToinkxbvFambbmtedhf23HbwXkHNq+V0uAISNZUx/eGbVrnhr X-Gm-Gg: AeBDiev3telRpil9hCnRXXscfLJnnujcmQS0MiGNCta5smGvY0VLzViI65aZAz3wnuw 0WtK67GlgCT4/FuGwb5rFlY2gK3FEy+QtFaspL9iWBJkt85irfC3twtzdfT7iE6fiu4ZYmToj3X TCdSIuEwVMGDzWJW91XkSClBfUBW1GVYNzIZ0FPrzjzTYtpkhRF+cFd2/QzsND0OVwdiXQl79sH u/M56TJIWhY2emKUtrSmvwedDX6azobelLh2md/QRLEGjC7bfhuwmVoPB4FNCxNobTSBGC9h7tX 3samlQvAZUmWHxJj0P3eU6zus2Kj0pjh4qqglTmjOwo3494gYAHZa/42Rs1Ms2vsk3zburpVe2G 1D6H5wGRwQ5zKvLuC+Tkm7TmqrffcSKQPxS1isE0oy94YWJOjBGJbzeSNafC5gcaejT9mjfnENt 2HARc+yTH2uMJTsbd/101tklhZ0Sti7n/ri4HgUX3i65XHmwch28M6bizu31bhYUrsqBeFqOieV 08= X-Received: by 2002:a5d:584b:0:b0:43d:7783:c677 with SMTP id ffacd0b85a97d-43d7783c827mr5141524f8f.42.1776067357834; Mon, 13 Apr 2026 01:02:37 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([67.218.239.37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5c981sm32155932f8f.33.2026.04.13.01.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 01:02:36 -0700 (PDT) From: Iker Pedrosa Date: Mon, 13 Apr 2026 10:02:11 +0200 Subject: [PATCH v8 2/9] mmc: sdhci-of-k1: enable essential clock infrastructure for SD operation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260413-orangepi-sd-card-uhs-v8-2-c21c40ec16d0@gmail.com> References: <20260413-orangepi-sd-card-uhs-v8-0-c21c40ec16d0@gmail.com> In-Reply-To: <20260413-orangepi-sd-card-uhs-v8-0-c21c40ec16d0@gmail.com> To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Yixun Lan Cc: Troy Mitchell , Michael Opdenacker , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Iker Pedrosa , Anand Moon , Trevor Gamblin , Vincent Legoll X-Mailer: b4 0.14.3 Ensure SD card pins receive clock signals by enabling pad clock generation and overriding automatic clock gating. Required for all SD operation modes. The SDHC_GEN_PAD_CLK_ON setting in LEGACY_CTRL_REG is safe for both SD and eMMC operation as both protocols use the same physical MMC interface pins and require proper clock signal generation at the hardware level for signal integrity and timing. Additional SD-specific clock overrides (SDHC_OVRRD_CLK_OEN and SDHC_FORCE_CLK_ON) are conditionally applied only for SD-only controllers to handle removable card scenarios. Tested-by: Anand Moon Acked-by: Adrian Hunter Tested-by: Trevor Gamblin Reviewed-by: Troy Mitchell Tested-by: Vincent Legoll Signed-off-by: Iker Pedrosa --- drivers/mmc/host/sdhci-of-k1.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c index 455656f9842d..0dd06fc19b85 100644 --- a/drivers/mmc/host/sdhci-of-k1.c +++ b/drivers/mmc/host/sdhci-of-k1.c @@ -21,6 +21,13 @@ #include "sdhci.h" #include "sdhci-pltfm.h" +#define SPACEMIT_SDHC_OP_EXT_REG 0x108 +#define SDHC_OVRRD_CLK_OEN BIT(11) +#define SDHC_FORCE_CLK_ON BIT(12) + +#define SPACEMIT_SDHC_LEGACY_CTRL_REG 0x10C +#define SDHC_GEN_PAD_CLK_ON BIT(6) + #define SPACEMIT_SDHC_MMC_CTRL_REG 0x114 #define SDHC_MISC_INT_EN BIT(1) #define SDHC_MISC_INT BIT(2) @@ -101,6 +108,12 @@ static void spacemit_sdhci_reset(struct sdhci_host *host, u8 mask) if (!(host->mmc->caps2 & MMC_CAP2_NO_MMC)) spacemit_sdhci_setbits(host, SDHC_MMC_CARD_MODE, SPACEMIT_SDHC_MMC_CTRL_REG); + + spacemit_sdhci_setbits(host, SDHC_GEN_PAD_CLK_ON, SPACEMIT_SDHC_LEGACY_CTRL_REG); + + if (host->mmc->caps2 & MMC_CAP2_NO_MMC) + spacemit_sdhci_setbits(host, SDHC_OVRRD_CLK_OEN | SDHC_FORCE_CLK_ON, + SPACEMIT_SDHC_OP_EXT_REG); } static void spacemit_sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned int timing) -- 2.53.0