From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C9EC1DFF0 for ; Mon, 13 Apr 2026 00:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776038791; cv=none; b=ntWzHjFjgI3c7TKFuWa6e9CFcyqCEqR/SWB/HmN32rJDg2hlpU/7+Ssu7GWRu17xd4wTkaSE1EQHBpntNNsRevQ2FG4/4mNEDlezTRZkXMr4cgcVQDfxy4tf9GMP3Lziny+blCX/+Y/XS35uHyzKrCyyj/eswDqBf1GvN/aO+oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776038791; c=relaxed/simple; bh=cN1O9COQ4H/r3RdSU8pK3htoPaZJP3YrdcpxmdMj1qg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nsQd/XDGYcH4bTHA/ERH7jgJgDTxT8Po5FI+mH8gJMhSIgNI4F2HAYsr93LHmKtewqfthEmapFQNGSknSOrfZf2bqCen2Eoy1aRbEaqfgLfbAn/OQ73Znvtx+yj5g/UEqnbHHPJkY2AuPjMV/eI5IANXm/Y0uWfHZg925z/vjyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WKh3b9SF; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WKh3b9SF" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-8a15ebb3abbso58171216d6.1 for ; Sun, 12 Apr 2026 17:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776038789; x=1776643589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cN1O9COQ4H/r3RdSU8pK3htoPaZJP3YrdcpxmdMj1qg=; b=WKh3b9SFr3e+4q9Px9uOP6rpqGPUd865pQQkPrts+vhtHSSzYIzz/nW/iCKYtQS5w6 qwq8TViggLwePyzZzctbgALxpx4ISHH2InUrpbjGXTEw5u3gM1A0x1Qg6DAVko8qjvSS onHIE/jsV++8PbBWaDPBttOua0Y78uvfdoj69cybEwPCvNtcf0XlW5IvjFPIz2Xma7n4 aJAzW+Y/OlKMjO/RPG47xU3lrUU8nmuoBIRH68LHQQBgCz1oo31GzWqqxoHUz05wKiii 95c/nJ0fJR11pVPyeIET2wch+OtamyYxZMXbQaVT5C7fm7oaSvKC6g4y+UIF88lpfXgW R53w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776038789; x=1776643589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cN1O9COQ4H/r3RdSU8pK3htoPaZJP3YrdcpxmdMj1qg=; b=kYIXQdJWymvXLS6SjmTU9qKQVG0CciodXp/Ah4PzyRG5vNcW8rML9WnkUV8WPi3D9v ZfpA/Bp0ITvffDhNJphmx0f+5zp8L394kR5R5V2/NhoZCnYnbZ0ywllf6F8692LAjHbm Os8Yn8K2lSxeWicK8Ve1yYn/tvtZShZW7YHuRiO/kIg2FJ8iFUgN8r2Jes4vR4VI2BXm Spl9hVBiLaN1IV211j1JXUklFOgwbcgU+L/LCtjWzlpgYOloUk2fHLSLU2b8T1qBcaoA g+97bvFBvXyg5+xz13CBgos/LqmDcxgbRiQey79kMxmXs1Hyxta4lDQvK3GU/RIBAmnw AsSA== X-Forwarded-Encrypted: i=1; AFNElJ8POZf5VBa1+VC1qGK0kD3f6rhNE8P1pUbe1dtZ26+UVaFZPNiFn4DpGwhy6tXAApDbRWhRyDiGgsPO4bo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0Y03FtbfZsCLZnbE0cFZbEDzPcblozLd9j3ul7sOGfyNEh0tr ngWRkb6jmj8m9bxKoxj2PKFVyYD/dZ0KdFsy5HxGjcSukQl2CKB7EK/I X-Gm-Gg: AeBDieu4c3w0NyR4w3BGafBUY8f1aXuF0fdSmt7WnqwZl5k8JJB1rN+B4LASBdWVY+z FRTzE/P9+xTBKD3kHDf6Dyi7yoV9UOoq74CTN7D6WjFoOV3NBXDx8ovKFLr6O0yNbQ4bBgHgMfr 6Pus8njhDagpTXKYzFXpo9qeQBe8nV4auxat6GBeLYAoa9hTbBH9RJBnrk3Wehcw2wlO42oeeLf xGkst0jkSd+H2WOnzC6vdm9mYVtfYfkI64/CLoqpNfZH8t9DVPu3QxXMqMiti9mm8QDrovQuE+p Ucnrpj5rGFw+yAlKarw+YaGgWfi3BrcABEYMPRnAsSv71XUODsh9vSagIc9sxFBwCw5D4hkH17g aqqlM8/k98IHU+KWB0Vz/AK/UytFo5495XMwp833C4gZFZSeiK7tVpMjRUNEkCtebKIJH76kcsK bTdqXCTvrSvZn76feQ1GM/ozl313TqDJK4zMbZC2uow1rhVSoc5O+vy7hV4e87rnFrKB66ZajWU KL2+dEzXDd2Oqw6eBB+Da2DgWM+ X-Received: by 2002:a05:6214:4b08:b0:8ac:a4f9:da76 with SMTP id 6a1803df08f44-8aca4f9de89mr63620936d6.26.1776038789393; Sun, 12 Apr 2026 17:06:29 -0700 (PDT) Received: from TDC4045031631.e0cglfehwr0e5gttmepj3hi3hf.ux.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac8aea242fsm71371026d6.34.2026.04.12.17.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 17:06:28 -0700 (PDT) From: Ashutosh Desai To: kuba@kernel.org Cc: netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nfc: hci: fix OOB heap read on short HCP frames Date: Mon, 13 Apr 2026 00:06:27 +0000 Message-Id: <20260413000627.3273477-1-ashutoshdesai993@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260412134218.34cbe88d@kernel.org> References: <20260412134218.34cbe88d@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 12 Apr 2026 13:42:18 -0700 Jakub Kicinski wrote: > As Eric mentioned elsewhere - he did not suggest any of this, > merely reviewed your submission. Agree, that tag was incorrect on my part. Will remove it in the next version. > How did a broken packet get enqueued in the first place? You are right to point that out. nfc_hci_recv_from_llc() already gates the queue with pskb_may_pull(), so a short skb cannot reach nfc_hci_msg_rx_work() to begin with. The same holds for the nci path. Those two checks are redundant and will be dropped in v3.