From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4375D31618B for ; Mon, 13 Apr 2026 03:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052219; cv=none; b=K/xLvedxEOxOdyHFzUeK17h0AoXMntDYk8+JWleC3PbzHLrARmlpfF7F5BeY+kv8YqoTwdKQGd5vbATZBXAgyjHhvO0NXCawmsuXFytbygd5avjk1BnxyfhcdLy7PkWNMBOesCZFcmVJk4aRHIq8HnrxROW6c6vJI8YcKwkXbSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052219; c=relaxed/simple; bh=sUgTRHI/W3UUd+iU8UhxjC6qCu++A+/ABGXJUyI6gHI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HPnfqn/U/UbO0zmoc1HPwEjR6neBdXXY1VFqLHGwaQdH2p93oTyblm34XAladykxXfYYydeULcBpmW0IJQ/7NP5dMN/mH7PUa8Nwk18oqh4DjblCwt1wu5R2nOEP98HL2kGkjkhH3cHNSLzXeGDGK2UjL2hDk5Iffu7YFIXvTUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzQcat7V; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzQcat7V" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3591cc98871so1853589a91.3 for ; Sun, 12 Apr 2026 20:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776052217; x=1776657017; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wxEeQY9im1AmCCM45HxJN6Bh41heW0/mNFDoxVPaN+c=; b=FzQcat7V1elonExQrhMM2et6FUpjr1PjOUO7JUOU58aWU4OhCORhvKgFGUyUjqBopE yR05auKX+WdZRgo4YR7xdYZBHTf0CMeJXyGACUGJ3COnFH4348tj52lWHtyB1rChXNHn GE8cbgWcCM7zfNpFWmjSzoua8zkmCSXg02fd3rrAo+wipXyisCqtqEODSmslgllVobNJ bLwie3mKiFg7NzQIkTWJ83MIDa1XG8DO2xHuHs7DqH47Vgsag+8XVBT95fgIApoK8UyN RUAnUNkYtg3cJEzIxG43x2JA6XN8t8Wxga2L17MESuBWdCw698pv7R9QbequovqdLd5h PScA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776052217; x=1776657017; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wxEeQY9im1AmCCM45HxJN6Bh41heW0/mNFDoxVPaN+c=; b=SISKNXDCsKeU3dHc+ARArK2Cj7yU19OrbQ+MU1cNZR8PG/OVE1okR9Bs4yfwtsS3kW +TVfxgO1E5VRmXXh2aXwU+c9j17LVW0MT5cpRR8ESniE9kdQWoTryluCplUBQjyr6Z6F 8s5MTWcOjlzcd5JDzs+9zVgZELqTeJ3EN6FTrtWD9pPIZlesJYAmrqQe616LOzhp4Qax Fhsst0SlGnPFZTSPG/RDBmiYAIVjp02Rn5RZwCrnY+ZDDh8v4niM+oZWbt4clvbxVdUR sG7/uC3VJHdozrg3U8P6wBocds1eq94ZbbgZDiTGGxmkR6q4uP3zkjZ5FgTNh0QDSE9G DAqg== X-Forwarded-Encrypted: i=1; AFNElJ//0dxDirld7Etl+P75mCGHrLA9pnNE/dVY/fuZ1C2uksiFN4jKR3Xrh1CI/oGB4bCRGpQBeV2iK3Ul0tQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9A8pXBZpX47LFGCZCq9rqwpuhQEC6L33PwIpHOtMzLe2yJp6P ChYc0ew2qT9lHHwstcxanJmf7AcRG799uQbmquqrJKI4YBabcsFw2O41B9i7a2La X-Gm-Gg: AeBDiesxb0o4ndzRILYMW2tAv2w0UADBas/umoe1H+edJ0lZrlVZW2ozHai85EvJrA4 omGqf2eJZQ/Fmf5LSoXnGvH1y9W+5N4au/BsENyPflfs+MuVYq5H6lzkG521CJL2D5PQ9sMMEpy RAIZkPiqfDqLycdPrv63CVy30hMffifQv7PwJ9Y+zxibl2ICsKurdZTT+d2hFEK0VCUrIAYgiYS MHinO7y8fbebWlAaX+kH6QbzF32oKLJveP2ZKQfdoOg6A3d/TpS+QTWuC1Zkn8CEyljR1ZL6TW3 f3TKxGGnIB7H6FnEJAMhkXrHJA8vvl5f2g0OxfEvETc9JZs+TTfktb7ENEQRZN3N0XQT/L8HKh9 NkM92bME3LY9fFkmptf+hZX/uu2k6jP2+HsD1hGxJq0Y1w+oYUfula1dp3Aa6up1ak7aR5gnLBY z7MLpVjOhW53R/azRHDU8ortg8ZO3XCVRIgCiVWyc+v3ZpWvRLoa8hclzftoj8/8XyADuxUrRk2 A== X-Received: by 2002:a17:90b:4ccf:b0:35e:3aec:718b with SMTP id 98e67ed59e1d1-35e4281c516mr11022514a91.15.1776052217523; Sun, 12 Apr 2026 20:50:17 -0700 (PDT) Received: from localhost.localdomain ([2405:6580:9cc0:8700:96ae:8c3d:9c98:97d9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e4e2dbf47sm7030644a91.0.2026.04.12.20.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 20:50:17 -0700 (PDT) From: Berk Cem Goksel To: zonque@gmail.com, tiwai@suse.com, perex@perex.cz Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, andreyknvl@gmail.com, stable@vger.kernel.org, Berk Cem Goksel Subject: [PATCH v2 0/2] ALSA: caiaq: fix UAF, double-free, and USB refcount bugs Date: Mon, 13 Apr 2026 06:49:39 +0300 Message-Id: <20260413034941.1131465-1-berkcgoksel@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes two bugs in the caiaq USB sound driver, both reachable via a malformed or malicious USB device using raw-gadget + dummy_hcd. Patch 1 adds a missing return after snd_card_free() in setup_card() when snd_card_register() fails. Without it, execution falls through to snd_usb_caiaq_control_init() on a freed card (use-after-free), and the caller then leaves the freed pointer in usb_set_intfdata(), producing a double-free on disconnect. Patch 2 takes a proper reference on the parent USB device in create_card() with usb_get_dev() and drops it with usb_put_dev() in the private_free callback. It also removes a usb_reset_device() call from that callback, which was both racing against an already-freed usb_device and inappropriate in a teardown path. A related stack out-of-bounds read in init_card() was sent separately and has already been applied; this series is the remainder of that investigation. Tested on 7.0.0-rc5 arm64 with KASAN and lockdep enabled. Reproducers require CONFIG_USB_RAW_GADGET and CONFIG_USB_DUMMY_HCD and are available on request. Changes in v2: - Correct "Fixes:" tags on both patches - Remove null check before the usb_put_dev() call in card_free() Berk Cem Goksel (2): ALSA: caiaq: fix use-after-free and double-free in setup_card() ALSA: caiaq: take a reference on the USB device in create_card() sound/usb/caiaq/device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.34.1