From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 030783C3BF1 for ; Mon, 13 Apr 2026 12:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776082980; cv=none; b=OlwopwTrSl9XXpJlAvgmbqT3fKadvbjLixYeRMzKuas2XjH2TxdIMCGbXJuFx1sm5GpBJHo1BQT/Xyw5xcmBbukUPXeFy/YN0a6KM+r80P56C4YAs/Ofbieez8oD469dkmvMYUHLRPXodVyCyKZMMMEnY+p38ocXv1ac50JnM14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776082980; c=relaxed/simple; bh=Q3U9cR71Ou1c/o6O1vQUwLt7SPIPHBKKzdH+VYokhRM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U4VbdWCfssYaYHYlt5ePCH1ejoYPBaedW1et2hqhqmsCs5WErz09TCUn/dhAZqDDALe31bA5foDygYvmhhppyCZrnA1p72V7oP7zr55zHfP0uboMdn/HeBE7Fzs5pUXaisJjAI3/gAurfPdrQtg+g96qFJ20CAaB/ENS+WM3Slk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dMoH/WRt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iQasXWZK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dMoH/WRt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iQasXWZK" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D82R1b605319 for ; Mon, 13 Apr 2026 12:22:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=aR0wfxNzBVS ofwPdxGhUSe58+s1gtFmmIRWzztRcMV0=; b=dMoH/WRt73np3wkJeNeCFojWaq6 VlbKSYxBeWmdVZ+IJyfd0PFUXoFdmZ8/t20GaMAMv0YGZs+ObZ21xk0o/dZG4YNv yM3lkJwP+lSUrlRqz0ndqgggcO4eZX/6ct6fkOsN8ndqt0HqnJ6EbtIUKkXOw7Jv 5sqLBXHsUAPlBUumSaaveF32ijjHb0HGLvBvxjHObSSmqNFwGNPNbBWYl4qvikoD czNTxDrULKFhQpuPbn9rWjOpBIgprBiYxwqPD/Z5qzH4+MX+PouzSIy4GY5p25NT oQmifzYp1Uw1+cke+HK14eRxQlBeLlOZwbmtU0R88uwBaigigJ5TLdj1oGg== Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dfffhw6g8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 12:22:58 +0000 (GMT) Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-7985951fa83so103070327b3.3 for ; Mon, 13 Apr 2026 05:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776082977; x=1776687777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aR0wfxNzBVSofwPdxGhUSe58+s1gtFmmIRWzztRcMV0=; b=iQasXWZK4VFqdGWH3aHE8KvAk04NTf3NLB7hlHxnN56d73+78em/vtgSO1ynrS0Vt9 yUPWnnA6dNGkLHKyx9fX6zdlRnTJCEW3FpQfN8rMlFINR/6LL3i3bcruEOiqRTFh5ecL Zy5m7TMcmGMpN7tuA7d0QqoDsssOzVdSFxM93jIcuCUuqMFSjBar9Hqh9faVfm8fMhFf Daxq/l3Lt1AlXTPNSbzo32E1slq/AYY0X96iLSTL80XPvF1KB3BSSUc9fDrlOA8Qb80h mO4g5Wgjo3TDfNJDPntm4u3cCgCfz6z8kUe3ebv+MVRnXxq/10P9N2WK/beV/mpUqRtE yFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776082977; x=1776687777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aR0wfxNzBVSofwPdxGhUSe58+s1gtFmmIRWzztRcMV0=; b=ofwoDwGvNlQUapo6zOWDK8T7NGGyyKHjTF09GzlDtBe+W9rXW1/B4fRM2ZUI3ir813 pLHEv3bLlkt6Kdf2tQwzTzPEAqqrR5IRq1vrUzUa93O0O3EdEMvV8Bon+ha3i4VZElgQ SMb1t60W+jC7Mti/2sBq242kf4nK7mlop7FJNhXQLJ9cBCFoIIXsZOHDdCaduV1KoaMx k6JTCLWA7Jw3+1pili9q3pIAwMhnjkDxzjK4lJMGNlYY9eobQHx58kcD7bFpzArzSe1g CkgZXuiS03wDDu86JK17tyjA4vlIZtMWAOhQ268yImcORldyMqwpQassQr4b2bYqYXTv FP2g== X-Forwarded-Encrypted: i=1; AFNElJ9CunAP5ziKqZ7y2LYbjySk+M7bA6g+uCOEol2rijmCvWezeWcGblwi0swj9BBeHJVEBYiB/LGT+qSgRRA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq+Sk79DsFOYPzisSscxzfCePR+ym5lf3D0gJsXB8nZa7nF06O zoj+OuflAbrOiqRxpiTeUqkbxZ53OqgP7CoVXNiX6sAcyeoqXiSs9TZMHv8ljXADNw0bnopfwtX B6mKjIBw+K+5lkxn9K746PBTokD76aBzE2p2bKMMQX/OVtTZnRGZcPe5f/7FEkQGlGtFLrtCTjs w= X-Gm-Gg: AeBDieu03Oh7ja2tUazLLOlQWYtF1sHNMsBzRtkQxEeeiz4dwWel/nWUpoJkVzYvgzd MGey4n4Bw2ld/LgX0bhBMygbc3OZI3H3ii0cB1MNczoGnWzSIKiU85Fld7EKI/p2xwXc6jiV1YN L2ns431ovwPBRe7L8BtcepArQYhyLiw1ilb6dOTcBArYQNgovfttJoK76N2d8u7mWFlibmRBQbf oV4mRwle2Nb+a8v++6ykMZMB+P5YYMUFbA0BDmgv5Vdd/6dM+TyI1Z+hVjhp6XXS6YqVx+g/aoS Q9t5Ox/PetbD9CczkB2IvHz2edairlFerGfxXTFLkE7hM0sssmvM6R+0wIIEcvBpW+/Io4ybfXW jUhqTgAQUZoG0exUxlhcY4fl7Y55JF2J6ZdGyKwd1WTw9ybK0yA== X-Received: by 2002:a05:690c:3482:b0:7b3:ca3b:84a4 with SMTP id 00721157ae682-7b3ca3b8fa5mr19090337b3.18.1776082977300; Mon, 13 Apr 2026 05:22:57 -0700 (PDT) X-Received: by 2002:a05:690c:3482:b0:7b3:ca3b:84a4 with SMTP id 00721157ae682-7b3ca3b8fa5mr19090057b3.18.1776082976678; Mon, 13 Apr 2026 05:22:56 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7af400eb1fasm50781657b3.44.2026.04.13.05.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 05:22:56 -0700 (PDT) From: Ajay Kumar Nandam To: Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com Subject: [PATCH v1 3/3] pinctrl: qcom: lpass-lpi: Resume clocks for GPIO access Date: Mon, 13 Apr 2026 17:52:33 +0530 Message-Id: <20260413122233.375945-4-ajay.nandam@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> References: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDEyMiBTYWx0ZWRfX0rVOLfLEsw8p olEINrZMqVgwd84HsxwLvomGNmb2GPqj23CZc/BMezIbWI+XmYjEsNr+aEdJlm+A4XZArLX5+xE K/jSYNCdKnQVXs34FlcDlbj0z378GPz8tRfJJjdJUuNrHl+yK8NMwS67bmBDI0UF9QjCroSmp2e zzkZzMsKwuupcjtrOKe6pLG2kgbv4jt3OHRMC8Wqx9GNYuPkXfOepVxSTj0vgCANWbR4RISNuo/ XMPX4DPprENaHnsYez12Rqqr2WCHC1gp32yvDUT/D37KI3yAfZqrSL/3hmqejT2DgU2uIqb7UhG d5q3WWLKYaWcJjJ7e8m2U7D+x7osi4IMiMLJK8hyNsPcH3L87+0RZE3yBqWHfgfzPUJO1kUIhku vzK2uLYX80pYk+n45lCyaTNt0bX/KKkr9GkLKQa3ovbutLwdd0T8lBa8TkwOgOmtMB+hGlIHnRi m+r5RACjW3acvepFPKQ== X-Proofpoint-ORIG-GUID: Fh5bXQuwULVWQ1QiDOgFexyuXNScEXcG X-Authority-Analysis: v=2.4 cv=FOkrAeos c=1 sm=1 tr=0 ts=69dce022 cx=c_pps a=0mLRTIufkjop4KoA/9S1MA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=f7xhw97bOydz6QRQpsAA:9 a=WgItmB6HBUc_1uVUp3mg:22 X-Proofpoint-GUID: Fh5bXQuwULVWQ1QiDOgFexyuXNScEXcG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_03,2026-04-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 impostorscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130122 Ensure the LPI pinctrl device clocks are runtime resumed before accessing GPIO registers and autosuspended after the access completes. Guard GPIO register read and write helpers with synchronous runtime PM calls so the device is active during MMIO operations. Signed-off-by: Ajay Kumar Nandam --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index d108e7321..4275f2734 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -49,8 +49,17 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, else pin_offset = LPI_TLMM_REG_OFFSET * pin; + ret = pm_runtime_get_sync(state->dev); + if (ret < 0) { + pm_runtime_put_noidle(state->dev); + return ret; + } + *val = ioread32(state->tlmm_base + pin_offset + addr); + pm_runtime_mark_last_busy(state->dev); + pm_runtime_put_autosuspend(state->dev); + return 0; } @@ -65,8 +74,17 @@ static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin, else pin_offset = LPI_TLMM_REG_OFFSET * pin; + ret = pm_runtime_get_sync(state->dev); + if (ret < 0) { + pm_runtime_put_noidle(state->dev); + return ret; + } + iowrite32(val, state->tlmm_base + pin_offset + addr); + pm_runtime_mark_last_busy(state->dev); + pm_runtime_put_autosuspend(state->dev); + return 0; } -- 2.34.1