From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52ABA35CB87 for ; Mon, 13 Apr 2026 12:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776083619; cv=none; b=ZcydUXiwKxjqRrSbpJrqcCJnA7cUgentH2zcmfs+BstliU+atLKXH/SbvjW6e83XClLCH3optD6OF1nS36XXBYwQ4gCkSj/SQCmfzhVz7SVMXYUsvOc9oJvyCMfBPr9J2j6GWLDdEaFBp9CzgMVlxLCmXu901m16vnLWcEukiWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776083619; c=relaxed/simple; bh=xA4n+GiO2krYOwYXl5HG2bO+X2yuhqHCokSQuZD8nPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K7QnqGgTjTfKOWYslB3ipG6PARYmHN9h7UPpqarbZsM9z7v4OOxEwU8g4Lw8LXfB7XYsTtFGDaUCirfwOM5sSNlQdLtlN1GIvoVoa3pOJnNo+AOVjOFTYu/9dYLH/wKUusgoX7SoV99C5vsYdNbIIIKSorDcxjn/7WbNF4iB2+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=AIRpbaTX; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AIRpbaTX" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8d68bcf50fdso485591385a.2 for ; Mon, 13 Apr 2026 05:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1776083617; x=1776688417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G3PbZPnXvhTGMf08wp4zGUyWkrOGmA6vnbkCFh7iCiM=; b=AIRpbaTXbeO4BFej7CJ8T/6fVSZyHoCZ1dtTvixRrlO9ljFUNP8GbpaDzIwC0y0j2L LxJaGqGlq3EWWM7109WuQpDxb/16HCfYvJeM0fPQfOgpEGI1rVctHhju/SYXqS8BKQ4A iX+vzK1vjgBdrQ5rXhXatDFrejorI9wNFXfEA4NH639Df5VwF4Y3FlLNtnoIJokI+u5h UyYBFa555iDsF949TnEvyfDiFBoIL99qmAgFgKUMrMnP2v1kTSpUFQi2xw2OqPKFVbq/ PTQ8OR0kSGByVVWWIhHTcP8uptnRowE1ersTrjb20RiWe7z1Ahe/4Yp8jsmT+er/PFwV xfcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776083617; x=1776688417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G3PbZPnXvhTGMf08wp4zGUyWkrOGmA6vnbkCFh7iCiM=; b=WZOsVb1Xkl6d1dL/NwblOtpwmfElbnSEDJmIV5hncVXUClMmJtwXQ3tCBp6Glvn4oZ KfB/LdhTJXWDvpq8P/p6y/7VW80jf7bMbuzeoVv5kedwUEA/YZ03XKUPMnlJuU+zE70J 3ZRnc/iLZ6UYEwkK7LYlEmydWdtEHATWqUM8zv5+NUcAi6Vq5wSi1YMPmfs8grf5wBCE Om7dSG+K4LJxVmdi4Rj+JaL+TRfxzK2vI7iOpxYm9NlZIP1PUDRNs2vnX/YdqRXp90f/ j3+39QJ6/AYAe55NLBWcjoNiIKVyUEW4cJVLRGDJqlBfGXwqS2mjEItZygZalNmKd+p3 bUtQ== X-Forwarded-Encrypted: i=1; AFNElJ8z4RLTTCKNCMn82uwCRM6tfDM3NH3LqSISmrf4nYgHWQErXhNJ07Rk4E8jQDJK3FoIEix91fXmOVpp7LI=@vger.kernel.org X-Gm-Message-State: AOJu0YzeAR17PMw53SBWutO8xg6rELeBFml5GsWhiY+zlZRtbKNs2VV2 qk2+2CnoLNZ7q5JX/9bLkH3+/Wz/yO2jOWUOt5dx23bLPs3BXnb58CeJC6zwUKhGWBE= X-Gm-Gg: AeBDievKD1yaEiiGQkgvMjrx9J1NS+a5OXIHeK7xXs5Xp9qZbNtV9dyDL35wlwTXQh1 FffmKQLFCtHse2SKBMiqxCjCpBhLdJjUVVrM/72OgEgJ427zsYaFwEht13WZpa8lRoBPz7j+RPf NF+NCbaON1lU+MkrXcSuePtUojHL2GY1R2GwNpamGYVplKnqPhCUBueVhafq38p1EmkROf1Tuc6 WbeyMmiU1pcADjxY+w2lNijFFVjPBw9f/wHznXcPqU1YnsbiBj6HyhxfhMMzrBQmvy2geofqgzV BHim/VV9rMeVGK/2sPNoWwjd2pjrzjyCqpYFx1c45v0Q7JOBuRNNXitchbdVRn9K96oDPoPC5jT 1ICgR70Ti+BbIJwCkTKdHg0W/nRzoKbpw89qBWYM1Gs7YWnDryfc/X97W61dmgGY/a8SySh7Z6s mHINZi4cwRIISb3+P3TEOVaNufA5qLSpdgseh5HGuh/I1dQOIuLDCMzJ6sbRVXuQdGUZOPE9ChG oxbqQ== X-Received: by 2002:a05:620a:3729:b0:8d7:cf69:3bf3 with SMTP id af79cd13be357-8ddcfea032emr2045008085a.54.1776083617086; Mon, 13 Apr 2026 05:33:37 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ddb9637c5esm840380785a.38.2026.04.13.05.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 05:33:36 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wCGTv-00000005Acj-2B2K; Mon, 13 Apr 2026 09:33:35 -0300 Date: Mon, 13 Apr 2026 09:33:35 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: "fangyu.yu@linux.alibaba.com" , "joro@8bytes.org" , "will@kernel.org" , "robin.murphy@arm.com" , "pjw@kernel.org" , "palmer@dabbelt.com" , "aou@eecs.berkeley.edu" , "alex@ghiti.fr" , "tjeznach@rivosinc.com" , "baolu.lu@linux.intel.com" , "vasant.hegde@amd.com" , "guoren@kernel.org" , "iommu@lists.linux.dev" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] iommu/riscv: Advertise Svpbmt support to generic page table Message-ID: <20260413123335.GH3694781@ziepe.ca> References: <20260411022223.91029-1-fangyu.yu@linux.alibaba.com> <20260411022223.91029-2-fangyu.yu@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 13, 2026 at 06:45:07AM +0000, Tian, Kevin wrote: > > From: fangyu.yu@linux.alibaba.com > > Sent: Saturday, April 11, 2026 10:22 AM > > > > diff --git a/include/linux/generic_pt/common.h > > b/include/linux/generic_pt/common.h > > index fc5d0b5edadc..dfadf8a5752a 100644 > > --- a/include/linux/generic_pt/common.h > > +++ b/include/linux/generic_pt/common.h > > @@ -188,6 +188,7 @@ enum { > > * Support the 64k contiguous page size following the Svnapot > > extension. > > */ > > PT_FEAT_RISCV_SVNAPOT_64K = PT_FEAT_FMT_START, > > + PT_FEAT_RISCV_SVPBMT, > > > > nit - every feature has a comment. > > Reviewed-by: Kevin Tian Oh that's right, please add a good comment! Jason