From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83E8F33EB06 for ; Mon, 13 Apr 2026 14:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090010; cv=none; b=lyrWcZKGHPZhppdaxjbWIqbSTaqT++ARom5CxDXgeRYrDreN4SXZu4qiZqwZI+SZzhdtC/hvdaBwm6dM/2CQzzB2W+KnWa00zgvYS2dwrDTvv4KqZwYgUuwsUuempsGx7QHWogLnlMgGAUL3N5r0mZuyc1BF4nopFGmp+cjDO1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090010; c=relaxed/simple; bh=XRV/0uMeiAx6kg5HECYSjiu5T+muz7fWuo838YNt3j4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=be0KwqnQSZVk9bSQtwThX0qmyjZbFYPz1og9IG4EW12MnGkcH45sHHLB+3s5uR0Pt8n8UR2NELCaFPtTp/A4zzLVrJjq+6qoWFczBy2i3wCtJXGL4BTA78xCYnFQZ9MzWIfAoAhardCCMY7d9RAmtKgw7HL/CKxrVoc4Pu3oXsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=olkLop/B; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="olkLop/B" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22900357A; Mon, 13 Apr 2026 07:20:01 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4A81F3F641; Mon, 13 Apr 2026 07:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776090006; bh=XRV/0uMeiAx6kg5HECYSjiu5T+muz7fWuo838YNt3j4=; h=From:To:Cc:Subject:Date:From; b=olkLop/B30XIbPNL0fXXBMs/n0wQy7aao5arFdYAkvUZStvuvHzR8Plnm2mKGDd18 ue0Zf8lzSpv1q4qB12Yhd3dYWe3rX2FRyDhVsZv5NHqx6StCkOQvf45Yrnc4nV+5uL vpZJo4B1jUEERW3gLgvkDcY+DoPRjO++vxsXjlUA= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v4 0/9] fix several inconsistencies with sysfs configuration in etmX Date: Mon, 13 Apr 2026 15:19:53 +0100 Message-Id: <20260413142003.3549310-1-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current ETMx configuration via sysfs can lead to the following inconsistencies: - If a configuration is modified via sysfs while a perf session is active, the running configuration may differ between before a sched-out and after a subsequent sched-in. - If a perf session and sysfs session tries to enable concurrently, configuration from configfs could be corrupted (etm4). - There is chance to corrupt drvdata->config if perf session tries to enabled among handling cscfg_csdev_disable_active_config() in etm4_disable_sysfs() (etm4). To resolve these inconsistencies, the configuration should be separated into: - active_config, which is applied configuration for the current session - config, which stores the settings configured via sysfs. and apply configuration from configfs after taking a mode. This patch based on v7.0 Patch History ============= from v3 to v4: - change etm_drvdata->spinlock type to raw_spin_lock_t - remove redundant call etmX_enable_hw() with starting_cpu() callsback. - fix missing trace id release. - add missing docs. - https://lore.kernel.org/all/20260412175506.412301-1-yeoreum.yun@arm.com/ from v2 to v3: - fix build error for etm3x. - fix checkpatch warning. - https://lore.kernel.org/all/20260410074310.2693385-1-yeoreum.yun@arm.com/ from v1 to v2 - rebased to v7.0-rc7. - introduce etmX_caps structure to save etmX's capabilities. - remove ss_status from etmv4_config. - modify active_config after taking a mode (perf/sysfs). - https://lore.kernel.org/all/20260317181705.2456271-1-yeoreum.yun@arm.com/ Yeoreum Yun (9): coresight: etm4x: introduce struct etm4_caps coresight: etm4x: exclude ss_status from drvdata->config coresight: etm4x: fix leaked trace id coresight: etm4x: fix inconsistencies with sysfs configuration coresight: etm4x: remove redundant call etm4_enable_hw() with hotplug coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t coresight: etm3x: introduce struct etm_caps coresight: etm3x: fix inconsistencies with sysfs configuration coresight: etm3x: remove redundant call etm_enable_hw() with hotplug drivers/hwtracing/coresight/coresight-etm.h | 46 ++- .../coresight/coresight-etm3x-core.c | 100 ++--- .../coresight/coresight-etm3x-sysfs.c | 159 ++++---- .../hwtracing/coresight/coresight-etm4x-cfg.c | 3 +- .../coresight/coresight-etm4x-core.c | 365 ++++++++++-------- .../coresight/coresight-etm4x-sysfs.c | 197 ++++++---- drivers/hwtracing/coresight/coresight-etm4x.h | 182 +++++---- 7 files changed, 575 insertions(+), 477 deletions(-) base-commit: 028ef9c96e96197026887c0f092424679298aae8 -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}