From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2016C34B1AD for ; Mon, 13 Apr 2026 15:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776093247; cv=none; b=FxKRyv5pP3pJX6aCDw9Rblq+EyLLuel/yn2yo9ZZ086E71p1UfrHnBTCi56V3qy1qjAVdw+Ju24sZJnrnk/AmHWUl19t0lCJRZSG2z+tYatVA3QpoU/Fgzvf3ub7XoGrN13mD29QIs8JE1idtFFA32tsaiswSioG2i0ygkl4L1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776093247; c=relaxed/simple; bh=yYSCKjNrdKF6XOjN4pyH1H1y9znVqww72twHt1El/xM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R0qpox8HVk1gg/CYNgoMBMlF8dXlsC+nUdG72MybzZUlh/Wn59t5cp/gauvoqV0tWmmcAKNU92WO1Dj/PpsUzQo3GfQOvl39sTgMJCyY55K7CAbq5a9FA8J3r5V7N5VH3tkb1XbDZrsSjCFr9erDE+84zHr9O/WZCfZbtJNwS9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VkEZiyh9; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VkEZiyh9" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b79f8f7ea43so841405766b.2 for ; Mon, 13 Apr 2026 08:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776093244; x=1776698044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PzbmkEy6yhVTosVDtwDWypWhUuRG6XqhGllWTUJpFmI=; b=VkEZiyh9TzqLqGEiktaBnoaCcnvuAkzt9jluoW4qGShAKPFzr0YrsARvIKjbBmd3GF Pn+QK6MWGlxQzhDWF2LZNBY1BkdTk3j9IDfXrcF/HT7TNfvhAolNOQDdLa/zwX0nxh4Y OR0HASuiBHFiD0fgJyVsox1OfhnFheswqo8HuDzdge1j60RcHkiNsJDoFqsshWD+Mgap +GJWQJAc5rIS6Qch9KWebdfTg3trnXwuAHTtGMtOvfP3zBvpZGZOnx6NHa4yPlRbuKfI cHL5lrxYuWQR/RK2SZVXXwQ8Eizy/Oy8hT0ZWJCoUYJmwr0giEStyJhT6TLoT1mpNJre OToA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776093244; x=1776698044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PzbmkEy6yhVTosVDtwDWypWhUuRG6XqhGllWTUJpFmI=; b=PchZnnILp18Onmr1okHpPtRbkChAo1DZCG2keYS9PodxTmCiO3akmlyd9FGpnb88+U bpZ4pePEayUxifl6U844847jl4tBDfFvthdTt7a5ERVS2eVzaXPN3fEosITSS7q86diq 9gaFe+OZ2kY13QGRBU5nS1DV3gzLR4Kn1O/5/TC/HVURM67651l5Y0n6PGmWdBnUvkoR N6Xs4mGoq1VoWHkdmT8JiKKarQILnYJtDqVWpKtuL4BtDirCpXPsgbsf+qh3kPGpI87B hzpPeY28qXFnFt9zL5Yi77UNrR3M+XhY86WmyEoOFJxMzR7WnmIt3opjnojLe4GagvG6 fyUg== X-Forwarded-Encrypted: i=1; AFNElJ/heILsTAure0hbSnSiaIf6/lsotkNQjpNnJHg3Yqj4yKnX1begXu2+MNOFUEfbKhTL+O4lTEZx/P62fJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwWCXyYrU5xqxTm3tz4WY8njBfYuVhTcgOoMb6IhyiURutTn9ze Jtr9plLGUtBWH4Q5gyZ6ltqLBnfbRCvUAJGCeyP5w3jRxsEwujCV8OuB X-Gm-Gg: AeBDiev/YQV5iBL1h3Cja0LRB7LuB2pjlB+HcsnwQBoQck2kj57h6XeCeVMsVHaONwd iWYZvjxEoZbb9VZB8Ee8nJt6nImlBiaEg9g2FhjDTvha3zU2UYNhDpGY4MEIJ8uU7tJ7n8wT1+R +g8X52wf8aQP+YAIsX3bVTHlggtguQtE4j9FXELvMPTAKUISfNHiqdj2wE7azLJiBbfVeHgzIX3 yiGO/fjTLowqYJQz0VN0nveI5sPY5vHaDi/pv6ecGLVumLwnGCY/s7sNGZzlxoSCxWxuRsVKOpo nHDlsgTjPvDhMXhYeAHpfZFoSteJ1qCZ4O3ONKL0M+aWPws14ATcoQBeD+sldpHlqks5MOY3NJL fptwE36w97VBjXZxsZqnkxK7CoB7wbqCBo0tTysW4GKoEVakvu9Y9g16uHNN2Fdbl8StIpzd2jf fbQZ+HujwHn7THbOXwO70IVGLWAmam+U3Z2TIzK/xwjZIwsRwklG8SlZnKlmOP3Rux4L2SOv83X As6QMj7WOgSvXdWJUNwyxv4qdJuvMz2voD83DQH/zbKNzuPCf9UDVqLET4Z7r9tW3omiQwpqPfr DsVa9A== X-Received: by 2002:a17:907:3e84:b0:b9b:6581:d8ea with SMTP id a640c23a62f3a-b9d7267a8abmr761820166b.4.1776093243852; Mon, 13 Apr 2026 08:14:03 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c56dfsm331085766b.37.2026.04.13.08.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 08:14:03 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Alexandru Hossu Subject: [PATCH v2 2/2] staging: nvec: fix unconditional pm_power_off teardown Date: Mon, 13 Apr 2026 17:12:36 +0200 Message-ID: <20260413151236.612404-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413151229.612301-1-hossu.alexandru@gmail.com> References: <20260413151229.612301-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if nvec was not the one that registered it. This breaks any other driver that may have set pm_power_off to its own handler. Replace the unconditional assignment with a guarded check so that pm_power_off is only cleared if nvec was the one that set it. Also remove the stale FIXME comment, as the guard addresses exactly what it was asking for. Fixes: 3f8d52ba1c49 ("staging: nvec: Remove nvec_power module") Signed-off-by: Alexandru Hossu --- v2: - Drop nvec_power_handle = NULL; after pm_power_off = NULL is set, nvec_power_off() is unreachable via pm_power_off, so there is no dangling-pointer risk there (Dan Carpenter) drivers/staging/nvec/nvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 2a3499dd4d63..88c416ee0381 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -906,8 +906,8 @@ static void tegra_nvec_remove(struct platform_device *pdev) nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier); cancel_work_sync(&nvec->rx_work); cancel_work_sync(&nvec->tx_work); - /* FIXME: needs check whether nvec is responsible for power off */ - pm_power_off = NULL; + if (pm_power_off == nvec_power_off) + pm_power_off = NULL; } #ifdef CONFIG_PM_SLEEP -- 2.53.0