From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F49E3BF688 for ; Mon, 13 Apr 2026 18:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776103917; cv=none; b=g0USWUyItXS17WBCf15220roDcyyVh3LwSOdJreNJyComFvHoE58mBl3v/NMcmIJf9tnDh4yDKV1nY6Pm4AsBgCSv8VGiRtQcIC6FrA8wByBn426ofKxmSB6tkCy8DxTm3WUgb4WgwhekKVU/IouetUh8K8TLBYYc88k48WATtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776103917; c=relaxed/simple; bh=yKIOVeDMoyyKuNuuEbW4QRZPZ3f89Hrgi0Xf45glbnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HGCVqDKNMHa0WnCLy8Aqvv2S5cTBF8yjrpHYwEzmGg4oYFvQ42crNX8wUJVqVejlcH34zZFjmRjHIsklpqqxMlmiMod0ueydoXwxuoXPXsSytGZ4xN3LMXNe1l8dThR7pjZLTphYLqlc3f010DwvB2uKMjqA4iCS6FknhdZ8a9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Je0403aY; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Je0403aY" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-126ea4e9697so41196c88.1 for ; Mon, 13 Apr 2026 11:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776103915; x=1776708715; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yKIOVeDMoyyKuNuuEbW4QRZPZ3f89Hrgi0Xf45glbnE=; b=Je0403aYBMniQoJfV8ihvBOTd8oPQ4vtGndWU5oc4xI2rIwxfefAL7gPKSjLaXYDcW gbXnMgIS6cTq0cTAhTEVgFuNeY5qfBbi8MD3zymPIg2KVDWpi+jPXg8wMICDH+csrQXr P/7V5+y2bLyAI9XOoV3/8irRYi7VDCDZUj/QhPaMvhqd6MjasE87qPvAqdDv+Z7Seexh y9pbFiNzHPfwroM9Y2pAJ5jf41q+l3D2tLPGQ9XacCYkvcUicSD3jXjakdxuDVHyaHsq Quw0gcAVzjEz7yd5K9FYzJn5J5rdN0r/oMlsgb+swRJUiTzgA1+E2bxAe/Tvj+hWDIL0 hAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776103915; x=1776708715; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yKIOVeDMoyyKuNuuEbW4QRZPZ3f89Hrgi0Xf45glbnE=; b=eHPxwc17A0cK+8AXq357mDRxaEzigZZ38fn1kGJWomuJEvsOX5dpb9dndj8r5HLnyJ rsmREEMZh8WneasEekAXyvq0hyzzSOztkWwRCUPTiF8bmGmuSQjU2qPyCAqUmsJWWtFe z+BCmTRxixCxQeS0KEZAQwhlZojHZru3rl/wjDdge9rpCZhOxR7CYwW4YDnK/oT/hf3i CP7wPIf/KIYXz2evKda2kNoGpNhUF9ktJSO2sMzrM//CZqouauNHS7fCYTK037V0L6vd gEscZcQdOAEKIeUS7LLk8OrKUUeUNcazjhK+1be6YL0LUpdl+9o3zS4VxEhXJogjtTC8 KRgA== X-Forwarded-Encrypted: i=1; AFNElJ9GDKG6Jn5jzTQXh+QNCSiQo0VoVnEwzNkV2f55a25p3vTpyxBmGZVrHGOJ8Dg8S8fTWvdHIofjAur5Vsw=@vger.kernel.org X-Gm-Message-State: AOJu0YxhewR59I9T3dphb3wh9gE2u3roofaN3nOlFkBtZf3a1xTYcAiD iK3qCIuiDKy2ryedwqp4xveq2CLz+NbDtKUFRVL8jDmoKm6SciU+Nuv7Zmnb5mFmww== X-Gm-Gg: AeBDietBFK34J8WbogQ4zXKp5XbAEtB0CgTv6A3brbI6L+q6jyL9hAZFwuF/qfoilXV WFNQpI7ZDHApJnLJPXxPivn9qE7PJde7qfNVx9BbZaJC7WEW1XQ52ZspoXkFjt11/qlgsdSEsrN fknXe1FvUHOjeIPBypZ1leQtp6JB9VNcSHnEMVwLYdJMAprbljjUw7xJQkFFg/plH5blpqyjYmt ncSZFx4dqBru6w7Sf/GK10CMn9QLnnmmtA6UyidQECKR9M3fgK8KqregkvkJmk2vp2RzPxlCmFu nm6kczYsKlSocXeoRPU81iDgNUt1prvVCtA1OXu/2ly30RegI3iTbFoR8ESnQ/+T5cnqMwMJbnO k2nMTe4Yt3XfVLpWzG5qCL4uIrozcNwhz5lsGGo446WUz0aTwMb23fomWpS1wPFfBz6olxBmA/z q8+O98WHYhjKS28+voKPVnZ2+U3FVcufBLx6qAm/IOFSD04E4dKkZGymZ5m+MIca21ehd60S7+O hwRjYk8 X-Received: by 2002:a05:701b:271b:b0:12c:32a7:1569 with SMTP id a92af1059eb24-12c32a7166fmr183088c88.0.1776103914619; Mon, 13 Apr 2026 11:11:54 -0700 (PDT) Received: from google.com (60.89.247.35.bc.googleusercontent.com. [35.247.89.60]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c347fa2c9sm14849143c88.15.2026.04.13.11.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 11:11:54 -0700 (PDT) Date: Mon, 13 Apr 2026 11:11:50 -0700 From: Vipin Sharma To: Raghavendra Rao Ananta Cc: David Matlack , Alex Williamson , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 8/8] vfio: selftests: Add tests to validate SR-IOV UAPI Message-ID: <20260413180900.GB3034974.vipinsh@google.com> References: <20260402173059.1018805-1-rananta@google.com> <20260402173059.1018805-9-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 07, 2026 at 01:51:00PM -0700, Raghavendra Rao Ananta wrote: > On Mon, Apr 6, 2026 at 3:24 PM David Matlack wrote: > > > > On 2026-04-02 05:30 PM, Raghavendra Rao Ananta wrote: > > > > > +/* clang-format off */ > > > +FIXTURE(vfio_pci_sriov_uapi_test) {}; > > > +/* clang-format on */ > > > + > > > +FIXTURE_SETUP(vfio_pci_sriov_uapi_test) > > > +{ > > > +} > > > + > > > +FIXTURE_TEARDOWN(vfio_pci_sriov_uapi_test) > > > +{ > > > +} > > > > Please do iommu_init() iommu_cleanup() here to reduce code duplication > > and as an added bonus you can drop the clang-format comments above. > > > I think even Vipin suggested this. Last time I tried this, IIRC got a > build error that 'variant' was inaccessible. But I guess I just had to > re-org my code to make it work. > I'll do this in v8. Build error is because FIXTURE_VARIANT is coming after FIXTURE_SETUP, if you move it before it should work.