From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B69E1C5F13 for ; Tue, 14 Apr 2026 13:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776172448; cv=none; b=sgrl3w4fE8tKnlzI6yHR0e1KdfupIWsJhPPzyPVmURE3QcNecUASNbmh/t4HQ8ssH/wv4fxkHFg3RAjyTt3I/Og8UoGL9ugAvADYwhc0as43fAYi4Q3dFfats3wd6UaVLDDnKC5Q/vqecBkBRBCe8vtI6+ZuvU4bJzEM+kGx0LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776172448; c=relaxed/simple; bh=NYEHalXB2jDAOMKQYaWv9VzsDsdm8AajciQKa3U53EI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sp71aeIDl7LcKTWnDS5s5OufHOcqMeZwKgF091DrJcuQQnJicXk1bvmK0wp2GFA0jhMy57tW5pwCiyI7rqeVRK8sOxLkxWdYJr+t5NdTWmhsu830ygt3lsfPyhZI1iulrK6T5PQsJ1z0PWsjgvzg0Eo6ry9kpRaxDRhU10Bvhvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IRwKTNHp; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IRwKTNHp" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82f1dcd5886so2068046b3a.2 for ; Tue, 14 Apr 2026 06:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776172446; x=1776777246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p2yQNWWDsx/mIlUloKDUpE0HbqZx6yFU3riRkk2FowU=; b=IRwKTNHpBMlrbJvQxo0P8FWAu8JteM69AKLSqWlxtmQZBVlwi2gbbon0D4gRDlt1Fk OEqEvdYaasZB1ZV9xWIhEF5bH2rUWOpom4ocCLSDmnGRo2Kh5hgVKHklQcoN03O0PGSw wMc96B0h9FIhVhQedNR3rbGTDlNNGQgzOVLwcp83Dxp5ZCCGNMJTzQ/rcoaVljI0pv/2 EP0IK8+NstNAjDGOA1xwSts+uvL9TxtlIDpYWGnYwkmhw2Ppv2SjIo6ElprTzXwXrVp9 MJ7XmStjQvGduIS2oa8jsfsWnYPwhqN+eDzBLlvO27JwMgRNrBcvDoHrnt2qK+RobACn 3Hag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776172446; x=1776777246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p2yQNWWDsx/mIlUloKDUpE0HbqZx6yFU3riRkk2FowU=; b=i3VDgH+wnKfgVAdNQiaWvxyfKhWzY2QJPuHhUR2iltxpk/gopgJYG5shaRfKVlAisA iSctEDPnlmmKc1Yp1VV6G5zTCY0LcpiH/cOJjARlHEIvP/8yb74vK4impWFDCjYSMKQE 6KLvOeHj5v0Ljeq4JaV9IaC4+hA2eYX0b3h1IkheeFyaJmZ8bPEfYThTczglLiI9DjVC jHNI1rmM6/5Ca+2afB0A5Sam2KDjGnT36eqEDgwKRpSvnhejw206d7h0tv1m4gaXyfrB 5lDtLmfHpHEeNaWojiuSFClZsFajynG6SRAW1de4c462qrC+SRBPIgrwdN/q/I/lLoAO ZX/w== X-Forwarded-Encrypted: i=1; AFNElJ+8SHqI201y4NGB4iMDQ7cvdMERFN9d3lC62pIJxTLr1OxZ1R8/6CXUGseyNqUGDCjNBX9DkJJ8QGfH9Rk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkXE5HzjcKFgf+DFV5o2t0CvomsaWkkCAKOROdRs9pQDSfT+Q9 wytchBs0IdM2+CThHfanEnMpcsOe38C7V1cMAEqPntek4eCaG4wND06P X-Gm-Gg: AeBDievLhixEHzg4qteN9HkJi92+QXhf+NIsycE+L/H9iV+qMUESg1G1ISKgoav0sXK q/DbgvSsS3wAcliFFNRkORqKxFaXO/7FqT3ra9qHB5++0IC6bEO/WgnWKNxGhO9Wr0nDb9X9dj7 uU6hZtkGYxmG14wkPxol3werfpatvyGnxnV5X7Lxvkf+whOLKMLpgc0gE4d62iFxiC4mDj8Ruh2 lNNQUg1RGAfMabs2XjkgFSJ7YZiQq2wnPZHwxGcinHKZEZndT+FckzbTRPwmpQrYC8g95zeBgmb 5PFux09RCjVuAVKVcWeOo85Z7MUX7vFJNqf7A5lP82vZam/5134ywNVE/DFPpOLlpOzcIMl+WNk 7MAcOCL/BeUXgQJHu6RRMnA7sKxMLs+Z76vLqNHohDDJMUReXOL07uDrxysl7ROD8XQ45jZjGZU 32MiUwzUHSokNBz2AOtNDEBJh1lLDOJ1qAhKFNhKqqxXR+6dZimXEn/Js= X-Received: by 2002:a05:6a00:400e:b0:82c:9f7f:3495 with SMTP id d2e1a72fcca58-82f0c351b36mr17153382b3a.45.1776172442703; Tue, 14 Apr 2026 06:14:02 -0700 (PDT) Received: from tech-Alienware-m15-R6.. ([122.171.18.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c4b5a79sm15269008b3a.30.2026.04.14.06.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 06:14:02 -0700 (PDT) From: Sunny Patel To: david@kernel.org Cc: akpm@linux-foundation.org, apopple@nvidia.com, balbirs@nvidia.com, byungchul@sk.com, gourry@gourry.net, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, matthew.brost@intel.com, nueralspacetech@gmail.com, rakie.kim@sk.com, stable@vger.kernel.org, ying.huang@linux.alibaba.com, ziy@nvidia.com Subject: Re: [PATCH] mm/migrate_device: fix double unlock Date: Tue, 14 Apr 2026 18:43:53 +0530 Message-ID: <20260414131353.8543-1-nueralspacetech@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2c0c00aa-7fb2-4d7b-90b3-0309c13468ce@kernel.org> References: <2c0c00aa-7fb2-4d7b-90b3-0309c13468ce@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On 4/14/26 20:03, David Hildenbrand (Arm) wrote: > As raised by Matthew, the entire code block is dead code: > https://lore.kernel.org/linux-mm/20260212014611.416695-1-dave@stgolabs.net/ > And I even Ack'ed it /facepalm > So we should take that (cleanup) patch instead. Thanks! +1 Thanks for the pointer. I will drop my cleanup patch and defer to above patch at the above link instead since it already addresses the same dead code block and has your Ack. Thanks, Sunny Patel