From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 037023E7163 for ; Tue, 14 Apr 2026 13:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173294; cv=none; b=FYvFntj1BpuxBmQgYXSit//hJStx3HA97CZT+AmAamugcPdSx2F4v+8oUVORm/dl+09MvPtkdiH4BcrypuoyBUHFvR/1TVvd6ktEYfH4QUq3Yx3CcgRooloAW021wou7R/1J3B41ZNzPZJtK2fSukKZLJrofwxlt1oLAOT3Gezc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173294; c=relaxed/simple; bh=CkqqWnZ/7qBTK8c2/xuX0ONIv9/5APXXd5FmS3QEyTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hyResfPaob867XtLT67g2j8gibPtKqfG7ErbGsCD2JyXb2b7fy7ve40ewqIiByTSj7pPh6Ookf1fKQNr1ih+C66kzQDTtbUxqUsQt+VIRhQjsp7tszyUgJ3oh0HQ5raBOEo1DttYH115jQRtfRDdhEeTO/AkOwbc2RpoDmJztbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=K8KsHAJT; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="K8KsHAJT" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E06D4E8A; Tue, 14 Apr 2026 06:28:06 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 06ACE3F7B4; Tue, 14 Apr 2026 06:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776173292; bh=CkqqWnZ/7qBTK8c2/xuX0ONIv9/5APXXd5FmS3QEyTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K8KsHAJTPYanSmJzKqZ/1Oal0hodVVErmc3wOoOpVt1JB3MVFmmh/9b8cGuFk2OpG OgH7wJ6ja8HS6Nuaq4nPGVp8cwZRVFVx1VmzPVhhobt/unM0ofS9u19XAGoXZrr0k8 flP2Y8RvyQjjztoiUWcuj+sf6pzoowpa8wf07KHU= From: Ben Horgan To: ben.horgan@arm.com Cc: Dan Carpenter , Dan Carpenter , James Morse , Reinette Chatre , Fenghua Yu , lkml , linux-arm-kernel Subject: [PATCH v1 1/2] arm_mpam: resctrl: Fix broken error path in mpam_resctrl_alloc_domain() Date: Tue, 14 Apr 2026 14:27:56 +0100 Message-ID: <20260414132758.196874-2-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414132758.196874-1-ben.horgan@arm.com> References: <20260414132758.196874-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Dan Carpenter reports that, in mpam_resctrl_alloc_domain(), any_mon_comp is used in an 'if' condition when it may be uninitialized. Initialize it to NULL so that the check behaves correctly when no monitor components are found. Reported-by: Dan Carpenter Fixes: 264c285999fc ("arm_mpam: resctrl: Add monitor initialisation and domain boilerplate") Signed-off-by: Ben Horgan --- drivers/resctrl/mpam_resctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c index a9938006d0e6..d80df486a313 100644 --- a/drivers/resctrl/mpam_resctrl.c +++ b/drivers/resctrl/mpam_resctrl.c @@ -1399,7 +1399,7 @@ mpam_resctrl_alloc_domain(unsigned int cpu, struct mpam_resctrl_res *res) } if (r->mon_capable) { - struct mpam_component *any_mon_comp; + struct mpam_component *any_mon_comp = NULL; struct mpam_resctrl_mon *mon; enum resctrl_event_id eventid; -- 2.43.0