From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57A503E6DDB for ; Tue, 14 Apr 2026 13:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173296; cv=none; b=j3kO2EcxZuduIlxxLP5juylrTx/YJSghRvi7YfQUY2P9TzVBWo6O50unFfH3Ul4ePp1uUH+1tS6pXXnhzI20/IO4PBBjMZol4bKNXafxr2IdfXYFUoPJ8p1jWL3x9kNCoVEWhLfFJcMuUBCNXAp7pH0nhgJgNvtsTSRRWSZdIAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173296; c=relaxed/simple; bh=CkqqWnZ/7qBTK8c2/xuX0ONIv9/5APXXd5FmS3QEyTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LUPABUXg6lqmKz4CV8YUG7EsolPZfonY9t902C6jiAq+wjOaVQqF/yx7xaN9m2Yz0mg9jqLU0HEiELxxcjFEfup80+654t9288wTloM9oCUgK6kCh5v5/kdX7JBvy73ExiVz28u0ubIFqauOzhjf73/lWQW1BECo1qxCeRO/T2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=gh0Q5iyU; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="gh0Q5iyU" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3AF7E4F12; Tue, 14 Apr 2026 06:28:08 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 96E2A3F7B4; Tue, 14 Apr 2026 06:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776173293; bh=CkqqWnZ/7qBTK8c2/xuX0ONIv9/5APXXd5FmS3QEyTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gh0Q5iyUwM05Jy4hH31LJJaSluJUTCH0Hf3MzNdJK53QArlJi8uUzPXr33rJyyscp FQ9NweD8G5QtKvFUWOfPi/RpqpwqKv80g/pMNUuc4/i8Nic1BN3CIbroFzPtLpinG8 SWUgP66tAhLk6UzXIzQNu39ylaxDmSuCgGPqbJKM= From: Ben Horgan To: ben.horgan@arm.com Cc: Dan Carpenter , Dan Carpenter , James Morse , Reinette Chatre , Fenghua Yu , lkml , linux-arm-kernel Subject: [PATCH v1 1/2] arm_mpam: resctrl: Fix the check for no monitor components found Date: Tue, 14 Apr 2026 14:27:57 +0100 Message-ID: <20260414132758.196874-3-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414132758.196874-1-ben.horgan@arm.com> References: <20260414132758.196874-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Dan Carpenter reports that, in mpam_resctrl_alloc_domain(), any_mon_comp is used in an 'if' condition when it may be uninitialized. Initialize it to NULL so that the check behaves correctly when no monitor components are found. Reported-by: Dan Carpenter Fixes: 264c285999fc ("arm_mpam: resctrl: Add monitor initialisation and domain boilerplate") Signed-off-by: Ben Horgan --- drivers/resctrl/mpam_resctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c index a9938006d0e6..d80df486a313 100644 --- a/drivers/resctrl/mpam_resctrl.c +++ b/drivers/resctrl/mpam_resctrl.c @@ -1399,7 +1399,7 @@ mpam_resctrl_alloc_domain(unsigned int cpu, struct mpam_resctrl_res *res) } if (r->mon_capable) { - struct mpam_component *any_mon_comp; + struct mpam_component *any_mon_comp = NULL; struct mpam_resctrl_mon *mon; enum resctrl_event_id eventid; -- 2.43.0