From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009953E928A for ; Tue, 14 Apr 2026 15:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178808; cv=none; b=cx1EQ14TDh9HftxEhu7rY6r8M+uUSiBPd7tj8/rVE+vzKV+wzyMCpPE6FkdMyZGxWspo2mn011xnvcGVC1aMqqX15wDiLvW9QBJZsj9A7QQwMFa7iTpAkxGBnhojPDPAfVSsQFygZtaqZt2Q66T0QH8EqHJzRWiS+ew77hSgkrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178808; c=relaxed/simple; bh=MHeRXp7jWudyKWW5LDG/8x9GyvugF0IbBMSQO7eKVm8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UPEbvLxNvQBp962sMbtVoxkcirRI8/m1EMPdWJ5HIDpba05++fY2kKjBjLHqEbcF3DD3u7xfUqprX5m7J5IBjheavDUiPzFhY1TFnXshPnqg4ae4pSnVb6lSuse5EL/i1c9F4LdqXdm7wf3fF0lDqRyviA0b/JN+YUKrmIQe6MI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=leNYsSUY; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="leNYsSUY" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7d86eb7c854so2823117a34.3 for ; Tue, 14 Apr 2026 08:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776178806; x=1776783606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4HhNjSBI2VaOj0qFbdmW6uKns8Ks8XYfh0+PT8mKMJY=; b=leNYsSUYtU573OFGCWKt04bmvenwZ6cITupzuVlO/TCG7KEOjQG4HPFLMeWgC1Sm88 WRVtpi+E0HoTuxY5yj51vLUKPG18HUB4DKi9ARNNiuVUCGAqt81nxaK4sEhiAMGDZ+VY xdETbdaDbxm/5K3T7+qnVXCQON9A8MQ7GsDHuEuis8gSLRurhmi1hlQDP2mAixHog0ta flK2x6ZP0sumaUTeF1cf4VNEBdCBSsNdX6jwSvkjbAl15uHHHoViK7JSj7Wg3xoLa4DU 0S4Nex5JOUdiHKqoWte3p+uP7Vmt17DsjUJWfagoxlBFp5sHUShTZEXAZQZMR8jiTiaK ljuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776178806; x=1776783606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4HhNjSBI2VaOj0qFbdmW6uKns8Ks8XYfh0+PT8mKMJY=; b=aAXMzlX/Ur7RIuZ16IPVZvAEHK9AjHVT8pi+jrvoRx9yz6ikelmikNnEV6FftW/W+t ZiVJLDI+TyJuPd3FNVnVPKPaGEZGcQuhbrUUdLpK1nuXHorKMnAEV2CVzYhbKcMEQI6K oPVJ5XcUM6Um4YLUgR33hLvJAORZYPTPaVC8MSsNCN/efTAEQW+OjYrdhrxb9GO0wxeK 7QtgAMuF4xCBHXJA/bkE4gfj9o+61YeNSwrAJfKQIAkpRoMj6jbmOdB4rr+RVbRLz0CP /YJ5HUzagN3wb7euY7h+msM8pjiqu7wNYqdtrNVvG+Q83l0uZPr76yybe5Dvgux+l23U NMDg== X-Forwarded-Encrypted: i=1; AFNElJ83fzVSD2fXhJI+U1+afQq6nFQIEcoY+NRZT7xFLTl9evHFBXOWP4KigfU3khfgP2LaHGadmSLtqkuipTw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3sv2UGr3pvtTUD4e2qh8mfF2OxsRowSSQB/ekloOPUzBE8aTa 1x4kx0Y5d+cktL5vQd4EcQdTxtQDdMbb0BkBHNImS/IGq7TtOjRFF0gp X-Gm-Gg: AeBDietjfIuQ36FudSbfpG+KvOMaASMyJSOf8LkGRMYUBi3K/TbnXFlPrJsFo4cQMA2 ycgthEgfvoGI7lnqsbENRfUrlW3WWJjPrGkjdK5BW5BQpMK/qE5VH1KhO0epY9Bd8C7HEzV617I hyGG1iq2+wokvQzVpQ4yjOZ5O+OozLXIqvJ6mBXYytGOi8T+ER3i8eYzjXO0w+B+W015fdR85Yx OtHt9BvJlT7migoFi3OzecBMsru3nd/KPR2q8kOaVgNpZ6V1LqTX12WXwUAV521gIJjZqeSHmz9 OCJO3tuZUt0D+Gilo5fEc3rKiveI8bPep85+ERBBSrkVTcapXS/ACygztQqx34oYp1/e0ntWoF3 7+/N5R1tZCWdNmonB6CyeEn5EYuvCEICzHPnqT0k7jQHmukBUXB1KwVSrLg87KKDFlsP6J3CYky vcqCQ23Bn+btEnYzpsilqdeQ== X-Received: by 2002:a05:6830:488e:b0:7d7:51af:4aa1 with SMTP id 46e09a7af769-7dc27db3792mr10373819a34.18.1776178805691; Tue, 14 Apr 2026 08:00:05 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:54::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc265c2babsm10705351a34.7.2026.04.14.08.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 08:00:04 -0700 (PDT) From: Joshua Hahn To: Ye Liu Cc: Andrew Morton , David Hildenbrand , "Matthew Wilcox (Oracle)" , Ye Liu , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/4] mm/vmstat: remove unused __node_stat_* wrappers Date: Tue, 14 Apr 2026 07:59:58 -0700 Message-ID: <20260414150001.3262806-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260414091527.2970844-4-ye.liu@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 14 Apr 2026 17:15:20 +0800 Ye Liu wrote: > From: Ye Liu > > Replace the single call to __node_stat_mod_folio() > with node_stat_mod_folio(), and remove the dead inline __node_stat_* > wrapper definitions from include/linux/vmstat.h. > > Signed-off-by: Ye Liu > --- > include/linux/vmstat.h | 18 ------------------ > mm/page-writeback.c | 2 +- > 2 files changed, 1 insertion(+), 19 deletions(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 3c9c266cf782..54da7d820f78 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -440,24 +440,6 @@ static inline void zone_stat_sub_folio(struct folio *folio, > mod_zone_page_state(folio_zone(folio), item, -folio_nr_pages(folio)); > } > > -static inline void __node_stat_mod_folio(struct folio *folio, > - enum node_stat_item item, long nr) > -{ > - __mod_node_page_state(folio_pgdat(folio), item, nr); > -} > - > -static inline void __node_stat_add_folio(struct folio *folio, > - enum node_stat_item item) > -{ > - __mod_node_page_state(folio_pgdat(folio), item, folio_nr_pages(folio)); > -} > - > -static inline void __node_stat_sub_folio(struct folio *folio, > - enum node_stat_item item) > -{ > - __mod_node_page_state(folio_pgdat(folio), item, -folio_nr_pages(folio)); > -} > - > static inline void node_stat_mod_folio(struct folio *folio, > enum node_stat_item item, long nr) > { > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 6f9b7b081ab7..ed3301753e89 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2627,7 +2627,7 @@ static void folio_account_dirtied(struct folio *folio, > > lruvec_stat_mod_folio(folio, NR_FILE_DIRTY, nr); > __zone_stat_mod_folio(folio, NR_ZONE_WRITE_PENDING, nr); > - __node_stat_mod_folio(folio, NR_DIRTIED, nr); > + node_stat_mod_folio(folio, NR_DIRTIED, nr); Hi Ye, thank you for the patch, In addition to what Matthew has pointed out, I also wanted to note that this substitution isn't trivial; there are differences between the __ prefixed version of node_stat_mod_folio and the one without. Even though the correctness of the two versions might be the same, I think that a change like this should be supplemented by a description of what side effects this change has (i.e. introducing additional overhead from the cmpxchg loop). Thank you, I hope you have a great day! Joshua