From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BA931716A for ; Tue, 14 Apr 2026 17:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776189324; cv=none; b=Fy6Cl888kaxwIom4EhjyLauyKGDm0RV7Lnbzaie6AobDFuarrqk9Y8/UBNiyYs7RvrhSltREPkYmODFjbVtIDUoIfJ1pzXzXTemBYT7bcfZUK0W1vQHSj209J5RVIkbJVmG4NSNQ4XTtvEbkGAT3NTmeIFeS/aF2ZxNF4xPrNrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776189324; c=relaxed/simple; bh=XNxC/j7wptgQgcyC7rkymCzPC7ye04Nqy6IooUn6YxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=InEs3GbTLlELMG7b9mZlyWGotlmdahO6uaOVIVAWPFeRgKpXmCFpfb0JI4VeWF1OzVwwZCq7c7agViAdQC5XKoaShIEi0lZewHBfw+H8LiuuttrJzemesTWzlj/FUp2j7VctkAK1B7coTp/UZ09/peuYeYGOtLAC+LlMGUbwSCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOJIrm1I; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOJIrm1I" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43d7645adbdso1555937f8f.1 for ; Tue, 14 Apr 2026 10:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776189321; x=1776794121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4R0CQZ/qrW+yRPLga1sILnx+THT1hscnrJSpkR4Elps=; b=fOJIrm1I20fAzcpiaFbutuMLu7QK32Y4dbMrxxVK1Y1kJXMFQce14pXR9jE5LPjdnT iik2oOACVZl15ctt/4eV/3/jOPa5Ky1RUcOz+UkE/yAIYcKQmk6jV1l9wcjRz7nZpzNE Bfxgm2ZoWJYMZZQ0iXbmj/qeFRzP1BmsGMAO587yys3LyT28HiRg61YSNq7zFhr9TkG2 T/zour/lt2eECNiGjK0rTaLWwXYsPd1vIz0omGCPxohvp1pTlMYjZZtcCroiHchsMnD4 lDDF9Gk+mh/Tv66ikUgblPwofvveJzfQpHNGMCyOQqw0hiKDb9iDLkVnxfKYY+JDHVYl 7oXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776189321; x=1776794121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4R0CQZ/qrW+yRPLga1sILnx+THT1hscnrJSpkR4Elps=; b=j7G08h2WtEDVEE828uhPbUWi1xvZtXuOVT4EFMO+avVIG6ec4LsfaqxRx6QZHi97kt VgXS6Uhc48DS7nF45JoYRRG/Zisqle9TRDkHNow9u28YMSI+V39yXvA2fs6vuqlTujU7 ywc1XnsaSRri15NEeXKANDDRiOzwBfq2U+Pgj5eOFc2t2a6aoir9HaVREZcOJFQx3T8D o7GuIawwzMLlwh6YypGjB0zocr+Cdg4a7DogVDgVYkW7Ur1Yn3OHPGz5ffSPcVyaZbVS yntYjhXzuBjtyDh0i5Thp3vOcyJjn+guMhj6rIunTjoxNNe9pEsnPBbuKKm/T3JOESHX SvDQ== X-Forwarded-Encrypted: i=1; AFNElJ9gAhvIhpHLja92AlD8SbW5CDYkZLBaBK5M6YE73BeWLQ5fLr6PbS6l1SwlKV9dBQddcSBI24zZ1I3cGXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzCbnxIIbtnAuWrxBdTcrNhBvFHToBDyuZKJa2f4RXRHi6EeOp6 N81zxhZtGqP11JoCha8Kf//GrR5jj+KsIpigc80CbpVscu90HSbY0t9X X-Gm-Gg: AeBDietVtnGnJEUjt3/Ng15mFO0Lg2F9CaxmuUTrv97iVTn/RUIJ/399trN4N8CN62U ufY0DX3jWzHjfEBfHr3xp5c+9lUXbRfcXrPB8PvmLEH9oS41xBWAKrmRA9Afh+VV7pX6GmZ7GMs tqYnH3T8yjTXgnioWT7LW6itUPDB7hkjd0dXRPBzRaUe3vLF15W/tUMxiqqNFl2z4II/N+UgHXI c3pcbwiK1KWFrqalI+QhCJZjOGmVFZ2oNM7BvnjICqczenwPmqA+So5q16F4TSBmetyNgkQU2WZ oGC0y2vZMlCGrCPxj3dY6RF0klLlvC0BFGUjNWO83iV/ksrJ4fEnWl/+TJ/Kn9fVyv9Qzd02Gvq jUl1Mf61nsy2z7qI1wQ/g897TfofsQXS9TmzZsPWkkdGhYLVKWtNvUdGrq5HsHuDPi8sNtAf5/7 BpshOjk/w4ODKIXabIiq6UBKzAm6yac2sOynH6PqZ8oHfb5LBi7mPjaZzwj5sk X-Received: by 2002:a05:600c:c088:b0:486:f4d2:eac6 with SMTP id 5b1f17b1804b1-488d67e6776mr181720905e9.13.1776189321058; Tue, 14 Apr 2026 10:55:21 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:cb49:f403:bb20:cc84]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede1df12sm150436425e9.4.2026.04.14.10.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 10:55:20 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH v2 2/3] drm/exynos: remove bridge when component_add fails Date: Tue, 14 Apr 2026 19:54:15 +0200 Message-ID: <20260414175417.144625-3-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414175417.144625-1-osama.abdelkader@gmail.com> References: <20260414175417.144625-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_drm_bridge_add() so the bridge is released if probe fails after registration, and drop the manual drm_bridge_remove() in remove(). Check the return value of devm_drm_bridge_add(). v2: devm_drm_bridge_add instead of drm_bridge_add + goto remove_bridge Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 29a8366513fa..e68c954ec3e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c @@ -423,7 +423,9 @@ static int exynos_mic_probe(struct platform_device *pdev) mic->bridge.of_node = dev->of_node; - drm_bridge_add(&mic->bridge); + ret = devm_drm_bridge_add(dev, &mic->bridge); + if (ret) + goto err; pm_runtime_enable(dev); @@ -443,12 +445,8 @@ static int exynos_mic_probe(struct platform_device *pdev) static void exynos_mic_remove(struct platform_device *pdev) { - struct exynos_mic *mic = platform_get_drvdata(pdev); - component_del(&pdev->dev, &exynos_mic_component_ops); pm_runtime_disable(&pdev->dev); - - drm_bridge_remove(&mic->bridge); } static const struct of_device_id exynos_mic_of_match[] = { -- 2.43.0