From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6EFD3CC9E6 for ; Wed, 15 Apr 2026 08:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776240517; cv=none; b=kWRBu5li6fBpOLgcbznKrTZIEQydbdySTCweDwCyJ32Ba+XBur0oC2yvUcbDto27cnv9JRKVQK8cJUZiaWkc8izvfse/Lg3JlvPqQuS4GerrT3okSvRwnBa13AtCpDy+kzJ8YjXpWHTsfj/7oY0+BDD3VebMC/NlZbsFzIVVCQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776240517; c=relaxed/simple; bh=f3Sav3+fI5mgc6eUxCrdoTC+ImTmZZ+KiY6sukwMp3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PgJ1if4LDoTiT1XVGIsZksf1ixnuxbO+vU0DzvUNwndFmF4uxZoOZHW/gqWuPRsa0axX07pIs1bCq7bFb8ehPv3hweBHvTvGhookl1WDZRyW2OpD0JdzWpqpOlqCZ2cXg2j03OCX+7Hs6RwuP6flIza49yx9Y/4pIfHFN5wyIyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UhTjz3cY; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UhTjz3cY" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b9d9971d059so615798166b.2 for ; Wed, 15 Apr 2026 01:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776240515; x=1776845315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4mQ+bDBDc95NGWzUI9atKZuTpO1qC2/VErOShoToB9Q=; b=UhTjz3cYLz1QZQ3deDKefB8jGUS+hF2QkCyNRQp0n6SfGanZH4nM5n/MrdKbpGurwr EPzuiZNztPFywrNG76r2xJrm0bXJXJzE48wR4zmQIn9p8pN+7VUgxvB+I8GhlgaJMPwE fzywS1iRd3q1NGkI+/5iDDggQ4n5MCDbXk7a3vjKNb93/4+L6wJ2nX+NPwnODOtLIV5B 65mif/Qxq94DBL9dndHgJd/Dty8PogLyFUjUqJNph5XxntLvNGAbdmJ8VGzlc5NNdhNs lTwZE7aHQVYJYubC4bilB+tXykvE1P74sB6KJJ2mwhu/kNJBO6bVw0KGcu6jbz3U/zUe DdIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776240515; x=1776845315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4mQ+bDBDc95NGWzUI9atKZuTpO1qC2/VErOShoToB9Q=; b=Vx4r/o19zElnOwqodCZflc+qXc3h3UQ5hv1V+dRQ5B2HQ6hqeAh4KMBx6TrcRgzddi /NAtW8/ayca+RTcGSGx+I1yWaX6ZaFQB1lL/jvWTRBGh6VTvda2wNHb7zj3Rd346uGvI RZIFtOzleQRaARbFZQK2ArsIlAOVcGG/u4mr5cjGQDcXnsbIwvBgaQBmBkwZfRZzk/IF DuRhDeyeqKugKrQ1CTkvlNkQGDmMcZASkwP/xcjORwQsq/KFq0fbzmPoFlY9lGX4+pkY xG/kjher+LrfjZvsB2zrnTW3Org8UzdtGFjUf8/keD84ITgeuk+yCESNO1R/WkocoFqr kYeQ== X-Forwarded-Encrypted: i=1; AFNElJ+mvqp0q6eajr0DStPTECZcKeuWfKWqhTqpqXnAcagez0VGEtBeCl0qK9elclARQYCJ14bh7ZFlxNLv19o=@vger.kernel.org X-Gm-Message-State: AOJu0Ywgo4lNL+u1uUrSqazcoyDvpcSql/arPn6Y55pgDzitA4Bawvqt VmabcEdAIn44BiMT9G4TrzfbRp/F2IhMB4EiasEG9SYgAt99K7zXyord X-Gm-Gg: AeBDievu+3654ZpKHHe5qo7fAzYfuVMAJBcftwwQh8LdLlgmfDskN/24qWM19sofARK XqOIfjHCoA92uWLRZBHM+YIOfrFg5cjboIQnR/H9NUPMasCyrLQrFDpjCn0fNag0zPFXy64Te8B FkuUC6GsJ6/OjicSalf4GDUzFsttiEKWRU19OQAuUVr59ytesE3wLfQgMO8DdsUxnxiu483mpgj 5c04i+9TPjf9r3NiixUBsy6Hcuej14zexWWooFkurQ8qpki+FewZ9TU2mfBJHmKclf3cc+qD6zs b3hJgOAWr1NO5mSMmbCWD2VIR3ZQ7J4NGYn+8uNdmKS7pxOe7KvuNWcaqjQEDASvNrFfKjvjOhE rxNXOECBBcUWyd37MmqOqgnOUnSqe27QgPRuG8rXYCeyBsvj7I+G9TJsQILZza/ByknzXykxKNI 13/X5EKoHtyM/+JW2gIWcQNR4BrL47vW4sqSqP4fD0vLIlE//Grl9AwoNDkz8HDO7sx21ifVnpm 8Ajp9MPnlvb/0Wa9FWrswaAqTUu+4yQ3VF7h+6TCyvUh7wqyOLslqE/NITOrT0BbeKZVOqIjDCN BcD3rSrCavrNIDqtDeNCKJyoZxKUgOyM5ZQ/++jj9O1tyRi4eaK+csc42d+IQ28BNt4CIXzv9hG AVBKoOYn5PR+WfOZ+1Uzm2nV9UzXS262N4YDlFja8DmaNw/SVVxyx+qcN7RivCWoPedI3BmmZ+z q0rmXwJ3pm3mYV/n33jYe4 X-Received: by 2002:a17:907:e107:b0:b9b:5164:905c with SMTP id a640c23a62f3a-b9d72793041mr644068766b.14.1776240514847; Wed, 15 Apr 2026 01:08:34 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-a.c.od237066db22328bb-tp.internal (239.185.141.34.bc.googleusercontent.com. [34.141.185.239]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba1773c2013sm29720066b.34.2026.04.15.01.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 01:08:34 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH v4 2/2] iio: frequency: ad9832: simplify bitwise math Date: Wed, 15 Apr 2026 08:08:12 +0000 Message-ID: <20260415080812.1284-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260415080812.1284-1-joshua.crofts1@gmail.com> References: <20260415080812.1284-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts Reviewed-by: Nuno Sá --- drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index fbcfdbd398..cd7c7727f7 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -111,8 +111,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS); + do_div(freqreg, mclk); return freqreg; } -- 2.47.3