From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E6333F584 for ; Wed, 15 Apr 2026 09:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776246399; cv=none; b=JWVmigFuWRn0idOy4eGCCVtixBz7rh5nlC6LIdVVHW2Z+m05/poi6kagM41t0SIYWyjUGWYvpHwnqQ8+WptdT27vn8+vcP9EFxGM3uBilW6nKPIbWSCRKp8UH8ayeWbNuTXQ2Cwxkhavj2mD3NgwA/VMQUp++Tb19sDeJ9zMGZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776246399; c=relaxed/simple; bh=Z2lRbePXb/WkTbD0C7QUi/a02dwEcYPjuzTeV4XTjEc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aa1qAp4ntAd51e3f1UlO0wBpsNGP1QnfrhBBEl+A5lAi0X7OJMNW+2MVR82IHAm5kztB1wp6YH4dMgY2NEKrXbQasz96MFCpAzvCx2FPeK+Uqr2tBpvGGAatWSBuRKiwo0f1xTUiuXMIxDGgArF0aM7Jt/BTsXW4JeThO2CVwBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EFvV8OXB; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EFvV8OXB" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b9c6680aaf8so1088353066b.3 for ; Wed, 15 Apr 2026 02:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776246395; x=1776851195; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lqRzq0kk7QUDv7Zgb0cPFlnME2nNgpszREhEUniJWOk=; b=EFvV8OXBSV3K739eCis/zR4mmCwKzb9DioShTyYzbpUm8JTQqRx0O45TxTJAXTBlLi I1xWNwOcd+JV2iu1swvB1trIzpTNxdCk8DLl65xdUVK+2iSn6EAPQdIvNf7fasfEEz4D jhYAALPUz7otfyoS0V1sTKHco7mkMkqAwJNxPBLydj7SfbHX3uqYkS4SaYt8K929+jrb lCA9XMWo3X7yP36h8CxkKg1mykP1oF4NC8WKGZBZaJu8+uuHPDnFB+futVidjqtYnUph 4lotln+EhesAaMVdTfQ95X9YjRwb2cGSvsHFKtJ2KXSoCiA1QKesQcZp7FMUN0OL5bWw Z2Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776246395; x=1776851195; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lqRzq0kk7QUDv7Zgb0cPFlnME2nNgpszREhEUniJWOk=; b=HsVgSct9C1u87oUU8Iq0EfUoPzDnt+Sr8cg32+iRqfBdvPJyVvOG1zADnl7uRFT6Dz B+ulP2ShsLCwAw+KNQPL/mGy/998x426onr4c1bnWPp33OmDb2sV2rYK9mMz9Kz3l+ML BX3CGImUeAVT9M1F9dn7jPh3JhL+YQ+2cwovqVmH9DzI/+UsQcQyT7BnE0oZrRWC3SF4 ewXFBtXKI4egSTIXrzj4MKWomqY5Y0RHYvbawzzdfdgCT8C6kdL/w2xwCubhhnWUY/7w 6yHZhMyym08Y/9gHi1IWv/LSs2/mKKGkLEqQNB8lat5O7o3w9Tl4hK+og/EJyshDCvOY MFVA== X-Forwarded-Encrypted: i=1; AFNElJ9DRhgWxyFznnJQWDkGeqvflJfQu2XzWcGGhKqmWZroV3dHQsey3gcia5mH3f0lDhIPbhAEqzqYm7r/bug=@vger.kernel.org X-Gm-Message-State: AOJu0YwwmxdjxndhtmZ3aru9DraR1vyO86CxPGX/rBQNJTOvpbE5+V2S g2abYahKd8JevtmEe4YjpqpUEBWFhaOtfJrYGHsHOorh7eGvsqog1Ycq X-Gm-Gg: AeBDiev5eftEZInOTXChA4jGVrhiqG3EbcX71qia/U8CjcQRTxOTLaxrLSwVlJLQThv E6bvXkeOBe3jM/YFMv52iTMEDsMqjqlYhBRRbD6zHtyGChv4vrq9AaNowlFOsRQGGNLbWaIgccA mpIu334/gIYNVby2x3XF7H0wxJY3eww2v9CprszQcH5G6Z3AaBEHtgvMDhMLwRFdZU3bvOTt0z+ M1hfSVvrmlnE0tqAvuZa2lsZr+5s/4RvU2A2tgmREvPfyFSJoJlx3ZS3zJmlaqmJoLEEMvQ/kf+ bWPnxGpYbH5ny83J1FOavNh7lNuGKP3GieaRTzrrmrPOUUlHV0WzoevI2GEP42rzmDjDJm4WcO5 lxE/ukspqRQfqLOpA/tEGKy5SKavQeBSF0ApkUs/PJf2kkbeHejO2YekW0m8Mk0K/orrR0Ra98Q zF3D/clFrakAMl1paM7UCXTFQtTn1bF/TsFS19YjZ9/pLqvB7RLXmitLE73v9O4vUQnTDt4U/wG 3YuMzsSgrkyZata0kABlHT56crRa6QTLJLqFlp3hExVmUhnKOFyRJppaT4dOKJPsZnJI2ttBp0a dqYQiaksMR+5T9xm X-Received: by 2002:a17:907:c80f:b0:b9c:9da7:9107 with SMTP id a640c23a62f3a-b9d7267ec77mr1325324166b.41.1776246394992; Wed, 15 Apr 2026 02:46:34 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba1778c4e57sm39310166b.47.2026.04.15.02.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 02:46:34 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, stable@vger.kernel.org, luka.gejak@linux.dev, hansg@kernel.org, Alexandru Hossu Subject: [PATCH v6 1/2] staging: rtl8723bs: fix heap overflow in OnAuthClient shared key path Date: Wed, 15 Apr 2026 11:45:04 +0200 Message-ID: <20260415094505.1115208-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtw_get_ie() returns the raw IE length from the received frame, which can be up to 255. This length is used directly in memcpy() into chg_txt[128] with no bounds check, allowing a heap overflow of up to 127 bytes when a rogue AP sends an Auth seq=2 frame with a Challenge Text IE longer than 128 bytes. IEEE 802.11 mandates the Challenge Text element carries exactly 128 bytes of challenge data. Reject any element whose length field does not match sizeof(pmlmeinfo->chg_txt) (128). Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Cc: hansg@kernel.org Reviewed-by: Dan Carpenter Signed-off-by: Alexandru Hossu --- Apologies for the version numbering confusion across previous iterations. Changes in v6: - Add hansg@kernel.org to Cc (original driver author; accidentally omitted from the v5 series) - Patch content unchanged from initial submission drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282d1b..90f27665667a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -891,7 +891,7 @@ unsigned int OnAuthClient(struct adapter *padapter, union recv_frame *precv_fram p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&len, pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); - if (!p) + if (!p || len != sizeof(pmlmeinfo->chg_txt)) goto authclnt_fail; memcpy(pmlmeinfo->chg_txt, p + 2, len); -- 2.53.0