From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952C63246EC for ; Wed, 15 Apr 2026 09:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776246401; cv=none; b=Rv3xCN9Goe95Zt6ILuNlb5iYcTSd8gDK877+JcLKhHkwJkI6ZavjB+44wnMIFQRafckeZ9e0FIrbo+zjb6CDkiZMR2TB/jSDSlbMTEahEKd97oxWCo4356o05bVJE7n6Tx2pSAJbjvNe7IMCmr7f8Ij+JP8Zzu/goI+zMlkyibU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776246401; c=relaxed/simple; bh=LKL/MhWeV1FzrCZwdQLSjCSaRmITso0Q7UDbgZ9YwdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JooE5d9UFINHn0RaQvrZHAZ7jERAHCfNFGl8wAsucbFIg4+htg7UQqUvHGveaKWUyJuTgYAYT7bEDcliRXumDIYoueKI8MFRHS1RkPMN50Kx1g3XwZ2BB0ZGZjUMJYuNWiGElfK9UjtiEy3T1ySVChx71fdQlj+5ryQP11Iu2jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=crVQINYW; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="crVQINYW" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b982b0889d8so954898366b.2 for ; Wed, 15 Apr 2026 02:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776246396; x=1776851196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kMZ3rmolb4xRGVlwbHJI7Qiu+rWBXpl768B1YvbmjeE=; b=crVQINYWcwpdMq4F9aveMGeWCJG6prb0NS9C9dtnElyjyftQQGiVrQ1DX5FO7JgZDV itJzomyknSjcop6me/VyWbWD6JvrKZiARLZ2sgdIYpmZJfwU4ycItRgSQEhBcdsSBUQ0 9wQB3n90vx2TseezfhD2ay84XS9q5AfeINPt111TRivk3B6HbNvrOWWbvotywtNko+9M 6fRpkAah5CZyJwpTaxkkk/ZDq7Pl11hBWApL+91DkZ7Mml1AgqyLvBKispekBRxkPW7v s2gy4zth0snjC0Cf1oUVhE/DzFezrucRGcA4VSrEMfbAkkGKUlPmYG7iWO2acb+ICBgt S6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776246396; x=1776851196; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kMZ3rmolb4xRGVlwbHJI7Qiu+rWBXpl768B1YvbmjeE=; b=qYasCizIP7tjjy/SOCDAlR9SflixFsII3wqLWd2axUxK8cCl2mxyr1ogGTT+fHa14S Ix4d0XqqjdBBa/raJx1bwMXiirZ7upGon2bAgFqCa5UJ6Me6rvELwIi8vaJL+C5jMB5S ddNuLijY9fpDvw4hQWHu4FbhyURz/61fABO1a/c/WyUlOZawBV4CW2R5sYat0+BD8Ymf xy/A/6g3mT/I8mWMGQcgezHov2DLAkLjRb4ALJIclhP06E2B8lBVLZ1tSBIQCfz1SvFg MgLHyQXYypW5/n+dPv3TCn3c3onKxwax/BjGsCBhzJNdRuXDTFdO+SpvmcddPilItgIA LZ3g== X-Forwarded-Encrypted: i=1; AFNElJ9pylHRp/cUrd+iZBD8CPtUEDtuG5X2dOExO9R3ViQK/o+LWZK0b0Krl5rYovge7QImAQaEQHSK6CGuQmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxr+uljE7gRPTL0voIH1P0PeMwdKio2U3v16c4Au/LHzXmG5xW pLv0YxBp+n2yqiDH0OPF/fGD0zF26CCUI/OpXr/ZAGCUXzrpeUI54FoO X-Gm-Gg: AeBDietGAWSLtoz/IxZZINCp75x7Tg7265ByX/AYPmI2zMwKR02vV9C2LybE3W323dC 6bGhnJBoJ7aZpSiPnC9svEcvK/vChNEu648U0a/WHiLW1Pdl6nyVIUNw5v/MLxzdtR4VVd9uK7/ Ny5CyMNfvy4BxxNHZU5cK9N1U2mNDHxNhfbk+UI+To7yn2eMXYbBabf+NM6GGeIpCHkw5FAdiJ6 qrJXWLkvMUFjZLw/7UBlqlfuZxH+RbNvFYQZ4OKKzVgoIMpYd+EKUFEnTfPwQXERxQ7wNdd6Q/G nlswWdSRngPxq0tkJ57ILe4V3V5+oSlY1bUQAv5k8EV+tylEcMSta2Kuli3ezXR2NmXLrJ62XMw zGBkStC1TDC1DpKijx61Jgb/WLg3NlV1cNvrPSZjWV2EfMcJme5KbF0VEzicC0c1ucHg5PAxqU+ r42+ogJ2Zree2Q8HGEAy5IsqRj6bYy+GUa/VgyGHhOZ8BEEoNLYcq2DwJgYsXr/4S416U0BJaYT 9l4gxah0gS5U5YWNjxgcECDcfxv3QEYOUsMOV1EYFygGaVflvCApZRx9n5sWKd4MBy6x9zmEvfG bFkqTTM7o9M1/ts9 X-Received: by 2002:a17:906:f582:b0:b9d:6109:f1fb with SMTP id a640c23a62f3a-b9d72440757mr1236270966b.11.1776246395751; Wed, 15 Apr 2026 02:46:35 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba1778c4e57sm39310166b.47.2026.04.15.02.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 02:46:35 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, stable@vger.kernel.org, luka.gejak@linux.dev, hansg@kernel.org, Alexandru Hossu Subject: [PATCH v6 2/2] staging: rtl8723bs: fix missing frame length checks in OnAuthClient Date: Wed, 15 Apr 2026 11:45:05 +0200 Message-ID: <20260415094505.1115208-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415094505.1115208-1-hossu.alexandru@gmail.com> References: <20260415094505.1115208-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit OnAuthClient() accesses pframe without first verifying that pkt_len is large enough to contain a valid 802.11 management frame header: - get_da(pframe) reads bytes 4-9, requiring pkt_len >= 10 - GetPrivacy(pframe) reads the FC field at bytes 0-1 Additionally, when pkt_len < WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_ the unsigned subtraction passed to rtw_get_ie() wraps around, causing it to scan well past the end of the buffer. Add an early check against WLAN_HDR_A3_LEN before any pframe access, and a second check against WLAN_HDR_A3_LEN + offset + 6 after computing offset to guard the seq/status reads and the rtw_get_ie() call. Suggested-by: Dan Carpenter Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Cc: hansg@kernel.org Reviewed-by: Dan Carpenter Reviewed-by: Luka Gejak Signed-off-by: Alexandru Hossu --- Changes in v6: - Add hansg@kernel.org to Cc (original driver author; accidentally omitted from the v5 series) Changes in v5: - Resend as 2/2 in two-patch series at maintainer request - Add Reviewed-by from Dan Carpenter and Luka Gejak Changes in v4: - Replace incorrect Reported-by with Suggested-by: Dan spotted the missing length check during code review of the heap overflow fix; he did not file a separate bug report - Add missing version changelog; correct subject line version number (previous submission was mislabeled as v2 despite being v3) Changes in v3: - Add first check against WLAN_HDR_A3_LEN before any pframe access to also guard get_da() and prevent unsigned subtraction wrap - Rename subject to "fix missing frame length checks" Changes in v2: - Add single length check after computing offset to guard the seq/status field reads drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 90f27665667a..884cd39ec756 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -860,6 +860,9 @@ unsigned int OnAuthClient(struct adapter *padapter, union recv_frame *precv_fram u8 *pframe = precv_frame->u.hdr.rx_data; uint pkt_len = precv_frame->u.hdr.len; + if (pkt_len < WLAN_HDR_A3_LEN) + goto authclnt_fail; + /* check A1 matches or not */ if (memcmp(myid(&(padapter->eeprompriv)), get_da(pframe), ETH_ALEN)) return _SUCCESS; @@ -869,6 +872,9 @@ unsigned int OnAuthClient(struct adapter *padapter, union recv_frame *precv_fram offset = (GetPrivacy(pframe)) ? 4 : 0; + if (pkt_len < WLAN_HDR_A3_LEN + offset + 6) + goto authclnt_fail; + seq = le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offset + 2)); status = le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offset + 4)); -- 2.53.0