From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CCBCE3E9F63 for ; Wed, 15 Apr 2026 16:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776272136; cv=none; b=YJ3/xuor8wHjign3+bG+Qs+n2uBlzCfWvzQl6qlgflWdLTNQe47XlXyf5k5v/zPwc1kQIo8fzQy4pBe0MvVXN5J+UA2/CH/6+iUBPCnGoRl5iX9nitzcF7AJhskTAlvwuVExncrOa+AvGgSAL48XJKKHBrQUQDJroBYJYdvOmnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776272136; c=relaxed/simple; bh=+h8s2k45gr74tkKaNYCUe+TMlKHAxaWDuG4e1iGbico=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F+lUpi6L0sucGmxqzq0WmXYs7LA3Nf63zkBDckRSmlz1w2M4HFZpa9QANbQWWPLETBtKzM5ntiIGmFerL39kU2pUuYBnwSKdxoVys7LbHqkyvzJVsVr9d9tutZ9oirKGg/LJGWqkF9nLbiXIYqJGJgVVXbY8KX46/e8wXGT3ksQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=IC17eKAD; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="IC17eKAD" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CE8B32FB; Wed, 15 Apr 2026 09:55:28 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6950F3F7D8; Wed, 15 Apr 2026 09:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776272134; bh=+h8s2k45gr74tkKaNYCUe+TMlKHAxaWDuG4e1iGbico=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IC17eKADy/X1hdMMm6YM6fdGw6N6LrhFg6SD704r7cS5A3uxF1yD4ildGMbcPnbuF FZeO91sbHf2V8DAVeq4xeV1Y9Vt+hMzX+2vYfT3HoI8e1u6F/2yL7jx/t0zyKWc7Hj gjWKdGJ1nYQwdA+PuypqXwG9UqgHR4njT3IPNgCE= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v5 01/12] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Date: Wed, 15 Apr 2026 17:55:17 +0100 Message-Id: <20260415165528.3369607-2-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260415165528.3369607-1-yeoreum.yun@arm.com> References: <20260415165528.3369607-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit According to Embedded Trace Macrocell Architecture Specification ETMv4.0 to ETM4.6 [0], TRCSSPCICR is present only if all of the following are true: - TRCIDR4.NUMSSCC > n. - TRCIDR4.NUMPC > 0b0000. - TRCSSCSR.PC == 0b1. Comment for etm4x_sspcicrn_present() is align with the specification. However, the check should use drvdata->nr_pe_cmp to check TRCIDR4.NUMPC not nr_pe. Link: https://developer.arm.com/documentation/ihi0064/latest/ [0] Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index d565a73f0042..74b7063d130e 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -89,7 +89,7 @@ static int etm4_probe_cpu(unsigned int cpu); static bool etm4x_sspcicrn_present(struct etmv4_drvdata *drvdata, int n) { return (n < drvdata->nr_ss_cmp) && - drvdata->nr_pe && + drvdata->nr_pe_cmp && (drvdata->config.ss_status[n] & TRCSSCSRn_PC); } -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}