From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2BC43E3D93 for ; Wed, 15 Apr 2026 17:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776272489; cv=none; b=bZYJULLhi3ztkPnMCnBAwlxgrClOSKn2hSsg0DPbFpLQAnwHhSE86IHKYfvlUeBYMpljaUPz9iYZI9CUAgHW0YRocPB9G4SHQ95EuSxXHL2+CHrnw2PawDl9WGESxB2ZRIBYy/pgStMlr6W7HulKhaDUmLgdvIG37+rUOptUTXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776272489; c=relaxed/simple; bh=nKbqGY84rIJB8BOdLzFBm2ltPcQM/ROZhxewUnBDS9I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U3RzNKLe3oJiUWjTo0++gSf7KHc5uyjg6+kNC/gNLTehsr/QEID02X4qTnBIpBobZn4+J7LztvqwayvsKFX2lzF+Ba2ZAfg2VBdN7ib3egDrJLVlbLWgq2xMH9vndt71UqXtXpBi23Ar6oKs/w2slC01TETbGDuv89La0AP5EjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NtDYC7+y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nSmqfcM0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NtDYC7+y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nSmqfcM0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776272485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Nj+i/zUf6yIYxwBMDoj27NRKQ28v/DcLzCnlkUqOk8=; b=NtDYC7+yejGz1eAGaQz89VYzXVESMEfQVNHK8pdgMcpEU84fR+n0uTvbvkbQKug8LvIc8u JkBvcvGdrnmpzlWJa6Vyo5vlS4TsEKPiN8X8cDUnCW+fKQMvRoJqUKCvYGXmVaav72JOd5 VLjq7FgaL/rb2MdbUeDy8ZxInHOXUcU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-B8K31ByoPNKk0w8QMnZGsw-1; Wed, 15 Apr 2026 13:01:23 -0400 X-MC-Unique: B8K31ByoPNKk0w8QMnZGsw-1 X-Mimecast-MFC-AGG-ID: B8K31ByoPNKk0w8QMnZGsw_1776272483 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d63962d83so167591911cf.2 for ; Wed, 15 Apr 2026 10:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776272483; x=1776877283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Nj+i/zUf6yIYxwBMDoj27NRKQ28v/DcLzCnlkUqOk8=; b=nSmqfcM04Cx16DM6QJrk98i5mkVXdtlWp/ZA2jlBFi0q9ZrLo78oeHLAyn8gkZldJm eVdFrHwETW2dnl4/CO1CypDO5RlxlvSFu/z+WuMC7mK83w7wrLh5V/nOZBFa6o6wcc/v mtoYKaIrVB5+R/1n+UR89Uzf1fXZOhbDpcTG2nWVnimoGKpcaZ/m7yTSpbsuQ5FiBzOq /uZj0v2ivD/1w6UqhAIRkdHGdqZQC64eSDdh78Z1gmoZBRt/i5mVErzrqqYkbq+eRgy+ aovLGR7mj6LVxTo5DNYns+Oea2CT4CStXr17lG7OxtWJxzAco/3vGkNE+3NxdkOanVzZ oJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776272483; x=1776877283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6Nj+i/zUf6yIYxwBMDoj27NRKQ28v/DcLzCnlkUqOk8=; b=F0L1pgKh1MoWdbgoyCUV8pGFB5ESkRcjqdy9cZ1+/mHbJ7sVwALi20mOnFV2AFTih9 GRUAEI5VzqCnNkQy2PQ3lQIw9W1ufU27lqelOsnzoL8B/iKMoGw6VenYPuXJX+9PJKME o7XAmB8n7hFodGdB+9SaGACoIm84uVjIyKDQ2pepfegGmFGy9YfAEzA12tOtGerclBKz v/fGDyTaOOMhsSZ3dLlUx5vUiaC+qYOEZlf9i02DiRVvumlZA4h1YCAonhksg5h6HmbK JC8pvzDzjI6ZRdLq3VqxA+qP2t/+VrHWOZm9Fat/xMJLI412Cet0QjfAbO+Dq11lhum2 eFqA== X-Gm-Message-State: AOJu0YyjgLZzz0UXYyd6Y+mgDOUL6I46122opLxR8jhI36sKdLfkU275 8wXpnqOlpzsHpFIof08UT2kENAAGRtk1vmzXgbzpwnO87QJxMb+gWQuYUkvZSE7hacDEZgE8AkU dLMscVN8hHdUMCD3fGVKJ+8oTdJtsbBsMjYxuzlLCY5P677oF+DcL7mqVeslM+vm7+g== X-Gm-Gg: AeBDietzFZuYTOTYXqmIaNgeOgrhR/DWVXjmGAY/oS25MQC2SDOZGKDm3A8juKBDvjF R1ZRrESB4vyzXSQaljF14c0mmFiIcqxCnvAyDosp8WHL3z2WOzVi5PgmbI2qNIh6eRYiOIuPua8 I/9vJpCT8hdzXXmevSnDF0EZRs7Kwu17ok+lrOpzQSlV17c60mwgxZlFcRkTk+Oe80JLl+aolED RMzVPb6HlVEiQVahp2DbsFprCE1jo4wiA+Wiogmbv5+h2FAV98Gu0fKccuf/GzSJmW6Qtmz45Os 5efPeqt3AT0wYIoyZmvh41uVjTeyayj03E96Y2/nRSQt1K5/hvpiMooPr6ntt+n+jSwpL4EUdtO 8XBdXratVBy8XeMT6jOvUBiGW1uVobZntXa2W25uiWPz9HDoPywV42RVHye7Q5FMHeA== X-Received: by 2002:a05:622a:10c:b0:50d:c69c:d01c with SMTP id d75a77b69052e-50dd5c3d6e0mr339846751cf.37.1776272482479; Wed, 15 Apr 2026 10:01:22 -0700 (PDT) X-Received: by 2002:a05:622a:10c:b0:50d:c69c:d01c with SMTP id d75a77b69052e-50dd5c3d6e0mr339824561cf.37.1776272464530; Wed, 15 Apr 2026 10:01:04 -0700 (PDT) Received: from cluster.. (4f.55.790d.ip4.static.sl-reverse.com. [13.121.85.79]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50e1af9dc5fsm16817841cf.16.2026.04.15.10.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 10:01:04 -0700 (PDT) From: Alex Markuze To: ceph-devel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, idryomov@gmail.com, vdubeyko@redhat.com, Alex Markuze Subject: [PATCH v2 2/7] ceph: use proper endian conversion for flock_len in reconnect Date: Wed, 15 Apr 2026 17:00:38 +0000 Message-Id: <20260415170043.3882912-3-amarkuze@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260415170043.3882912-1-amarkuze@redhat.com> References: <20260415170043.3882912-1-amarkuze@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the __force __le32 cast with cpu_to_le32() for the flock_len field in reconnect_caps_cb(). The old code used a type-system bypass to silence sparse; the new form uses the proper endian conversion macro. Also switch from a raw bitmask test against i_ceph_flags to test_bit() on the named CEPH_I_ERROR_FILELOCK_BIT, which is the correct accessor for the unsigned long flags field after the bit-position conversion. Signed-off-by: Alex Markuze --- fs/ceph/mds_client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index ccf0d53dde2b..871f0eef468d 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -4693,8 +4693,9 @@ static int reconnect_caps_cb(struct inode *inode, int mds, void *arg) rec.v2.issued = cpu_to_le32(cap->issued); rec.v2.snaprealm = cpu_to_le64(ci->i_snap_realm->ino); rec.v2.pathbase = cpu_to_le64(path_info.vino.ino); - rec.v2.flock_len = (__force __le32) - ((ci->i_ceph_flags & CEPH_I_ERROR_FILELOCK) ? 0 : 1); + rec.v2.flock_len = cpu_to_le32( + test_bit(CEPH_I_ERROR_FILELOCK_BIT, + &ci->i_ceph_flags) ? 0 : 1); } else { struct timespec64 ts; -- 2.34.1