From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C513A390CBE for ; Wed, 15 Apr 2026 22:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291806; cv=none; b=N1csAjOm4cyqepHBfNrdBwqU7Z15TQ4tZOrVKiCTxFDDT8g8oyRSr4cmrqhM4irfi32578DBtmHVVpK8oWdDXQqZ9q9A8QNXrJ00LeeHaZcxUwn/B/nU1hA0KM4EPIyk5Dx8Z3nRXBA+5QzFiWW7xdQBKXtu5UUsRyVfqOvzY64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291806; c=relaxed/simple; bh=tGljGO9tzKW8lni6xeMPD7R0c/Mxcc3qq+fWX9qFIS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ROo/v+Ra76SD3kcpoYMRBaRIQSQvmCU9ZVjiCE8+P/0ZAnKtw+ZjaITc0PA/5qG1Zr42wWNpfNVDdsGFVubQ8aFm6hioByXaL1lMx07ibVkIzUWbRYAG0e7A0JZOQ3qfHymMrOfEF3qywdks+WjEIV13KejeYbcW3xJsMhpmz5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mcnkJsOv; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mcnkJsOv" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488971db0fdso72521715e9.0 for ; Wed, 15 Apr 2026 15:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291801; x=1776896601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fPRO7u5vAVBFmWntFw1KXmo+AzHAOpXCPHhKh6Z1jzs=; b=mcnkJsOvD46gyQNcdfpupUrGFqSdR3m4Q+FDSEdnUfHHyqX/7AYQ6FcHkXQVoTrslC jvbFeqoVq1rTYaZdwgstdMq7Sq931OHhTRNg9Az5Vl5ztXVVZb8/EvTptTy2XPps9mgJ 5HZR4qO/bMZvjUTWrey/JoVvhhsvqZcUOIEDhI+oB96d28g0FUEAxyH7kH6Iy0BDstZ1 tv78sRzE+zIaxmo3aXbR9/yTZdaRtjHoisCvxgim/rTK9gePOGWYJM8RppE3gePYXIn7 e3uy6b4q/kNE135wbw3Iv+qou4vPiN0Qb21gS6Xn5uuV4wV8nO/OcmCqJkODyQN6FsuM 1XTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291801; x=1776896601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fPRO7u5vAVBFmWntFw1KXmo+AzHAOpXCPHhKh6Z1jzs=; b=ZtBicFDVBk6IjS4Z+oJBFFhHTxZAU3P/nEeiqE5IWGRvGGURpBEdZxsi/YNkcoM3MR 8/Gu7QQI4lnPlb9NQFp2ZOWwUfxiF63SxkWdH94qWCEbt2yAjPu59sU2CxtKlWdErdR4 3SKW4BVQSinHT+jKp2vQgiOUMVAD9s8lAFgWcNoFkQyiY8Ptq12M4vyosVpBHUlI1zxE 11RFHZ1Y3qcH2tZEK0l7r+ccNDECMmEjvhp0Iv4HXL5JgN/nhAfwhSzHrr3mb4b2qdeq e+XROEqcg4JCdEqolHLNXrfUNuZy1kRZjfNKAH9D3SqrQUnzDgrfvJH+1Hbf4RrJOWhu ieNw== X-Forwarded-Encrypted: i=1; AFNElJ+TY07/8mHIp+kYzPVlmOuQ7ROzGztts0uOlkKjrCBD+U7doehe8rf8DMACzJq2+bQIC+P1bcbVPuE2Mic=@vger.kernel.org X-Gm-Message-State: AOJu0YxjOd52o4nS6WIJW+8mxsZLQ4WXyC6F62beXnBLtVQnBM7QDjXv z5vdK3ttDvGP/6B12v0lb+W01eLYRJFMx0NCsQm3NuePI6Odn1mgnNo= X-Gm-Gg: AeBDiet7zOJV4S4v20bAcyFH5426b4b8BCBHbldJg33bDjMYYqL2usob/GkMDmrPsl1 hmwVXEKUZyTteW8udzvTlAglL6e+d64R5SLtN+vpMNqwfpXHN3MLsiaJQ+NawBysz8n3KND1P1s O46i5FrqzPbtmUzv9nIkMXfX0IBClSQzL1aP0ZASlGCS0ZuBHiS5PCZJtfZDnmw8Y3p6rOQuy07 FW1l8lvbeMosTDwOrEG+EHuI6Nt2Om8oyjLsXxi8JtJTbSeqGpYLUrGul2uN0KTHpzuSbNIgbI4 ehMiV3B60d8+JkI8LgTpX+44ODomBJpXaA8DjUcqceMcK6uSCKCbyuBTZNCwYGyFH5iHsy3C/HA vlu2LHUBD9QbDr1WxhmO76vFvUXxSQaErAWBlApxgJgmdTyEKnKaQRSP/COw9Y6XvmtcEl/yIdZ 7Lm2U= X-Received: by 2002:a05:600c:5d4:b0:488:d6eb:e63c with SMTP id 5b1f17b1804b1-488d6ebe787mr192488315e9.15.1776291801139; Wed, 15 Apr 2026 15:23:21 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0e9a742sm28702585e9.14.2026.04.15.15.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:20 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] wifi: carl9170: bound memcpy length in cmd callback to prevent OOB read Date: Wed, 15 Apr 2026 22:23:17 +0000 Message-ID: <20260415222319.1538389-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222319.1538389-1-tristmd@gmail.com> References: <20260415222319.1538389-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani When the firmware sends a command response with a length mismatch, carl9170_cmd_callback() logs the mismatch and calls carl9170_restart() but then falls through to memcpy(ar->readbuf, buffer + 4, len - 4). Since len comes from the firmware and can exceed ar->readlen, this copies more data than the readbuf was allocated for. Bound the memcpy to min(len - 4, ar->readlen) so that the response is still completed -- avoiding repeated restarts from queued garbage -- while preventing an overread past the response buffer. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- Changes in v2: - v2: bound memcpy with min_t() instead of adding early return after carl9170_restart(), per Christian Lamparter's feedback. The restart path must handle queued responses gracefully. drivers/net/wireless/ath/carl9170/rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -151,7 +151,8 @@ static void carl9170_cmd_callback(struct ar9170 *ar, u32 len, void *buffer) spin_lock(&ar->cmd_lock); if (ar->readbuf) { if (len >= 4) - memcpy(ar->readbuf, buffer + 4, len - 4); + memcpy(ar->readbuf, buffer + 4, + min_t(u32, len - 4, ar->readlen)); ar->readbuf = NULL; } -- 2.43.0