From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EA893876B8 for ; Wed, 15 Apr 2026 22:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291811; cv=none; b=U4CVoyPIGapbY3h8oK4mFzwelyaVQE0pPzPsZ6QiPwS+d4zr8nft0TJxxYBsMBBSd7smkTFPEgvJjEWB1HMfUFljsSWRvPExSJaJe4hCsUVrBNMyIF0oVMx4G+9DSfiBpQ6PeCQwesU5uWJXBnbbhMxJuW8yaHMOPOdoR169aWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291811; c=relaxed/simple; bh=0U/bcsQpieIf1bqTC2ixQ525IqpXMLQqveQUbJkCJe8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iMkBD4o078f69FqhEaBHofd7jEpe8Cf3RmUDGM9PXxKr2TU0akpUVEDRS0pD9/aelmicUxnuCExMVMbwUnWGMajqDvNNFj/oAjo1KyoN7KLHc6wFds1KxuwaAbN1DV6krPrfHjKZa9gJ6Cng71IXA77W2DL3wQCnTObDOxYo1Ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h8u/TRds; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h8u/TRds" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso88702545e9.2 for ; Wed, 15 Apr 2026 15:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291802; x=1776896602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pJZr+//quW+MQVyUFXI1nceGLIm8xDCx/CEd5g1IcZI=; b=h8u/TRdsgDoQs1LpwJdMN1k29LP/17qHsZt7OTTcMMQ0x8pF8rc0A/axyon4khbSzd xE4PJNO52zNWiWiy43CiDpbTIgvZiqWk/5PA6B30aQzoi6S3QGVadMgl1e17kogErcpB VNE9qBxmZ6Ownl7UkWCmYa3EeBwdJM9OHfbehM/LFmhAM9mYn/zsprh8Z+8NQf4cVd5c V7IcIQuu6VGMg5dmxIuNvu5ni0vsZUGEHqTSWTG8gn/KLk5+mDCaWBNJ7c0hx4r65YGd Lft6yaqhMKUUz1Q6zpRpbDj0y0FfvS2RzQbfIfcBXBcw3JAYiAtqXVDKgOXPWdKNM7+j egVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291802; x=1776896602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pJZr+//quW+MQVyUFXI1nceGLIm8xDCx/CEd5g1IcZI=; b=UKbEX+xhp6ajHTSixKu3hxtXSt3Q/70nVtfD2xJIQgOpzSextdnwaf2cA1mUGhuQWl 6xvjBGJqU5uGyF8bvwyGYBcHfe6JZlPbeDvJBuk70YUVNfqZ3sP8RzlSmeqrAYCIUZSO dceUA7TxwQWlbttnMQXBo01dFJDgfnM4Pk7CT9NFJ0inbz5s4JRmPL0I9np0OVPN45Ti D/qNiVXaha2Vg63jUZHhcyy1+KvgIK8cXsDf3nZJQd8BJ/TGzNxAZIq9joj8gg1LqwoM DvKGbeUpjhuMPl1KhiPaW8U3aFpmpiAZv/CX86+b9JMaBdARyErv+Sw/jNrqjlg/uPJp ty2Q== X-Forwarded-Encrypted: i=1; AFNElJ/C8TBAI4IPvc9+58VoLlD4Lskev+WGL28Az5EglNYMPd51l6IZ2SEMLMefkBTToec0krKvNTuio6anbLE=@vger.kernel.org X-Gm-Message-State: AOJu0YwrCWvVvOe7wy79fsEStskyKP2+skNE0b2Mz0GLC2nTBftKn5TB psd1pxo/xfh3m1XDKGcWndg/2dUtib4tFsRFCjAVV0O/w+nbg6tMHGM= X-Gm-Gg: AeBDietgckhrKb16yTb9H7/hdkxhRJPVAD1I5FNLbzkCk1jFmDiLkapIiSkTsU6Gl90 Wv/TryMqZz2Uil4yBObXinyQWTskzAyfAksyRl9kNC9SlPu/GcEVHWaPbgPTOBpuQfSAnaEn9/i lePfpDemfkMJE5IiaDJkCeGWjFC7w4Pae5Jj0AdebXO0S1LEMbOAEi8svprxfALVSmo9TWK+to9 0WW+P0XmeoJDx7ncfndIeBGh4Z9vjm2vDljGFokXi5FPuCPAbsezQHavq7Lb0EQEkrLRTJIlu9O Dvkmav8rvRUGb2eXlpS0TaWXVzJ1pw9PQa8WNl0/TQLYQk6jZ10TX3RAjvqMr284H5HLDMY6WPo M/ALosC7T3yU7c338cCIhVjTr3cxNNoyd8gzwPc+Hojuq1ZV9mTgc3eFVGlU45PAlnDq4veqKGo IKldc= X-Received: by 2002:a05:600c:8207:b0:488:a4d6:69ad with SMTP id 5b1f17b1804b1-488d688dd1bmr317940585e9.27.1776291801962; Wed, 15 Apr 2026 15:23:21 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0e9a742sm28702585e9.14.2026.04.15.15.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:21 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] wifi: carl9170: fix OOB read from off-by-two in TX status handler Date: Wed, 15 Apr 2026 22:23:18 +0000 Message-ID: <20260415222319.1538389-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222319.1538389-1-tristmd@gmail.com> References: <20260415222319.1538389-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The bounds check in carl9170_tx_process_status() uses `i > ((cmd->hdr.len / 2) + 1)` which is off by two, allowing 2 extra iterations past valid _tx_status entries when the firmware- controlled hdr.ext exceeds hdr.len/2. Fix by using the correct comparison `i >= (cmd->hdr.len / 2)`. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- drivers/net/wireless/ath/carl9170/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ath/carl9170/tx.c +++ b/drivers/net/wireless/ath/carl9170/tx.c @@ -695,7 +695,7 @@ static void carl9170_tx_process_status(struct ar9170 *ar, unsigned int i; for (i = 0; i < cmd->hdr.ext; i++) { - if (WARN_ON(i > ((cmd->hdr.len / 2) + 1))) { + if (WARN_ON(i >= (cmd->hdr.len / 2))) { print_hex_dump_bytes("UU:", DUMP_PREFIX_NONE, (void *) cmd, cmd->hdr.len + 4); break;