From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C27F390C94 for ; Wed, 15 Apr 2026 22:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291806; cv=none; b=g5vBE/gGP112LiQH8Ct7jOfFVM4zaEYcNZOV1Jsz4xPyeUdupXIOR4NkHbDp7f0Jf8wRK08QEursPaslXjz3ITlkVz7rJQrOEpQPm+elj7uJQdHYVunn7Z06w+5YEzFZ2Z5LnrMpHiFaTiWNqeUTCgCPapTvfV00hByQnm7Cq+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291806; c=relaxed/simple; bh=4ow2CUbfAykWb1AUr/pjXrvkDjKzH/5bLVW7cyLSbFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NHe0F5ruVO5hPs2TFdqvJ5pp92NS+Yz6BtSFYooerZbfC3qrJOi49GyjAJJjpN5q3ZC3oJ6TDwfU4JH0MxPTohgfYTW5REmMVh5+TFxVlKUrx0Z1mtizKqiChmFV8aBu17oAq1GHmlNDb85UOSBWF6swzoThuzul0jaSrkWBj4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cXWGLxOw; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cXWGLxOw" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488971db0fdso72521885e9.0 for ; Wed, 15 Apr 2026 15:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291803; x=1776896603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VBHZ3elBfpoOc3dzAqhsGdJZlPJkyY7fwDZN5hydqU4=; b=cXWGLxOwKEPmoLB0NeMEUKOcWxC8ZgPe1SE8NpbxVM76TT/tih2AiJrDMWicIVhNwm VxobMvlwVY2XHQeTQMvEPGyKWw21BnCb/XcvMfIgQUx54UGA/YItibecU212aFuwSUH4 onTTV4OgtK8Yg0IWDYCSuw2Xv9XhQ0tt60kI93AQooD/1cAzSSILZi2qP1GMqlr3xz70 KjXY5NzJmN+UyqHw6nfZxOIONEoG1T/zyHL4vFfuPnM2GFnAim3Fm2BcArdmZfb2EHj5 rIfhc0PvL4yIlb9HBacoGzUapHeerISWGgWvWG0BONpzWar5Ehzh27BlQPbsF7jdh4Bg earQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291803; x=1776896603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VBHZ3elBfpoOc3dzAqhsGdJZlPJkyY7fwDZN5hydqU4=; b=Lorv5oaiTbG42jJ5hZgDpcSE3wnj0pIn+l+JI3OqxJBrLABasXPrIpjOYcCc8350JB GACd7MuhEukayEtVifOEJCMgr34bzAucdIAT7bLIK3NNm1X4j+qyc15YSqqfrBwND6Jo 6UPd8iGPk2aNMTNOD3/QEpJW9LrUHkb2aH3X1fH5J+U0kfw5dMdvq4I+AHaRgUE56eQa fQ88i55EKTzOfAziYE3Yifiop+hQHOoKanfrLAtqMdM1pNnJp/xuUaJyVaMBoJKpakKN j9w2CUnn+VM7oEjsD2S4JB16clEbl45PuDIHcvPVwvguPhwJvBMty8i0Cd3t2aNPYePZ tWsg== X-Forwarded-Encrypted: i=1; AFNElJ8SB8WA5QUtTsp/aJyjr4GC5B+VRPYny2i4I8mJPqPfn4L2dpz13lHHB+frpQqvuK7RefMW7k8StHAFDiM=@vger.kernel.org X-Gm-Message-State: AOJu0YwVOl8rPxMSSBweFQ6Dr8Rc5mmQJqWdqEb3eGKTAee4qPnL0vQO Ar64KUqr9EiQ44N7sMwbfK0ay2HhlmvXYXEQiV3Rd7KjUiR6KQT/M38= X-Gm-Gg: AeBDiet9CuHwjB6GeQ9JieyRSlmZTJIF60iWbhc56mwUJ5ftfVZipveBMGz4s37gdHK 7AI/K7KTDjXz2FC49/pCPOilwh9ROgAOEQh64hg1Ece3+IEDJJIYCJPXQESfF7Z+Xd9q0FreDik 0w541oV4Aprh4FRELugByv5n1x9JZWbnRFT9dLnPeHMIlZjprZUUPRLHfNFNTGaeduV1M2B9XTi cjDs+s8TTcBaDB2pElyU8gaF9Og4aSLOormHRgeWPA9LlE4/eErquJzKHU7nQVpM5+DlpxA75VZ u2+fyJ/5Lf4dGab0YmB+65M1LnXP1A4KX37K7Am7C/nAyyMYTywfHg33ZpWYac+flRMxnxLFepZ 2q+ica0U7MnxJaLph5YeH9LTPRcFN29ava+wEHvkZisDLkFKGTEwI4bTS9gdoPbyt0cKQWtWFo6 RmhtQ= X-Received: by 2002:a05:600c:8b6d:b0:485:9a50:3384 with SMTP id 5b1f17b1804b1-488d688209dmr299733775e9.25.1776291802731; Wed, 15 Apr 2026 15:23:22 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0e9a742sm28702585e9.14.2026.04.15.15.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:22 -0700 (PDT) From: Tristan Madani To: Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] wifi: carl9170: fix buffer overflow in rx_stream failover path Date: Wed, 15 Apr 2026 22:23:19 +0000 Message-ID: <20260415222319.1538389-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222319.1538389-1-tristmd@gmail.com> References: <20260415222319.1538389-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The failover continuation in carl9170_rx_stream() copies the full tlen from the second USB transfer instead of capping at rx_failover_missing bytes. When both transfers are near maximum size, the total exceeds the 65535-byte failover SKB, triggering skb_over_panic. Limit the copy size to the missing byte count. Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") Signed-off-by: Tristan Madani --- drivers/net/wireless/ath/carl9170/rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ath/carl9170/rx.c +++ b/drivers/net/wireless/ath/carl9170/rx.c @@ -918,7 +918,9 @@ static void carl9170_rx_stream(struct ar9170 *ar, void *buf, unsigned int len) } } - skb_put_data(ar->rx_failover, tbuf, tlen); + skb_put_data(ar->rx_failover, tbuf, + min_t(unsigned int, tlen, + ar->rx_failover_missing)); ar->rx_failover_missing -= tlen; if (ar->rx_failover_missing <= 0) {