From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39E3E37C922 for ; Thu, 16 Apr 2026 06:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776322324; cv=none; b=VMpct1akjLA2ALqpYbZuRGsrPxXH/67xqG7K4ekO4ag6tsHYuZRfc3QM0WFpGjgqOE3WBB/PNH/7Zyrj2acSC+cqGEaBMIZWLfLJizF2+uOscOf2UakHNJ/XropziXwdr1phHrsed0OStQGw4vwQpk12sCz2m+R4T1uY8YGDUrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776322324; c=relaxed/simple; bh=iozzvJCB2xG9A07OQoUFW3jP0cPuyJDlaZfk/DDuFvU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q0+HDqPPSbPbQ9nj0tBMz3QfsKmqE3YDpJrSq7rWhPhoze1ek83BGNm85ovZHtf0Mo/6HNSXE4loqOkIaJ6If3D24XKTxgLK2U1tEpYMGDmE5q3HJqLxBzDsDGsiWk9AVCdJ5H6haqL7OuTqWtQ6l+oxZYkViA7xwQ/UIFPl0Gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lbLwHrH2; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lbLwHrH2" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b9910707d82so968053966b.1 for ; Wed, 15 Apr 2026 23:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776322322; x=1776927122; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8S3n19q846uz8sVg+/KoKXdBEBySJwoCqjluLQZul7E=; b=lbLwHrH292p+w2z2APekwGnkuRoLDSDcZZHWUbbJvuvT8dT4uMcf1D8iE4L4S/uMa9 kJbmE0c1mr4+IgTObbYAei5Ih92327vgMKV3nfrnLXVG465hM+kHaxrLjQsoBFAl3A/J Kj/U9noYpcOp0sHB3yoynPfFMoeYX5wt5ayiNfzZ6/hIVhv+1SpsiwrtRECqmnALHoCg i9sj5GumnLgSu216NC3LIxXuCxxSCG03A/Z5GPwZ0AEdKL6ZqSKcuNJnTV8F4IK5d6yi goX5TyIlkBCrlWVWbRmU1g+yy4b/6Z4DWeKJbUYoUgNcuPNTdqX+oKL1nAT2XbQMzeSK K1vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776322322; x=1776927122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8S3n19q846uz8sVg+/KoKXdBEBySJwoCqjluLQZul7E=; b=AE5BFvZRbzPmU5p4WfGX53B/UhEsixHXbjbzQW6eRCsKUBg0dDYzEc5SgkKnv0qp1p rJQgCtkq0HxNl8kwJ8cmazyZ/hqLbM//CsvjEFzmrpMh1q0ZhB9HPSyxZ14ZzLZCaEQw e96KeYBncaXhn5npB2W9tnUT6yK1M6GIc5YKd6nDkrP0BIzhNCWygNaXGoT3RGshkey9 MIgOy8eTxaDUy1eedVIsflOq0jCnDqY/3DwloWAelZLvkZdQE9yjYDOR+tROeeAtxVae p5NFqoh3rjUDDGH69OAErYZgmgZqNkiQ9CRqxHzXJK1Ez99C+/t+PVwngWkntgKtwZ2n brGA== X-Forwarded-Encrypted: i=1; AFNElJ/wl/yJtmLWd0CwUR/IoS65NfbyAF9/IhtQEAmoOtUhSREyVyPUjyLQOT72K3ksgg0tqHGAlOiwkIMprrc=@vger.kernel.org X-Gm-Message-State: AOJu0YwzJyK4Kbxl1smKT0apLGLuUqUwvd5iRm8iH3ATQmY+9yLEt8MZ Kzm4sEdkamPQRBN/rnh4rxUx1vO+5JMOCtJ11OGfaknaGY1WfKUE9knq X-Gm-Gg: AeBDieth5l4Zia8ZMpeGfJ/OeNS+1umly3hfm+MQMJZbjdYahX8feLgrjkpZwqixNGi NytSA1U83issTNF1Tk1NmBbr1revk8VchuqjVCFdcZeYvx5mzYreujr7VZXYAC/saoR2kZuFxVi szrnFkK06FEpNEftDAfW42TfhXTZL7jJP8ojxx2rA2FTPI/oyVrpWY/35CgJNjCugQNJAuwF8jI MsfTlUMEoiky88dY/BMdQ6l4mA1p4dF44FZ/Zy7buJA62jtXlpbKiKYjagkdwtom40YcDEgSNxX EP5Bl6O/SNyFKhcbobGUt9x/jUKCkxcUQ0uJA59Fcz8D6ar/U8Bw4ampTVhTUI/MokFxLrCy/uv OBTGkmXTL3FKEKbfw2yn6s+DCcFlIapSWvXvskbeCKE2dhumQZPpza8WWW47wBW9BnwlFErtnkV AJ8seRM2JcBtjNnD5qpm1YBrnio3mjJtLNsOBHIs1+V3iwqcFNiNs3vhwqK+lF6dr0oo7k8psxg KgeTaSrKfOYLVGIisAPV2vdclAdtvRsmIhVju2DXb9tMgCFUKrY/JKfsrOPu+bOpSMRm08YYTkw WiYJGHypmXplS4llmJBwKLb840nb88DTe7LkcpUtjTj86wp6T5/74LzFKvbqoQ8UNk02jDzCJ0C Lcdqe05Jp4Mm0wA1y4w0tGdEuSWyLeahMvddLciTu2gp2/zuvmS5Zjp5mZXWb8ZvvYDLN0eGlMk 5LBudN3xk= X-Received: by 2002:a17:907:3909:b0:b9d:3a9b:a836 with SMTP id a640c23a62f3a-b9d7297e220mr1270489666b.30.1776322321150; Wed, 15 Apr 2026 23:52:01 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-a.c.od237066db22328bb-tp.internal (119.230.32.34.bc.googleusercontent.com. [34.32.230.119]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba17341a8e3sm132530066b.6.2026.04.15.23.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 23:52:00 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko Subject: [PATCH v5 2/2] iio: frequency: ad9832: simplify bitwise math Date: Thu, 16 Apr 2026 06:51:18 +0000 Message-ID: <20260416065118.1299-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260416065118.1299-1-joshua.crofts1@gmail.com> References: <20260416065118.1299-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts Reviewed-by: Nuno Sá Reviewed-by: Andy Shevchenko --- drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index fbcfdbd398..cd7c7727f7 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -111,8 +111,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS); + do_div(freqreg, mclk); return freqreg; } -- 2.47.3