From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCCD92D1931 for ; Thu, 16 Apr 2026 07:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324438; cv=none; b=UCist0zYKXEnINriP6MLuY8DXUf7gdW+kv1mNtNzwPdpAHL5cl9DAhoWI22WdA5tZUNM7nKhSEpHcsk7M+0w6eyC9Vt4yuHPJ/z2eBs5Qp3i7SJ/y84cDw257jq933Gnv2AVVC5ldzIaZ+YgxE9k6Xs5UYocFPtdJfIeCDVrGgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776324438; c=relaxed/simple; bh=ZhMOLgpHN3yGIaFbzkPMqmq8a+N6nFyZrLu0eAaI2vs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jvrIUFBX1KxhM5UC+UvQsnCIMrp4DwC1TUyNCAkNiRPraQOklMSxg6H2HXZWdAPLkwj6Vjoq3UhgdZ7piRZ/fA2IfnQ0xgQR5as6edlesbDM1ALwwvM1AdWBWZRaanyb+64EP7w5YxCAGywJwlZfGslmFuvJL8hd+BtNdneIa3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=barre.sh; spf=pass smtp.mailfrom=barre.sh; dkim=pass (2048-bit key) header.d=barre.sh header.i=@barre.sh header.b=mMWEOjbC; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=A63FBYPt; arc=none smtp.client-ip=202.12.124.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=barre.sh Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=barre.sh Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=barre.sh header.i=@barre.sh header.b="mMWEOjbC"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="A63FBYPt" Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id B4AC11D00276; Thu, 16 Apr 2026 03:27:14 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Thu, 16 Apr 2026 03:27:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=barre.sh; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1776324434; x=1776410834; bh=RK9ZLoaLKywcyvi9A6tiR /lDfk5nhl6XccwMuMNUmYM=; b=mMWEOjbCrU1LcdzXl7Z2QLPXwOrJE+V0cW406 NuzBtTnYzI7AKxwvUvc49FZGW3NQbYVZrB2CyUHYbpHvXTMVPQ0zXRYMTWEDNs56 upibv0nFzi6tXysHXIwRQYEFvX5cCx+IYjd3ZX1KS4s+WbPNcyuVXg2TXMslg2wi Wfk6Ov48j6YO2Aex47hg1H/L3hYqiyrZQoSfWQ0fXT89YEwn2mWdKY/FvxBbdDIx u980J961+Wc0Vod6wTUQUZtsQm8XQakvoCmQeHsH9PfXbyxYdX6BlEeQmISMIG4f veFriNVftUH4RDllel3/jYYn7rPqGz1B68vnBnYnf24DfS7ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1776324434; x=1776410834; bh=RK9ZLoaLKywcyvi9A6tiR/lDfk5nhl6Xccw MuMNUmYM=; b=A63FBYPt/Hc9lpRKHeNCzVfFa+1TLb2bL8xP1fiXK1UI9aBmxvb BGIFylqWRTNsMWac4DN3ovhGAfrSu6PXhamYIB35s0L0mY01uEtmujJNYaRfK656 G2m8XRlyf4W73uvLiyn8LKqYKNSKNXLtghNaPOLMp8d/UzjRCtAQhKj5C2HR0fPs BU0YCNnznv5urEpOYcOu3CHV1diaBQC80484YYpHAISAZmBSjx577KTc/zWsdEoS +bI68StifFz7LzZfi06ZI1ugHiVNx1YigQ5WEc33Q8LjSiU6y/ZQ+pdp1rf9NJOE w7F18hS5yROILbcIufbIQ13S5UGopkZT6Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdegieegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekredtredttd enucfhrhhomheprfhivghrrhgvuceurghrrhgvuceophhivghrrhgvsegsrghrrhgvrdhs hheqnecuggftrfgrthhtvghrnhepueekiefggfelueeihedvtdfhvddutdejfefhueevhf ehjedvuddvgeevkeehgffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepphhivghrrhgvsegsrghrrhgvrdhshhdpnhgspghrtghpthhtohepje dpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghrihgtvhhhsehkvghrnhgvlhdr ohhrghdprhgtphhtthhopehluhgthhhosehiohhnkhhovhdrnhgvthdprhgtphhtthhope grshhmrgguvghushestghouggvfihrvggtkhdrohhrghdprhgtphhtthhopehlihhnuhig pghoshhssegtrhhuuggvsgihthgvrdgtohhmpdhrtghpthhtohepvhelfhhssehlihhsth hsrdhlihhnuhigrdguvghvpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphhivghrrhgvsegsrghrrhgvrdhshh X-ME-Proxy: Feedback-ID: i97614980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Apr 2026 03:27:12 -0400 (EDT) From: Pierre Barre To: ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org Cc: linux_oss@crudebyte.com, v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, Pierre Barre Subject: [PATCH 1/2] 9p: use kvzalloc for readdir buffer Date: Thu, 16 Apr 2026 07:26:18 +0000 Message-ID: <20260416072619.14241-1-pierre@barre.sh> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The readdir buffer is sized to msize, so kzalloc() can fail under fragmentation with a page allocation failure in v9fs_alloc_rdir_buf() / v9fs_dir_readdir_dotl(). The buffer is only a response sink and is never pack_sg_list()'d, so kvzalloc() is safe for all transports, unlike the fcall buffers fixed in e21d451a82f3. Signed-off-by: Pierre Barre --- fs/9p/vfs_dir.c | 2 +- net/9p/client.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/9p/vfs_dir.c b/fs/9p/vfs_dir.c index af7f72abbb76..487c177aae38 100644 --- a/fs/9p/vfs_dir.c +++ b/fs/9p/vfs_dir.c @@ -70,7 +70,7 @@ static struct p9_rdir *v9fs_alloc_rdir_buf(struct file *filp, int buflen) struct p9_fid *fid = filp->private_data; if (!fid->rdir) - fid->rdir = kzalloc(sizeof(struct p9_rdir) + buflen, GFP_KERNEL); + fid->rdir = kvzalloc(sizeof(struct p9_rdir) + buflen, GFP_KERNEL); return fid->rdir; } diff --git a/net/9p/client.c b/net/9p/client.c index f60d1d041adb..6d9b9054841e 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -765,7 +765,7 @@ static void p9_fid_destroy(struct p9_fid *fid) spin_lock_irqsave(&clnt->lock, flags); idr_remove(&clnt->fids, fid->fid); spin_unlock_irqrestore(&clnt->lock, flags); - kfree(fid->rdir); + kvfree(fid->rdir); kfree(fid); } -- 2.51.0