From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63CA63EDAB5 for ; Thu, 16 Apr 2026 19:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776369236; cv=none; b=SxwCxh7eVJ71u+wwoaLRLvQSUtanpwlAt52Vmgp4z9XGbUZN5MvPZeBn0rGDWjw3wsN6F/Jx8ezYoCmhLpiU0iVXpTcwWg2oDEWkwt5u3Epcm7cuzLB//v3/XvhxBJzoSDk+YuyxitDMkryUIj2d66UxL7djvT5dGnP4ApoE1vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776369236; c=relaxed/simple; bh=6Jrg7ZEu3ts+xEI6yiDMGIHHp/99b5C546RiAMKQIos=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KV2l2OLJVdBjJBNgdzEnexlhY287b/k+FqyAj4yO3RCSMD48x8aMo8nFtjazmKn1AKddpDDHmg5fMVBV3DykgoDVjVCFaqrSm5cSp0lwgKf5OlLYvjI73X+yZ8dYlK8WAXNKMhqR4uG1zS5hFnDdvMmDh7I5fRfnTv3gPZd531k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p8O/lCYb; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p8O/lCYb" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso84295885e9.3 for ; Thu, 16 Apr 2026 12:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776369229; x=1776974029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rg+S9q/R/3SeDF5gi73CV8qTEzLqBwSJAMbj9sVqfDw=; b=p8O/lCYbCGW+FT4zHSHaP1A5Q5lBcOiyZY9HiCQlbrmyBjpRYC3jzicy1aYqAk0cNd g72dfIXYeQKhYkwYze35lWYQBA//jL0+ZNngCgFVknUNk0QNIi3366huAke83JWlXp9K QBbeOdKEC7kiNYsWTSSwDtw5D326EXylmUueDz8Or+zssrfi62U0m8VOA+WnUDCyaBhj WfB2g9TMSjirOQs1GAC+mxaU76REQWAIQ4LeHLpFQ7oVvv9BHr0haqC9B6D3VilbWnI7 C84WYfQPAc5kle2AvIw46qaoQf+nqDNO5rqKLGxY7C/vtuhkG+Nz0u0SOPCFhUv6uj1+ 7jVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776369229; x=1776974029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rg+S9q/R/3SeDF5gi73CV8qTEzLqBwSJAMbj9sVqfDw=; b=ZVJiPnyrEKkGR4BlSj/iB3L1N22g+HSzR8KZwYXe2Zu2MILTCL9DSH8y5x/dj0Wsvq nRKOCq0cwT4fFnWb0euMXWr/d15upsbeOoLVgkOIcw9HfDh5/CHYQwmLcToab2KLlbLO lBZLWL2ucmKo8HjQ4fCOuwdiCVJUqpX9cnapODbambwtEdFB9tR2l/v2R4tqSnSNHMm6 B7iRTYL9Cl5CwHehXon3B+nPeccBBOAK/CVvloFFik0QtUp8jqdh0tg8Hw2WqW6+QP9U HDyh40yFMwHTTP5h0Nk4bNz68lculzPuoz9XljL92Rzy7dEIpd3iXGB69PPucldrpYwP 21iA== X-Forwarded-Encrypted: i=1; AFNElJ9FjI8cNwhe2y5/pmNcwDRyz8s6Be1k/g198gJV6o7f3yWvdnDstMMZw1wPf3NNHHz7NCenjv9pORVm3+4=@vger.kernel.org X-Gm-Message-State: AOJu0YxbVOdjfoZcti5Cd+b4PezbvCUcoXWQGEWxKjZvPGPO4TrOzTEv 3Z1zXbA6bguX/XDtSi7ma0CndYlheI2S+3EzvjB76d6iUru1NXTZUGIz X-Gm-Gg: AeBDietYdRSKsiE22IDl2qgPJHHtmN3QZAm2QbddiTwgVZK1Z8easwQO7FbC46vOQ5p CrFLY9dISUhSFALWplZXq9un4EvMjHdGJ2GaD/i6HBb1ZuDDnRjcw2qgxdIxNou/cRhjOx9c8R+ PgeJ3TsGUlziVFzWQxWQ3YujUPfloEQ1mtuATAfeBYoK4klg6HAKg2ungSk7ubOshr6FvEbhe+v qhsB7imfRu1gZuX+LoetwlyRwPH7vzFdIT3LmloFAjaOG+Zd/PlR7wGokmahImUtK99BEzn2MBe U+UEn6m1L8j48Zg9i0YKLGf23MFE24ylxgtdSpRy7glqIy4xO2geBXeNAhtGc+2aY3EJLtmF+tc RVCBXR0Yc6Wl1IojynOqPEfSIBqXRIeGXX2zA+C0rVU8tUzmXszIwznUVcHNa83Sis0aL9/c3j6 tnvz0VOfbZQpowHzoanPhWO1yiMEJ6 X-Received: by 2002:a05:600c:c09c:b0:485:3423:727d with SMTP id 5b1f17b1804b1-488fb78c1efmr80745e9.26.1776369229270; Thu, 16 Apr 2026 12:53:49 -0700 (PDT) Received: from moxi ([178.134.243.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818e51sm125156685e9.5.2026.04.16.12.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 12:53:48 -0700 (PDT) From: Maksym Pikhotskyi To: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, starpt.official@gmail.com, straube.linux@gmail.com, sameekshasankpal@gmail.com, arthur.stupa@gmail.com, luka.gejak@linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Maksym Pikhotskyi Subject: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Date: Thu, 16 Apr 2026 23:53:37 +0400 Message-ID: <20260416195338.324428-1-mpikhotskyi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260415184727.285753-1-mpikhotskyi@gmail.com> References: <20260415184727.285753-1-mpikhotskyi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The null-pointer-guard was incorrect, returning _FAIL on valid pointer. Invert the guard, so it returns _FAIL on invalid pointer. Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check") Signed-off-by: Maksym Pikhotskyi --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a00504ff2910..f467cb5b1dca 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) if (prxattrib->encrypt != _AES_) return _SUCCESS; stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); - if (stainfo) + if (!stainfo) return _FAIL; if (is_multicast_ether_addr(prxattrib->ra)) { static unsigned long start; -- 2.51.0