From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CC03D093A for ; Fri, 17 Apr 2026 10:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776420001; cv=none; b=U9JV4qSbhkEeWNc81v909qyq2oR3Bz3qk+cKZXSW2RFGuaV4JHMhgbuocsQWBOpR+9SjzZczBpv+xoGke/grQ1KYG1vkRWbAynyCXFWo3VsYb8u9U2//DwXifIVngM/YkpebMH2vS4c9YR458DsWNkFxWTr6TWa96WYg8I1y1lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776420001; c=relaxed/simple; bh=+4oY7FDRo4pZ5d6629/VrBoiZSHU9tXpRl0gizje1Iw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EdMORVoqm+a3GKman0+tRTlkuEYhK63G4333c29k5SVTdLhC+6PV0Q3vPFG1/tIAt1RvlIZCCitoMgADuJl5T/hNwj39Hl125DC5V/s6NcRYJ3KrQo01wabhfLKZOGCvmk5RWLq5lu8xpFoZhFtYKJlL6UsIdzi3eg5wTF/esnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hGN2F/sm; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hGN2F/sm" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id E225C4E42A24; Fri, 17 Apr 2026 09:59:58 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B7CD460497; Fri, 17 Apr 2026 09:59:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C7231104609D6; Fri, 17 Apr 2026 11:59:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776419997; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=W2YfTCcPWgbWc/+LuGhpwxFltKZQkgXoBvaUQKZY/rc=; b=hGN2F/smQASiiY1sfC78bWf86qK/V/Ps4dIDy6wIixlKZjgD6pG9/z6q9B7SHrkQBKjRCt knpfgGtSkCeDFpY1u8VFWgftsXHFFLTuOLL0tV692eBLLRozo9wXN5/qGUiXEGzAfTjvHU BwZz7pfR9qZHK+D0Dr1UPTR8R9AnTgQugyGL0v7RRoAN5Q8KL82EpIQl9icf/uPXZ4ILSN rD2iU5W/53eV1OBc0KHxQqmYhbWMkit3WL0Lvfntu5Dckpq0EBzj7yot5gO72unI8b6rl1 4lEbEu1G4R5naLO/GCtLm+T1Nridphw3Wed52Rkxxne7E3YWAH2gB8UjtBGLUA== From: Luca Ceresoli Date: Fri, 17 Apr 2026 11:58:28 +0200 Subject: [PATCH 40/41] drm/rockchip: rgb: remove now-redundant call to drm_connector_attach_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260417-drm-bridge-connector-attach_encoder-v1-40-67b8b8fb872a@bootlin.com> References: <20260417-drm-bridge-connector-attach_encoder-v1-0-67b8b8fb872a@bootlin.com> In-Reply-To: <20260417-drm-bridge-connector-attach_encoder-v1-0-67b8b8fb872a@bootlin.com> To: Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.15.2 X-Last-TLS-Session-Version: TLSv1.3 drm_connector_attach_encoder() is now called by drm_bridge_connector_init(). Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 5c0c6e2cc28d..add3123e5ce7 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -162,17 +162,8 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, rgb->encoder.crtc_endpoint_id = endpoint_id; - ret = drm_connector_attach_encoder(connector, encoder); - if (ret < 0) { - DRM_DEV_ERROR(drm_dev->dev, - "failed to attach encoder: %d\n", ret); - goto err_free_connector; - } - return rgb; -err_free_connector: - drm_connector_cleanup(connector); err_free_encoder: drm_encoder_cleanup(encoder); return ERR_PTR(ret); -- 2.53.0