From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE31335F5E4 for ; Fri, 17 Apr 2026 10:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776420008; cv=none; b=h3mpyUiMAoC0zkBbsu2ioaqG+76qDDUQKNSKFI5j2HX7IKsS577kL3/jDscR+tJmlQwnZ+xSYP5s9+3iqUUWgXO1MBknkwB0J4mogTGIc6Ez7wXzJ2U7xoSIoee6ZM4NY1hDg6zR7dmsxCZMneSugqBNMYZNqE+YZNC00+Pyj8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776420008; c=relaxed/simple; bh=hck6YasqgCC3G7FLdbUeNYq1yVL9mUMf4lYXyPnUGSI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NwrioUGBB4UDO2kwOIhul3b2MUU7vfMRuc5kxMScRbbHk6jh/V3k24EK4HS4LuCgh8UgVmhuO0xR9D1wG5idKGrLGKk2oervWfyOaAfei3FOnX+uKCJ6huE6Nk3PXjzXq/TDetI8/HzV5qW8oCC/054003tgcdi1yeYE/LSn8rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GRtkZLVd; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GRtkZLVd" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 552CC4E42A25; Fri, 17 Apr 2026 10:00:04 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2B31C60497; Fri, 17 Apr 2026 10:00:04 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3CA4E104609D4; Fri, 17 Apr 2026 11:59:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776420000; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=KGCHQISz4jze2O3gZozSUpCf+02kxnuwkXhAGX81w4I=; b=GRtkZLVd76iU1kdJ/z2LtSXXpAJl4xH0QHFI2A+gWoBvFfDM4xG9eEJl5zkImHnvoxNvTV pWW5tJbi7v8GP6S32ym1yPk63iJjU/XMEpsNJtwAB5EPlaQ+lVJybfqazVKD2skjvjxmBr 3/YNbJmqgUNeK2luuISO7POq4VQyXReokWRMiz558r216aZgVEmd0uKqB3jUkV72vKJ4M8 /xnbbAa3OKhN7B2H73jJfNKcirzQyQcbUce8j7hGWcP5e7FV9CpBpxt/CwNlZ9hMnNBOgJ WZZNDDDm8bD424tp6x8j3z7IlEPWaTkLCBsStXpatunqia5/Kk+N7a96Kmyn3Q== From: Luca Ceresoli Date: Fri, 17 Apr 2026 11:58:29 +0200 Subject: [PATCH 41/41] drm: renesas: shmobile: remove now-redundant call to drm_connector_attach_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260417-drm-bridge-connector-attach_encoder-v1-41-67b8b8fb872a@bootlin.com> References: <20260417-drm-bridge-connector-attach_encoder-v1-0-67b8b8fb872a@bootlin.com> In-Reply-To: <20260417-drm-bridge-connector-attach_encoder-v1-0-67b8b8fb872a@bootlin.com> To: Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.15.2 X-Last-TLS-Session-Version: TLSv1.3 drm_connector_attach_encoder() is now called by drm_bridge_connector_init(). Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index 5f460b38596c..866afe805e6f 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -596,20 +596,21 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, struct drm_connector *connector; int ret; - if (sdev->pdata) + if (sdev->pdata) { connector = shmob_drm_connector_init(sdev, encoder); - else + + ret = drm_connector_attach_encoder(connector, encoder); + if (ret < 0) + goto error; + } else { connector = drm_bridge_connector_init(&sdev->ddev, encoder); + } if (IS_ERR(connector)) { dev_err(sdev->dev, "failed to created connector: %pe\n", connector); return PTR_ERR(connector); } - ret = drm_connector_attach_encoder(connector, encoder); - if (ret < 0) - goto error; - connector->dpms = DRM_MODE_DPMS_OFF; sdev->connector = connector; -- 2.53.0