From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD8C270EDF for ; Fri, 17 Apr 2026 05:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403177; cv=none; b=SYyTX6thgv94jQEf/XPSGdOI4FCsO+xLp1kFTcQQJqKBDxhrEoNkPAlCcwV9kkPmNhyDzDQwOJyElwIt5wBRR52fycUTRPvMYLJbXWSOm7ItXk3Y98mxOpKGE+3RwRYlXjTiAi7QaodEVAOvmiD26KU1iZTlBKVkXa66MaboRHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403177; c=relaxed/simple; bh=oEKc14CxgGlFPI6nZw4cLU9QkdurpHxJ3qF/ddAOaMQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J03QsmfaDvEhybIbBmQFRUb/dhNYEg0JzW+wLpkx89++dugkKWqqGLfhIAPElAsb2ThV60Jm2AoXPQw4SA+v0ugL4jYsXC2eXA85DP9enKC968pzyjJbsYE+GPP/G4DqU2k68hkmj24MzfI0+NRdhTptlKBueVciD4qfJz+FJvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ekUM1iDH; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ekUM1iDH" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a3cee3a271so295738e87.3 for ; Thu, 16 Apr 2026 22:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1776403174; x=1777007974; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wRxW6zYvrwllE5hoDyZbEZrBdGGfgn7hvku3QZyKhhs=; b=ekUM1iDHvQcJ3RZH2FvjEjnwuXNa5Wi63SQPPLCxessIk+2wnQiR4JuYkt7aI3OC73 56VGkgSs7E6i2jI10b+pVN+XBxun899YtF2KCm7sCtbaIow0/zuJNhS9rNZ7kbOHx+T3 cESaLP4zhqiIcKTT6uQRO3xl19qIulKW5bHnU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776403174; x=1777007974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wRxW6zYvrwllE5hoDyZbEZrBdGGfgn7hvku3QZyKhhs=; b=G2oV1Dtv3ZcVGfFxzb6vX/IxAj3taCvUtrU38LW/c8JO7PKPCObKsPqMuBcuN30TjI +zadL+aAmhfVXjrywEGNMpNixgmUzIljK04xYWeL5aIP2DfadWSviRTbE3cGYbx8UhWA YRvN6PGNallcg1Jxya2+D0ghEYpH1YGjOweLLAwcdbwJnICufkNGZs1MMEwcWqR7ma5H l3XjSu03R5+/m7JNasEm30qQ9WkbiitPNvtI/cx6Spf9iiPS2peqoosa+D0yZHLUBEDV 0RZX69YyuVO2nv9KJEr/AGHIyQ8U1VLZ443mS9gC+IVfEI5ldet5ORQ8hb/E9Ykry5yt rNgA== X-Forwarded-Encrypted: i=1; AFNElJ93L2x/rnb0uclJ+3xyj1LS4HWxPq7fK28u1oS791gz4aFNIjhLkwMx6R3TAud90tbGgA5UJkZhZl0Nz24=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj+L0kxdmnxTEB6EpyZC4e4wn2n1Xg+rF2mNVjSwe94Ibgpsuw 8s9zrNTgIF3DgBwMy87N8l3xqIHI+hxcLcoCu2rqFwpJZpvCNTSJSK9M/GzINNkQWw== X-Gm-Gg: AeBDiesPN6afI1Z579eL8/YcP/ea1Y+KuZc6lLF+uZKHRQBocbP5Et/HFZmNpB+FpJt 37IfT04sAonYMgT5Es0LMO0KSmAOi/CVcAi2iL8b0W2glOUQ7YSLNfyGAfEx2cDJZ5h2CGuVYjs tiUB/UFUgTB820sHYO7CqtlJ/nx118SqIOQOVlhFzo0xio1XRzWdlUJd9MSaerpFc4DjWthzlMk DnXzxd5Es563V8CyPdMDi9Yai7SmWOMRYnPMV4W/wofr/EC/PSQbgrWC+Tq5PBeo0jQA2f0r0OA wFQivE39iaJBm4eBY+vYAhKcE62qhOwMmpCX4zzFrd7nbbYv3oWkPsa5LL0YiXLw6ZhOltXl0kP pb1MMb1X6Dz0fg9z3koRvcoKAIRw6GzEDxzaKP0jxy3O8e4h8Cnst3pziTYhJw+/LboQn/CvV1O ajhtH3Db2nbnf1IVNDufqvAUeNfLlJQcefQVpXbzBBScKP2KS3tNANWeWL3CJFk2/AO7abNc0LU SKXxn/RPY7YllmFJQ== X-Received: by 2002:a05:6512:3b91:b0:5a4:9a7:7e66 with SMTP id 2adb3069b0e04-5a4172faa04mr362429e87.45.1776403174365; Thu, 16 Apr 2026 22:19:34 -0700 (PDT) Received: from ribalda.c.googlers.com (52.163.228.35.bc.googleusercontent.com. [35.228.163.52]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb4f5035sm1293491fa.4.2026.04.16.22.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 22:19:33 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 17 Apr 2026 05:19:28 +0000 Subject: [PATCH v2 1/2] media: uvcvideo: Do not open code uvc_queue_get_current_buffer Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260417-uvc-meta-partial-v2-1-31d274af7d2d@chromium.org> References: <20260417-uvc-meta-partial-v2-0-31d274af7d2d@chromium.org> In-Reply-To: <20260417-uvc-meta-partial-v2-0-31d274af7d2d@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Guennadi Liakhovetski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.3 Do not re-implement uvc_queue_get_current_buffer() logic inside uvc_video_complete(), just call the function. Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_video.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index 271c246a02ea..5d45c74c6041 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1704,7 +1704,6 @@ static void uvc_video_complete(struct urb *urb) struct vb2_queue *vb2_qmeta = stream->meta.queue.vdev.queue; struct uvc_buffer *buf = NULL; struct uvc_buffer *buf_meta = NULL; - unsigned long flags; int ret; switch (urb->status) { @@ -1730,13 +1729,8 @@ static void uvc_video_complete(struct urb *urb) buf = uvc_queue_get_current_buffer(queue); - if (vb2_qmeta) { - spin_lock_irqsave(&qmeta->irqlock, flags); - if (!list_empty(&qmeta->irqqueue)) - buf_meta = list_first_entry(&qmeta->irqqueue, - struct uvc_buffer, queue); - spin_unlock_irqrestore(&qmeta->irqlock, flags); - } + if (vb2_qmeta) + buf_meta = uvc_queue_get_current_buffer(qmeta); /* Re-initialise the URB async work. */ uvc_urb->async_operations = 0; -- 2.54.0.rc1.513.gad8abe7a5a-goog