From: Avinal Kumar <avinal.xlvii@gmail.com>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
neil.armstrong@linaro.org, dianders@chromium.org
Cc: lumag@kernel.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch
Subject: [PATCH v5 2/2] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions
Date: Fri, 17 Apr 2026 11:48:42 +0530 [thread overview]
Message-ID: <20260417061842.66631-3-avinal.xlvii@gmail.com> (raw)
In-Reply-To: <20260417061842.66631-1-avinal.xlvii@gmail.com>
Change the panasonic-vvx10f034n00 panel to multi
style functions for improved error handling and
remove redundant error printout.
Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
---
.../drm/panel/panel-panasonic-vvx10f034n00.c | 24 ++++++++++---------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
index 3c3308fc55df..d21d93a0700e 100644
--- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
+++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
@@ -44,14 +44,23 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)
static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt)
{
- return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi);
+ struct mipi_dsi_multi_context dsi_ctx = {
+ .dsi = wuxga_nt->dsi
+ };
+
+ mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
+ return dsi_ctx.accum_err;
}
static int wuxga_nt_panel_disable(struct drm_panel *panel)
{
struct wuxga_nt_panel *wuxga_nt = to_wuxga_nt_panel(panel);
+ struct mipi_dsi_multi_context dsi_ctx = {
+ .dsi = wuxga_nt->dsi
+ };
- return mipi_dsi_shutdown_peripheral(wuxga_nt->dsi);
+ mipi_dsi_shutdown_peripheral_multi(&dsi_ctx);
+ return dsi_ctx.accum_err;
}
static int wuxga_nt_panel_unprepare(struct drm_panel *panel)
@@ -94,15 +103,8 @@ static int wuxga_nt_panel_prepare(struct drm_panel *panel)
msleep(250);
ret = wuxga_nt_panel_on(wuxga_nt);
- if (ret < 0) {
- dev_err(panel->dev, "failed to set panel on: %d\n", ret);
- goto poweroff;
- }
-
- return 0;
-
-poweroff:
- regulator_disable(wuxga_nt->supply);
+ if (ret < 0)
+ regulator_disable(wuxga_nt->supply);
return ret;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-17 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 6:18 [PATCH v5 0/2] " Avinal Kumar
2026-04-17 6:18 ` [PATCH v5 1/2] drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi Avinal Kumar
2026-04-17 14:20 ` Doug Anderson
2026-04-17 20:43 ` neil.armstrong
2026-04-24 17:17 ` Doug Anderson
2026-04-17 6:18 ` Avinal Kumar [this message]
2026-04-17 14:19 ` [PATCH v5 2/2] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions Doug Anderson
2026-04-19 0:33 ` Dmitry Baryshkov
2026-04-24 17:17 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417061842.66631-3-avinal.xlvii@gmail.com \
--to=avinal.xlvii@gmail.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome