From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B24A13B583D for ; Fri, 17 Apr 2026 10:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421013; cv=none; b=s+d1hJVMj3pnODyBNreA8dQyhwMkjwGRVBXJcMmFxL4pIjkxHRCIQppE+DI/3WmPZ4G0M43er/Tg9J+JcslyiYaBoCNkaYiXyKflYDAf9GXWAx0HJIwFeahXAyT/r+u/fPMluRmd89cp7N141Jw6zjoRwK5krk3gfBuGaRx8jDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421013; c=relaxed/simple; bh=Vw7D17ioAHMpV0rVIr2m8wJ9QnCWiT84kXKCxVydXYY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Bc9xgya65XVYpuPjwkYgqmrLa4abxpCD68yK/DN3kELeZhQ5OG1vnXhwoTl01jjS8L5FUl9+F1YNdKG8a+2jW/m3Mh9fIB3jQLoGXw8oSeF1hEPDdVa/KIAZ/dsymheBV/lqHI71tAfhOYMvmpDRAuGMTSOBXt7UITV1i8kUKT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=quN85OIl; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="quN85OIl" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b8f97c626aaso85973166b.2 for ; Fri, 17 Apr 2026 03:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776421010; x=1777025810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ptfzQti2l8j30duqTHZefI9tN8DiTkDmOYqUjk7fx4=; b=quN85OIlOKuPUXAPzOzDxbL7jqac0KVJ00+vj9y2iR3+K10PV8CJmhHL/dLq0BIqAJ otn8ADcVoZWV4QPkr2coDrRF1BEsN0XVXMBKphz+g+0kU61ZiUwfGdlLTv5gIDM9u4d1 ioGYfBCXJJvgZ5dGDaYkiY63kODfUJPwhgaUEG+duLBYgLZs952KAvsJnTzhSSPHoXmj A8plKhAiJdp3txpPHCwWa19xCw/zD0ScU3oGK7QyXMWjm1zj82A+HNCvUGoJWqiRZhK6 P2xESOg/gZBIZpv/fedOwx4rb6TFVofi/nG6RWABpi4Uo95TBcBwYHP3KWjTMFsD+z9Y VY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776421010; x=1777025810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6ptfzQti2l8j30duqTHZefI9tN8DiTkDmOYqUjk7fx4=; b=TEFVR7D/NJZBe730Q3JZDq2y1vMvFyB8X020UyH5UsM8tUYl7pAEiIeXlynTZmkNAv yg01NMQAIHPuYe5isaywNcTsJho1WD6ifgj9LdBDwUJuTYeGbBkdwX5BNaAD1LYgSd4P Uf86cDJCbqXrT1VsJeISYxDaZF/IYhyxSSCjK2G4tzsqBUoFO+5XyMQAaDK8qGDnXnY6 qRLBmkhujHy8CXBMXSuwuw/B2tnQmYMN/fDn8kWB6nNxTXTs6CTPpb10/cJL1AWtvW2w q+3AiQ2pRITSa5l/Ihb7rT9lAzKCPVDWuI8AC5pCjuZ311HHIl9iQrjszq77PZtmRk1R 9Xrg== X-Forwarded-Encrypted: i=1; AFNElJ/IDfWxFmAm7mXVTppsYuivR47STR17BWKJzh9W9YiSXDX4vIQnrdMxpI6lEm+yX6GSogGzHHXjEOLT9uA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxkely7cPHgCMdSrykMnF3AOYFd8UqaLZKP72zbkXT79HakY1/A VWVvdXzFjz036lvQJFU0zGIA8Xs0zE7/o3rZyHO6e9W0sXyLIxA2j2J3 X-Gm-Gg: AeBDieu6QmBJFQyqw1z/joOax9Q6wh4xdl2CRVy6iM2SlZ32T8q3vnN+rTn+Kb3be/X wLTK14wjlu7wWg74Uzm09Gx3KGPkqZuU5lTo2ByPzjB/N6izqbfDlZc2Sb4USQgfNR2sGFTk4xu 2xU2ZjNacb8+f/g3QzrN+fSfHHUT/Ykl2c5eJ+tLZ1reynLsOtzKc4yvz0JzPTowJAnpUPz3p/m wTfS4WBdOLa+eLI1YT7LRXFeGhSEitqeOi3M74OxYma7CS0ofG2K/I99U6jRFfhEO55G/rcjcl1 Kb4oSk6N70m5kzlgH5dBG1r29WqdHiVzIZBaWHS/GpWUtqRZHK3UkFB7XwsLxs3JQAy7DK4GdU4 WkBuj6mYrGPOIX7HoIafkUJq0Ey+TvKcn4RVIOJWpY4D/WPRwbjXlob97x0i0kLaKOY4gOcg0DD 3F+tntYkeNs2P4D7lXXTAA6LgaeXG/lP1C139dl+0zZ2gt+MFEuUlRCsVs5DBn06Dr/PEJQa9hN zYwJ6UzXYb0GIB+TMd9UeKuLxbBam/5QDHYRRdE3/SvKx/QZcjR0RDC2icreA5D9brz5bc4fSl2 bxsTbdNJp9YjgrDETCKumTRBLT1VH0vNAAdutRQuMvLBSnHgGBQhsBcCvrG9M+saHDrgveE8Dqt j+ZYuXVkbkddxbpd8AaHsdNzBRRSQZZ54FCkfKqmJ1Oi78ZQmNlx58eMI+bxGoWd5pO4JPDpq+D QIQpkYfGHob9ypGVlZbQ== X-Received: by 2002:a17:907:94d1:b0:b97:cf49:efb8 with SMTP id a640c23a62f3a-ba41f0bc286mr108172166b.49.1776421009732; Fri, 17 Apr 2026 03:16:49 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-a.c.od237066db22328bb-tp.internal (125.133.90.34.bc.googleusercontent.com. [34.90.133.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba455926c61sm38937066b.63.2026.04.17.03.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 03:16:49 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko Subject: [PATCH v6 2/2] iio: frequency: ad9832: simplify bitwise math Date: Fri, 17 Apr 2026 10:16:23 +0000 Message-ID: <20260417101623.1281-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260417101623.1281-1-joshua.crofts1@gmail.com> References: <20260417101623.1281-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refactor the ad9832_calc_freqreg by adding a BIT_ULL() macro instead of manual bit shifting for better readability. Signed-off-by: Joshua Crofts Reviewed-by: Nuno Sá Reviewed-by: Andy Shevchenko --- drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index c0b7852f1c..6ce9651542 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -117,8 +117,8 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { - unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS); + do_div(freqreg, mclk); return freqreg; } -- 2.47.3