From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F24CC396B93 for ; Fri, 17 Apr 2026 11:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776426169; cv=none; b=qVjMmLdoLkif+uwKf/u2Kr6SAH+B2nWRmR6c/vzOxjRN3m+p4WJVRfVKUpZVmyGSpCtN3Fhq4z7W9QJ+IJ4xNh3TZSQYjnMOXCaNre0kRQl/4yYHUU/l7paW7P93Ga709z8jVUIkdEi6n5A11esl5j0gMiibKyNa6RgPxrgylRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776426169; c=relaxed/simple; bh=2SoN076WkKPP9dslU6jI1ybrIMLHSTNOhkvnyADFEu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j7CN+YoX+YO9XS/x+/RBuBkiBcVszlFlE5WbaAlYrJX/vFA3VwT/a/L5t5xRKxL74sCSpZ6FCVZ0/EGxja+MYvkebTa1PATye2RuVifE96zT5nr6IeB7gOyc1e7U82bH6S+gQqSGM4b2h4Q20q+/icZelNKfFdHACdT2Nk+eG8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3Q+OsQr; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3Q+OsQr" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5a2967e5de4so634466e87.3 for ; Fri, 17 Apr 2026 04:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776426166; x=1777030966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIsBkEhxNk5zSXNzbm4OjEaayYLvWVn1IlfYzqWmAY8=; b=U3Q+OsQrqFj9zxxhBl6l+pnWu2fXBHRpsTivXAo2KmD6I6Fsl+1zwSkXerpJ3ipzoQ kuTU0/5BJ1Mbwxao5kHb+iisUffH5NlLjfUHdryWZMTZ69QDqvGRTyfFrEEUkNs9Thax pdwKThk8niYPRacMEtYiJVd4+/vKzs+MWoUnM8EgjHGEYQQozJUzu7V9Uby1I0hiwxcV BS+q9cNcIBMGxg0euq7sSZQzSqnucIJMyD4ML5NqpyLoQYOLfsMXGTcbxFjYJGtXcmBE NjfTjohpTdpUuWHXBxPcJqtBezN6Oa9nYT/XJ5I8EaTvigflklhEO4ukE8nuQX3INvCj MDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776426166; x=1777030966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aIsBkEhxNk5zSXNzbm4OjEaayYLvWVn1IlfYzqWmAY8=; b=dR84+AE6eK9zuw1o6HTXQbEVyRYVYLZ7dyvhC1KxwS+7kDiPBQOTccaGzkM3puWYEU lD/kRWRh9/+Z0iorwRPoPAg5he/x2d3WvlmIU/2DwTa449utxPs8vlJBxxPag+lGAHmA 3/vTuPoeNHARI4sKvurrKHRPpEP+zdkjU/33ktIQN1QbHGaBRI2mF6X1luhE9oc0uXI7 A5gtF+TOILPDBAPGQ7UBh4xuGUenUP1GbHmdT98GMMqDWcwGOEakLwElSdXwZIyzzzPT j+tB6JWG9VJrmvvHPAizVsrKjO4+CkCMkTTfJPBmbQ6d10GO4H3PeapeDZiz0NU/UKF3 99Cg== X-Forwarded-Encrypted: i=1; AFNElJ/6sf8J53hC5fGJPuTCuX1JpqDV4LZ8NhEH9qSEYInJrWlySzMHr+vWAvy9wtvbEwQ95Lptjk3Tkh8uIfE=@vger.kernel.org X-Gm-Message-State: AOJu0YwIsa2LIy0PL4SDe+QT/OoSB0AkjK2NMBu0s6sn8i2qeEjmgcy8 ZDjLwn9VVrSqYgOdNjgEHvIylEWBpXPuog0cIOuFPyNy6iL+CWViuIRH X-Gm-Gg: AeBDies+9k5zFQZf6Ldomso08IATO/yElRAT7Ku3uWo1IzvaZq8wjCyaGmQ47KSovFU dR0D09bfMYdQTMZVN72BBT1mFNM/poCbne/HVRKwUAQjmTEurx3xHEmnU1yI/ddqcDW2cJiVuQ0 bAdWRSylysUfxhHU6K1/AiKCpjXPJmrszw8KsOOaUaAzAmd9ru8tuoaj02zeZ/z9ut11973pcSm RiUlyE4MF1fYKJO2nsfu3LnK4sNMD1SmmyaFdQNaKWV4KOFJb3mzoGyV1yDXLPaAIumZuuDNZ4f c+3TmHMSLvTXJHvQQY2WqhhkSf7ozSCGkE5ilha8ExMJhzICNqcGR1KGSd+Jzyic6OjqigQpfCx eoruP56q1A8L3oblnCXL8UwMpVIdVe8GeuWJSaMOzG5Ddn1CrvI1Bjdc+cTGMF1eIN4/VWq/OXj 7KZh9OUaQynRO/2Dygb9QX1KI= X-Received: by 2002:a05:6512:3b8e:b0:5a3:ff73:29d6 with SMTP id 2adb3069b0e04-5a4172bb921mr657348e87.7.1776426165787; Fri, 17 Apr 2026 04:42:45 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4185bc672sm338636e87.34.2026.04.17.04.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 04:42:45 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Mauro Carvalho Chehab , Svyatoslav Ryhel Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 1/5] media: lm3560: Add HWEN pin support Date: Fri, 17 Apr 2026 14:42:22 +0300 Message-ID: <20260417114226.100033-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260417114226.100033-1-clamor95@gmail.com> References: <20260417114226.100033-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add HWEN - logic high hardware enable input found in LM3560 to ensure its proper operation. Signed-off-by: Svyatoslav Ryhel --- drivers/media/i2c/lm3560.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c index f4cc844f4e3c..e6af61415821 100644 --- a/drivers/media/i2c/lm3560.c +++ b/drivers/media/i2c/lm3560.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -45,6 +46,7 @@ enum led_enable { * @dev: pointer to &struct device * @pdata: platform data * @regmap: reg. map for i2c + * @hwen_gpio: line connected to hwen pin * @lock: muxtex for serial access. * @led_mode: V4L2 LED mode * @ctrls_led: V4L2 controls @@ -54,6 +56,7 @@ struct lm3560_flash { struct device *dev; struct lm3560_platform_data *pdata; struct regmap *regmap; + struct gpio_desc *hwen_gpio; struct mutex lock; enum v4l2_flash_led_mode led_mode; @@ -425,6 +428,12 @@ static int lm3560_probe(struct i2c_client *client) flash->dev = &client->dev; mutex_init(&flash->lock); + flash->hwen_gpio = devm_gpiod_get_optional(&client->dev, "enable", + GPIOD_OUT_HIGH); + if (IS_ERR(flash->hwen_gpio)) + return dev_err_probe(&client->dev, PTR_ERR(flash->hwen_gpio), + "failed to get hwen gpio\n"); + rval = lm3560_subdev_init(flash, LM3560_LED0, "lm3560-led0"); if (rval < 0) return rval; @@ -452,6 +461,8 @@ static void lm3560_remove(struct i2c_client *client) v4l2_ctrl_handler_free(&flash->ctrls_led[i]); media_entity_cleanup(&flash->subdev_led[i].entity); } + + gpiod_set_value_cansleep(flash->hwen_gpio, 0); } static const struct i2c_device_id lm3560_id_table[] = { -- 2.51.0