From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58692373BFC for ; Sat, 18 Apr 2026 14:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776523677; cv=none; b=AtGv5dJlqVnbJeSSldwkmF3rGZG5h9nhAFtzG4jxzEhAH84NTfPvy/UkRkhLgDSwSxj5MM+0bj0dlE7Y0IAeUCgzuAv2ae+FHHIJzAILokJOMH4KdyIMu0vTjZxQ681A3GAcOWJkVvId/bL/OHVReuFRTIRvrRAbe2wSCG0NFaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776523677; c=relaxed/simple; bh=l6nManMeR7Jg1MhkwUdhEH7FHLLqb5lCwS/P/91//S4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o0K4a1YH2EhV1hK+CR0JaDuWFomFDX4FycbcwLckOnHqxpmvH6XuYUAEw1AGp+Vrbv301noX7hgF4AsPhNaXaSW3Wq4IgRxJALe+Qe97oWVNgRxS9Imb1PL7RG34XEYIPBkFlRC8wqJ4gJPHlrqfcRagNJaetHoT206T8d03rq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HwX/3Dpa; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HwX/3Dpa" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-59e5aa4ca41so1606287e87.2 for ; Sat, 18 Apr 2026 07:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776523674; x=1777128474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BjNK/Cg8+mI3iZeqCtPR1pHEgjWGhrHjIwJvfOxtDFI=; b=HwX/3DpampM+CMwhED1aecYg/VaICmqO9bw106y9Vw42qmuqKkHg/aZ3eTfmRy6UxS EdYjzv44WxovYglJ+muO6qBfy/bv1qEPgU2urnuM3pwWO7hjhjIMaoKHy1COtqH7SBoH EAToDzRq4edXme7kdhxYP30rwASQ+eo8T3qMbctuMTk4OI4VKn//6Uysey0//aEMZx7b lRBgKcAuRMm+e2GJIh/gL2Xh5K3YzpbI6bLaGlmSAW5Y6mjlcu03StySMyce9pG/DNVe YN5WysbE8B1Gw+IjU7UrXY3pWs5dcGY7xxCjC0EA+BtV+2DxIwhb2Gtbaib3Po2olVec dCYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776523674; x=1777128474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BjNK/Cg8+mI3iZeqCtPR1pHEgjWGhrHjIwJvfOxtDFI=; b=Bk5iQ85P82E056iOADPYy5B3Zx7s2tIXoX2X1F8LwoXV2wi8vRb1ZRjhABvz+FvuHr UETGoFS18ZPj5XL/LzE5i4nOaoAun1uK66cMCVGDlhHq/WnwOPnA1teACjjdgCwZo5jW p1GQb/Nl3bA2Dno/AD7nTlEwHYIrJmtEFj0gDIG4XFx4ARQFYR+Jg/1JT6AbVKHL154U lRFM+e/p10KxWemcpRxR8qgI53Ql5Je07bFx/7fIuqdrsGotx6/+sQcrGPyuLuQGOlo2 fMX14YCe+AoCLhwNAFJIycbVYRE4WDelig2SGuzXeFU3xnUMf7NJeb6LyLpnzOz6nfQT 1MhA== X-Forwarded-Encrypted: i=1; AFNElJ9KcWL1uS7Rob5F46WJ4tJGzX4Yr1AqIsLSlvrqHvTIdqyYpySjSF4rvS7+Pc0UHV+0AnLZ5I70iSB9dqQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5G8Z3ol/BIiWflDHG5UTf8uJRURJX5bbqMT6tWM0TQCUWQo3s rCuVkplsmj3zW6Fee00/yfsSEyJYReTC/rRDvre80Tn21GE8A9DreEJ9 X-Gm-Gg: AeBDiesKmTg9hgrkr3VLymWI4+bf2/etQrkusuuW6m9bn6mfS1bl+id+dcU1ySO2MYM Arw2uc0QkzgHY9nHjJrR1NdLfXFFMDjyMPABxOGLOIqhRC7y075VX1+pnqb7lyvhuSHtfpqj8kO 75OZMzDDA7mVHIxTHvqhg3MgvaAMwtMXU4pyxdcJxP0xqoB7Z5QbbcqVs1XGZrjNXWDo75+TZg8 IRrGaJO6swqLcreTB1rFWlglXySF+oaZczw9n172V02xJLM5bS7U3ZmwNyDn44AUoW+2/py5pON KJs7UfXrOWAZ8wAM08Pwrnw+rERbk1i6vFRtLfc+ErdEI2ydK2fufyNEvaSMEcpHI5pH+g/DNyY ky1VV2D22TOm3mkQPMu6but3jngiVWkFXiIisbs+4rdFkiNuqgX8J1NmdShZKeH7c5fMWxccRGM fWUJPKzfWB7+0Ak8FkeYLXlKw= X-Received: by 2002:a05:6512:1242:b0:5a4:640:9f07 with SMTP id 2adb3069b0e04-5a4172e7b8bmr2429015e87.31.1776523674389; Sat, 18 Apr 2026 07:47:54 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb4f51easm10901001fa.6.2026.04.18.07.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 07:47:53 -0700 (PDT) From: Svyatoslav Ryhel To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , Greg Kroah-Hartman , Svyatoslav Ryhel , Randy Dunlap Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 5/5] misc: apds990x: Drop IRQF_TRIGGER_LOW trigger Date: Sat, 18 Apr 2026 17:47:16 +0300 Message-ID: <20260418144716.132936-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260418144716.132936-1-clamor95@gmail.com> References: <20260418144716.132936-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Predefined IRQF_TRIGGER_LOW causes a conflict when setting triggers in the device tree node. Remove IRQF_TRIGGER_LOW from the interrupt; it can be specified in the device tree if needed. Signed-off-by: Svyatoslav Ryhel --- drivers/misc/apds990x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c index 557c8476ea80..51037cdc2c47 100644 --- a/drivers/misc/apds990x.c +++ b/drivers/misc/apds990x.c @@ -1183,8 +1183,8 @@ static int apds990x_probe(struct i2c_client *client) } err = devm_request_threaded_irq(dev, client->irq, NULL, apds990x_irq, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_LOW | - IRQF_ONESHOT, "apds990x", chip); + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "apds990x", chip); if (err) { dev_err(dev, "could not get IRQ %d\n", client->irq); goto error_pm; -- 2.51.0