From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C0AF2AD10 for ; Sat, 18 Apr 2026 16:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776528381; cv=none; b=NVbA+Ww9BjPkRWlT1jtcjyLim/RYMqqp/fYqWyH9ibiYcC+ajaA8vdnwT/Krop8vtktNVB68sqDZxaCtc6gu2Y267waSbVYgEAbc4g8at62u7XRKPzNRXUvit6KrIjRW5aPL5U+K/p8cizqPy/Nbq8/nB176W5ZHzW0JcJdzzzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776528381; c=relaxed/simple; bh=MWftFaJ8O2Xxs1l+puqj+8RM2P83r283+ik5iQi8dFI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NZDJt+cUQThqM3OAPEYVtXXzkZfBQJgB9d1zaeYrK4lGIMuZrQcjiWeXzhpjD7BYIKcyYTEGI+07ON+reU/ryPIuQPaoZwbv48rFVD1PbpNVwhuA4w36x1vRb5aVtNsbbRDXRUonFjBumdHY5xFjeCwzceP2O4ruiiH/t8nltsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=UdRCOLYt; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="UdRCOLYt" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8cbb6d5f780so157035085a.1 for ; Sat, 18 Apr 2026 09:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1776528378; x=1777133178; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mVLecyRDPAZGCV69dw7J/uwCjzmXG5zEQpv/sopb5tk=; b=UdRCOLYtlHbBqOmRq40vuitE3G2HkvwWrOHbZQgMXorooi+pJ6DdLCooZb+sfqV5G1 AXFUVwqFw5mUz/l5w2+t70JtMlSLpZ3iVF9SMQejm8epRI8iHMLdX4QxtTfeqSiePx4S cZ+bza8CxgHkFWBD4jvVU94HIVWrd1LP6vRxn6KxxlzDO9yMsEoTkDVs8DeggwLt2E5K rFmF4ZiCeRVIlQ9VgnYfGT3e2vM7YvwCgN6McjaSo/jPeHWjWYGkX+25LQ7XNITCqeiX Y8opr5JIPTFm+85yTxSuiqTeb395mE3dY1HiKf6ut3YCCYbrLzghGVVPmwHLwx11soGV avrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776528378; x=1777133178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mVLecyRDPAZGCV69dw7J/uwCjzmXG5zEQpv/sopb5tk=; b=EfW3eMIiWKARa1IDz8R9L1taISXS6CREIoMb0o+xUuzhD/7JWNEaaneMiFR32whq83 mjzzJ15Vza1zWgn3rkEKfVUkJAOcM7gbqR7sQcp0+gmp0d4QlyU848GM67ylmwLhBoBz FCMDErN2roqcW4Jm7xWBmC5chGeiMdDHzHk3Q9+m+xtdqUDBK67vRXemZdmzjFS1wyxm aM4rvDY1g1ePF5qGVb274ZUl3FUYHriK+O2QM2IsRquZIba7lWQcxgGsdy3OnVo6CcLa t5DSVQxIqW/164zVxheGgLFPO+eF7lZZpl5rNQ17qOz5m5n6Pg7R8idjBO6yhoDO4QUK gglA== X-Forwarded-Encrypted: i=1; AFNElJ9ZkZyTGEowNzKOX46qrZEqMJ6BS123iW6Lga4tzAZpgI7xpxezwSvhz9cJUukn28Zk+4c/1EBWTiaNxPs=@vger.kernel.org X-Gm-Message-State: AOJu0YyT1AupD4q5wjtlWTOzflUMwdE7aHrh2X8hkNCWyfz7QffbSnSZ nkrIRhl6s6SL7TPExAzFpFArkvBRLNy7Sw5b9qaSfXj8cyFC11gg42oU33430Xjkaww= X-Gm-Gg: AeBDievNA0KjthozME37n7ANgS8QTclRVwWFXJ9bS22o8hD9WMDQu3zBVh4XkBK8XQd EJLuHByqfLv3mm6OLPS4kSscpqconcoqE6d5mp1Y4rn/godEBgzRWEmRhVayAV5ZeTDwrJpJCja b58gZSIxM/3OCA2JDsFB+7+uGY4ufLbn4+eRR01Yh14rbaEb4ERntS+hbPEqI/fxJRAaC/sVpZu ocri7S/zk0xNQ1HdyeERTK8V3Fq2wq81mlxCYbowfEOSqr3+QZKPEPnoAlBBVxKR4bVHAyu615r yFXMUNLD+FqRvCgHppa5u/qmdCow58wRdF/bumGHr+M9FwH5iTQO2Z8CTKBw0izV4LmcKkBjkOv p5YANav7MaYVTyO4vz1IdKtdSCXCBImZLTYMYNpflHRmxVn8qrq134LsoBGMfeyz1gSygYHpyFL AW90P9nrIbx9XMD0igochV5hWj05Beekr7lo4dkACKhaM9qNQSj4vQHLutBC2Xx8f2y2KROE/Kf 1QbcZfJ1ph/37NQuayIocRxGwM= X-Received: by 2002:a05:620a:1a26:b0:8cf:d565:fcbb with SMTP id af79cd13be357-8e78f44328amr1064295685a.11.1776528378312; Sat, 18 Apr 2026 09:06:18 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7d65c1321sm378625285a.15.2026.04.18.09.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 09:06:17 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wE8BV-00000000tDf-1Ira; Sat, 18 Apr 2026 13:06:17 -0300 Date: Sat, 18 Apr 2026 13:06:17 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, jiri@resnulli.us, Mostafa Saleh Subject: Re: [RFC PATCH 2/7] dma-direct: use DMA_ATTR_CC_DECRYPTED in alloc/free paths Message-ID: <20260418160617.GM2577880@ziepe.ca> References: <20260417085900.3062416-1-aneesh.kumar@kernel.org> <20260417085900.3062416-3-aneesh.kumar@kernel.org> <20260417152828.GJ2577880@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Apr 18, 2026 at 11:57:42AM +0530, Aneesh Kumar K.V wrote: > Aneesh Kumar K.V writes: > > > Jason Gunthorpe writes: > > > >> On Fri, Apr 17, 2026 at 02:28:55PM +0530, Aneesh Kumar K.V (Arm) wrote: > >>> Propagate force_dma_unencrypted() into DMA_ATTR_CC_DECRYPTED in the > >>> dma-direct allocation path and use the attribute to drive the related > >>> decisions. > >>> > >>> This updates dma_direct_alloc(), dma_direct_free(), and > >>> dma_direct_alloc_pages() to fold the forced unencrypted case into attrs. > >>> > >>> Signed-off-by: Aneesh Kumar K.V (Arm) > >>> --- > >>> kernel/dma/direct.c | 34 ++++++++++++++++++++++++++-------- > >>> 1 file changed, 26 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > >>> index c2a43e4ef902..3932033f4d8c 100644 > >>> --- a/kernel/dma/direct.c > >>> +++ b/kernel/dma/direct.c > >>> @@ -201,16 +201,21 @@ void *dma_direct_alloc(struct device *dev, size_t size, > >>> dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) > >>> { > >>> bool remap = false, set_uncached = false; > >>> - bool mark_mem_decrypt = true; > >>> + bool mark_mem_decrypt = !!(attrs & DMA_ATTR_CC_DECRYPTED); > >>> struct page *page; > >> > >> This is changing the API, I think it should not be hidden in a patch > >> like this, also not sure it even makes sense.. > >> > >> DMA_ATTR_CC_DECRYPTED only says the address passed to mapping is > >> decrypted. It is like DMA_ATTR_MMIO in this regard. > >> > >> Passing it to dma_alloc_attrs() is currently invalid, and I think it > >> should remain invalid, or at least this new behavior introduced in its > >> own patch deliberately. > >> > > Thinking about this further, I am wondering why you consider passing > DMA_ATTR_CC_DECRYPTED invalid. It doesn't do that today. My point is if you want to add then then do it in its own patch and justify what it is for.. I cannot think of a reason for anything to want to do this. The purpose of decrypted memory is to allow a T=0 device to access it and you cannot take memory allocated by dma_alloc and pass it to some other device as a matter of API. So it would be *really* suspicious if some driver wanted this. > How about making the change below so that we only prevent > dma_alloc_attrs() from accepting DMA_ATTR_CC_DECRYPTED? Yeah, that is what I was trying to say. No issue with it using it inside I think. Jason