From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4248640DFBD for ; Sun, 19 Apr 2026 10:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776593002; cv=none; b=YSdof9RGcdTMIakmVJ5H7a8ipPgcE1EXoCKvxqqHTorHdQAnxVit1AK4Zzz9GkVgOFomfQkE0LJkLIVVzlr5D+YLuwUv5GS/qATSoicf95bztTc73XkQ9hIvRqmOcwCXLhs1LPHpSYgkThCIL/r5jywyRNpxYq6URUJAspJKLhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776593002; c=relaxed/simple; bh=lpy5HPWcDToYeqBZrVG2EhueVAqjGBNIYGwudHPHprA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FqXvX1+pIecFZyhdkp6WoOyPCKekCYpAblKACG+e9AA5eL42ko+G5LpII7GybRMy9KqZJTAEFMx9QJ1tTg8RkJ8b3Bmj2DQTZZpeAnuZH0W/3/IPvkQ1vOxh3NNHgPrOxC4udZdMjc20FTSGy/COhbtKaTHvUfiabHEqt94TzX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WjSyW9KK; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WjSyW9KK" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b458ca2296so14852685ad.0 for ; Sun, 19 Apr 2026 03:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776593000; x=1777197800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5w44GikZuWeQ97FC0JUKDlJUMKPjasM9hg3zLJjAZ8o=; b=WjSyW9KK+CRHA4e4PraqpNyytRyTw27hta36Ad1hSO58C6rIdAO2J7e5PB1lai63DM FIFjOWy0IwBRR9C6k/WG8Vs5POVwRU00LlQVJFQdNxPPXpPjEF1mKfSj7g9eyEzuCnq8 70/JKnEUayMyig9RhFkD74NrLUpFswfyeQuH/WXCa0eYYhqakPOtLXH5NIh0iZjo6Iua R7RLbJ53qwBr3nt9z8U4+KpvwGHxdX3VVoqJeHOxmnvGQjZ64/Va8Ki4q2IIhqK6WwTP Reftj91kjyKu63DXtCS0QXSUwrrMRaEUF5x00K7za8esPrUS3cWjYBR26UuvsvSk5LVK sC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776593000; x=1777197800; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5w44GikZuWeQ97FC0JUKDlJUMKPjasM9hg3zLJjAZ8o=; b=X/McZt6ANkDwXb8A/suwX5uh+TToxCCb4/uZy/jkCo+ZLPk0LdMyoOH/zeYJBJzuQB GGLzoyhXwPGAohIuwl8YPvEKV6W/kdEBuGHqPMpRmZMn1qX5u/P4vstvzk66ws8YB4g2 SknJUEy12LEhZWGwVtgovZH7c1B/ihw/TEmPm+GQhRdZr2vq79KK9Yg0DijDNhfDUYnG Typs+96RGTqv72kfE0C1QXwPRSe3y0Hwefn4gp0qog+vPMdKmgpQ0xelfN37hpimme+y lk0x1rZkLjIoeV1LrgM1htJzvqrL0KDA7/MvE4HnfW38ZZ+xBF2Y5jM+MjUQSIn0kcYe vRrA== X-Forwarded-Encrypted: i=1; AFNElJ+9WFUKkXgAoxJSeKaZxtlOIN9zzMZBhQZ1QS+WwSpbHl9ceY4hRMdKMoUlJw7OnDIgS5A/wKC5NDHvcmM=@vger.kernel.org X-Gm-Message-State: AOJu0YznIKeO4RFVyzxRNeCY9oTAqXNEZaMrddWF4doqePTQxbKXGOuU eyMijpHO9yGbIemNIw7yNc/zUcRwbYes9OrVxsgsBgcIkIYwhuF6OT7n X-Gm-Gg: AeBDievCK2lDor6IOiqQJO9wyaXNBwu6LzU6KLN8hOYQ9PRrs6nU7aZay1XXpsaZE5S LFv5pyummI1BnJ4ubj8ux8UPPtLy8c3BaVdyb5SppEzGGdLcXNU9ljGfGt8YZ+S4dLxsSn06VtS cZ6s6EQtCj17H65i8iazpMlL97DqzB6/cs+mYZuZ6BEhPUbIbdByFBrOCrqaPviiiNoNbaT91uv IeSEFgSqUnqG0xThaVR68Fu3usWE3x8obqCGyolj7EnTcPszTwWvY/jnKzlqvek4UZOvE/HjigC COZBjfM/Usdq1l1KXU/CNTyZVilw4QuX9TXRXFsg1jpOYvkyEc8R/Y2dnfjgm6xj2L3dSCp0biB U7t6TMVj3TiQwxwBbDriQ6/pGUVhPnQLVPhMT/HGwbsqt2uS2nlEdeA4MCZ9HAd6DpaaiDHJ9IZ JSQm9kgFQDTbDuxzyFKr2nWsyEcdaFPDC5E32S8rLb2V27qwY= X-Received: by 2002:a17:903:3d47:b0:2b4:5b82:a8e3 with SMTP id d9443c01a7336-2b5f9f51e09mr63797375ad.24.1776593000602; Sun, 19 Apr 2026 03:03:20 -0700 (PDT) Received: from tiger.hygon.cn ([112.64.138.194]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff729sm87442295ad.15.2026.04.19.03.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 03:03:20 -0700 (PDT) From: YangWencheng To: dave.hansen@linux.intel.com, srutherford@google.com Cc: YangWencheng , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Tom Lendacky , Pankaj Gupta , linux-kernel@vger.kernel.org Subject: [PATCH 1/1] x86/sev: Fix potential sign extension in amd_enc_status_change_finish() Date: Sun, 19 Apr 2026 18:03:11 +0800 Message-ID: <20260419100311.2849616-1-east.moutain.yang@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When npages (int) is left-shifted by PAGE_SHIFT to calculate the size in bytes, the operation is performed on a signed integer. If npages is large enough, this can cause: 1. Signed integer overflow (undefined behavior per C standard) 2. Sign extension when the result is promoted to unsigned long for the enc_dec_hypercall() parameter Cast npages to unsigned long before the shift to ensure: - The shift operation uses unsigned arithmetic - No sign extension occurs during parameter promotion - Correct size calculation for large page counts (>2^19 pages on 32-bit) This is a defensive fix; in practice, npages values are typically small, but the cast ensures correctness for edge cases and silences potential compiler warnings with -Wshift-overflow or -Wsign-conversion. Fixes: ac3f9c9f1b37 (x86/sev: Make enc_dec_hypercall() accept a size instead of npages) Signed-off-by: YangWencheng --- arch/x86/mm/mem_encrypt_amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c index 2f8c32173972..8134fb731a21 100644 --- a/arch/x86/mm/mem_encrypt_amd.c +++ b/arch/x86/mm/mem_encrypt_amd.c @@ -306,7 +306,7 @@ static int amd_enc_status_change_finish(unsigned long vaddr, int npages, bool en snp_set_memory_private(vaddr, npages); if (!cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) - enc_dec_hypercall(vaddr, npages << PAGE_SHIFT, enc); + enc_dec_hypercall(vaddr, (unsigned long)npages << PAGE_SHIFT, enc); return 0; } -- 2.43.0