From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B8832E696 for ; Mon, 20 Apr 2026 15:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776699838; cv=none; b=PDSAWdakgENcM95sL0m76CQQar0b1juuBmW7SIFwD593Erm/PIatTO6MNcKZn7+l60JsDwO9ia77NAxz5y3HR9zM5Tb3s760k228pfCPTMemO7izhhK1G0AzT9zIAi5K9ZiOyq22KBbSJj7MOsW2JwA+layyte5KSLsLwQPHhfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776699838; c=relaxed/simple; bh=StTSG59tnpNuMU2uPSZoLQzqbsMyq9fwcMZjiEpdg6Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NLEzJGEKa5JJSTPDN+qDsqzhvVKJkdtxEFdiiVIHpeLT82uk/INEP2Rgbdft83UQf4yeubHmZivC4tGFk6JK1ycL+ZCZahTyQiLzrhNT/Lnzbs98+1P9TgV/9mXlg7dxhfXzHkRiksfZMp/9Guo48moKCHyNyQwmsKNis492Jxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dIMwr4B8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aqsxUFYA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dIMwr4B8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aqsxUFYA" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63K97rhq1600315 for ; Mon, 20 Apr 2026 15:43:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QPBEl2EmLgl2bXNI31IZObAQEh4tI8eXiCacsAP7fp4=; b=dIMwr4B8cfSCNHx9 qrucKs3TxvUTQlQKmbeNjhui0ZzxHpUsGscXjDagruIGdJrs+bImVrjDOyJOzlHV tZh0QfywKhmw3xRb6B0uiMKJEMv2AbBx6IP8z8/sWkXOw4urV4VrMaXjJEEfKoaj 1pWpKOWCqESLc38vywI6CXHa7pA4IzMeyN6NlD7z5ps2FTpqplMAYGDn7IFHtfXO gfDhmA1Tp9ENEh5En1SlgQq+vbrMtRQhGwhMQQTIvdQEyve8mBOqnIa7v6kxAqWN wv7ujUiFm+dfPITE829eTvr9KWr8EkVHdzEo5tovlgBkDUGtrwjZtRuRRa1vmf+3 lLbRSw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnh899epy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 15:43:51 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c76cb2dce57so1847939a12.1 for ; Mon, 20 Apr 2026 08:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776699831; x=1777304631; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QPBEl2EmLgl2bXNI31IZObAQEh4tI8eXiCacsAP7fp4=; b=aqsxUFYAgS5VF37A9TBdwZGNRzVXuWnZ+zR4Df8smW4qqr9uZdXKf9SZqyUyt6zJza lpynYCt6SnAnzzXUAW56egmNPGhtsv/VMvOCc/x3KXsKu+tegl3olzEEkhb+cNFW45l9 +0bTJRQZ8FnbFRyr4FUCa4obDUOO9uiAkegTTVBX0CSHn+TV0Jxd0klp+b7BLgmN1ute 2kQQjmoSUhHXI/0V07qsIdE8G09aufQanozZ9xWbA6JVKAOJFavZXbhZPP93CzhCZXZU gKP3Q+UJNW5L6ftTzLhRxLas0PXdgtes0wOAIFQBg1rjBVS85rfKoX0M054G+A04XGgN 7V6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776699831; x=1777304631; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QPBEl2EmLgl2bXNI31IZObAQEh4tI8eXiCacsAP7fp4=; b=dURH7NQZ3fOcxGeihAvsb4v/RJlVbWvl5t4mCh8bKbui4roVvWeEjIkubk1gEx7ika FdqOabyr4Z1zIL2TAnBu2e5BkiY9emVTdGUlwNb69vA12RFeGRXl59hkghxc94APs4fl 28m2Io0lWIr9syRrDaFfNjVfmTxWdVzlvNpdj1mJnSpUQLDv1ZcJjtAqAhNVDDZe1asQ Bn/hr/vG+a96G+9F+csHiIbuQZT57XV06ZviDmf0cw7L8garUh2+12VIFvWb0XOPgBzf aUg26eXka7RCJ8y+dxw5jbDBGYn30FugAGgWcWTvnx4TpdYR2E6ZJvwMoGQNzCGdVmDv 7JWQ== X-Forwarded-Encrypted: i=1; AFNElJ8gcYG+JmSSYmKG1b4j5ZPR3GWK36HtOpelzSbSb/Yct/3lsm+qsQfrb8uggbhViFp5i1V5oLhrtjyIiTc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZxWMpiiumT6hRaQnRH58454nfA7Gcb5uaxepOrqBwhE+fSbse JLSkfTQAl3rFPlBpHK2IrxLRo9I6AGmOizaIRmMgA88CeHZZc5NzlcJw2KGQhxybWIgnq3LbRZC QuZv+KuU1gQ6dP37tgu9s5EmAEMQBu4G3MefwR1zs6ytQcDnpGhELnXhhpr/0OB1mZ1w= X-Gm-Gg: AeBDieupkccmAcBI4f2y4g+bTJmp0z5BGNDi6g2VjugBfUN3JTQO6+OwB7/gudv4e0i x0+fMdB9AkjV5YguKnjwiDB4P+2S84nVbRAYpEctCxern7Dkq62jdT+f7abUifrFMbflfGPGyiF BPIiJDuj86Jwk21M3EaPhrI44hzvqcaDi0Zh9/sQDdOmhVRE4oxbo1Fv11CIqEu+NhXbQKxhLxq 7/hs5l9izeTvX+PAKTIp/qHqf7JtoKFp3YnDvjCH/pgfcDRl8mz4961QGO6WBGKGeFioao8ZIPL uLaghlut6fKmbeU5MMQq0w2/9Hmou1PBQ1HmZENn/+P7BWMGof093kxC5+/BXI1ZZJ4Vv5qKgsQ +pCq0XPP1ti2oxOgU08AkxLHydDlfe3kX3yDKGU/ybzH3rnwaBScNA+iCKY/fgA== X-Received: by 2002:a05:6a00:4104:b0:82c:e9cc:f62f with SMTP id d2e1a72fcca58-82f8c82eab4mr13757356b3a.7.1776699830593; Mon, 20 Apr 2026 08:43:50 -0700 (PDT) X-Received: by 2002:a05:6a00:4104:b0:82c:e9cc:f62f with SMTP id d2e1a72fcca58-82f8c82eab4mr13757329b3a.7.1776699830064; Mon, 20 Apr 2026 08:43:50 -0700 (PDT) Received: from hu-kamalw-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb28sm10533230b3a.13.2026.04.20.08.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 08:43:49 -0700 (PDT) From: Kamal Wadhwa Date: Mon, 20 Apr 2026 21:13:38 +0530 Subject: [PATCH v4 1/4] soc: qcom: rpmh: Add support to read back resource settings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260420-read-rpmh-v3-v4-1-70c152e6c958@oss.qualcomm.com> References: <20260420-read-rpmh-v3-v4-0-70c152e6c958@oss.qualcomm.com> In-Reply-To: <20260420-read-rpmh-v3-v4-0-70c152e6c958@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa , Maulik Shah , Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776699822; l=7742; i=kamal.wadhwa@oss.qualcomm.com; s=20260406; h=from:subject:message-id; bh=fRLcFvxj66tpmAimv/ORz07g8Vv0sri2zroUI4okZes=; b=Xx92N3VspKFLJzgH0CnIJfJPFgOrpt2mCtj8Qa7ZI4Uh5ODlSqcp733FDnT2QDATTqXb4omQb zbOzcfvq7JMAbhPgHhVM4qLidBeSmmmON+VDLySHJ89xuhNWmxL6110 X-Developer-Key: i=kamal.wadhwa@oss.qualcomm.com; a=ed25519; pk=ylH1NxUZkBpYsmww89g6zVxpS0q8qthtzcORkYxn/Ag= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDE1MiBTYWx0ZWRfX32i3rNh3vX7J L/vE17cGxZUiWWJpTWEcjWe+T7DRvbJx0F0E8eWS76KeMY5RHTpwo3j8AAbMf93142r7jwMyRHr TEUC0XG1j7FgJFaBANN2V/8R691ZwebWKDpppyONgIy02o6d4bvoYiHeLrI39RmyEoZTGkDaRAE BFfWp/hqY0zU/Mwq7nSu1xOy4qNCuMsUD+W1lhH70/1DPBhYqBdFVug/uhYSIQirZTSv/fiGK/c 7CqliJ0ykbccewgd9Pbeesj/WByP+atEWzf0+SnnR6327ui/+6hxs0hB6y8YrjLJGjHXdukQoW2 2GcXOAfJErDDsSqIGvci52zU5cdd9AqtEOvOEg26cHRkQN34YcyXjye+XgMyp/3PP3Dfk6m22UZ GrfX6xuMD26IoXf16su4sXwrXc7Dz8bkKMCEf78b046JCzRyKcwSz1ZLEw6E7Z0k8i0rNAVaRUl ZJcBjY34hJ2h96H5GSg== X-Authority-Analysis: v=2.4 cv=D6B37PRj c=1 sm=1 tr=0 ts=69e649b7 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=RgaPuue0vXMEEcOqpiYA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: R9Z_DZgVTLZRGlEmeE3kal2hxriKeuDd X-Proofpoint-GUID: R9Z_DZgVTLZRGlEmeE3kal2hxriKeuDd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_03,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200152 From: Maulik Shah All rpmh_*() APIs so far have supported placing votes for various resource settings but the H/W also have option to read resource settings. Add new rpmh_read() API to allow clients to read back resource setting from H/W. This will be useful for clients like regulators, which currently don't have a way to know the settings applied during bootloader stage. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Maulik Shah Signed-off-by: Kamal Wadhwa --- drivers/soc/qcom/rpmh-rsc.c | 13 +++++++++++-- drivers/soc/qcom/rpmh.c | 47 +++++++++++++++++++++++++++++++++++++++++---- include/soc/qcom/rpmh.h | 5 +++++ include/soc/qcom/tcs.h | 2 ++ 4 files changed, 61 insertions(+), 6 deletions(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index c6f7d5c9c493d9e06c048930b8a14a38660df4b1..ec85c457ea4527f94339c2033bfcc12346e3c443 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -443,6 +443,7 @@ static irqreturn_t tcs_tx_done(int irq, void *p) int i; unsigned long irq_status; const struct tcs_request *req; + u32 reg; irq_status = readl_relaxed(drv->tcs_base + drv->regs[RSC_DRV_IRQ_STATUS]); @@ -453,6 +454,11 @@ static irqreturn_t tcs_tx_done(int irq, void *p) trace_rpmh_tx_done(drv, i, req); + if (req->is_read) { + reg = drv->regs[RSC_DRV_CMD_RESP_DATA]; + req->cmds[0].data = read_tcs_reg(drv, reg, i); + } + /* Clear AMC trigger & enable modes and * disable interrupt for this TCS */ @@ -493,13 +499,15 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int tcs_id, int cmd_id, const struct tcs_request *msg) { u32 msgid; - u32 cmd_msgid = CMD_MSGID_LEN | CMD_MSGID_WRITE; + u32 cmd_msgid = CMD_MSGID_LEN; u32 cmd_enable = 0; struct tcs_cmd *cmd; int i, j; /* Convert all commands to RR when the request has wait_for_compl set */ cmd_msgid |= msg->wait_for_compl ? CMD_MSGID_RESP_REQ : 0; + if (!msg->is_read) + cmd_msgid |= CMD_MSGID_WRITE; for (i = 0, j = cmd_id; i < msg->num_cmds; i++, j++) { cmd = &msg->cmds[i]; @@ -513,7 +521,8 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int tcs_id, int cmd_id, write_tcs_cmd(drv, drv->regs[RSC_DRV_CMD_MSGID], tcs_id, j, msgid); write_tcs_cmd(drv, drv->regs[RSC_DRV_CMD_ADDR], tcs_id, j, cmd->addr); - write_tcs_cmd(drv, drv->regs[RSC_DRV_CMD_DATA], tcs_id, j, cmd->data); + if (!msg->is_read) + write_tcs_cmd(drv, drv->regs[RSC_DRV_CMD_DATA], tcs_id, j, cmd->data); trace_rpmh_send_msg(drv, tcs_id, msg->state, j, msgid, cmd); } diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c index ca37da3dc2b148c76e50e25885bd85a0cb47c9b6..f881c4c757ec8302b09eabf2f18bc79941a6f2c5 100644 --- a/drivers/soc/qcom/rpmh.c +++ b/drivers/soc/qcom/rpmh.c @@ -175,6 +175,9 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state, struct cache_req *req; int i; + if (rpm_msg->msg.is_read) + goto send_data; + /* Cache the request in our store and link the payload */ for (i = 0; i < rpm_msg->msg.num_cmds; i++) { req = cache_rpm_request(ctrlr, state, &rpm_msg->msg.cmds[i]); @@ -182,6 +185,7 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state, return PTR_ERR(req); } +send_data: if (state == RPMH_ACTIVE_ONLY_STATE) { ret = rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg); } else { @@ -194,7 +198,7 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state, } static int __fill_rpmh_msg(struct rpmh_request *req, enum rpmh_state state, - const struct tcs_cmd *cmd, u32 n) + const struct tcs_cmd *cmd, u32 n, bool is_read) { if (!cmd || !n || n > MAX_RPMH_PAYLOAD) return -EINVAL; @@ -204,10 +208,45 @@ static int __fill_rpmh_msg(struct rpmh_request *req, enum rpmh_state state, req->msg.state = state; req->msg.cmds = req->cmd; req->msg.num_cmds = n; + req->msg.is_read = is_read; return 0; } +/** + * rpmh_read: Read a resource value + * + * @dev: The device making the request + * @cmd: The payload having address of resource to read + * + * Reads the value for the resource address given in tcs_cmd->addr + * and returns the tcs_cmd->data filled with same. + * + * Context: May sleep. Do not call from atomic contexts. + * + * Return: 0 on success, negative errno on failure + */ +int rpmh_read(const struct device *dev, struct tcs_cmd *cmd) +{ + DECLARE_COMPLETION_ONSTACK(compl); + DEFINE_RPMH_MSG_ONSTACK(dev, RPMH_ACTIVE_ONLY_STATE, &compl, rpm_msg); + int ret; + + ret = __fill_rpmh_msg(&rpm_msg, RPMH_ACTIVE_ONLY_STATE, cmd, 1, true); + if (ret) + return ret; + + ret = __rpmh_write(dev, RPMH_ACTIVE_ONLY_STATE, &rpm_msg); + if (ret) + return ret; + + ret = wait_for_completion_timeout(&compl, RPMH_TIMEOUT_MS); + cmd[0].data = rpm_msg.cmd[0].data; + + return (ret > 0) ? 0 : -ETIMEDOUT; +} +EXPORT_SYMBOL_GPL(rpmh_read); + /** * rpmh_write_async: Write a set of RPMH commands * @@ -230,7 +269,7 @@ int rpmh_write_async(const struct device *dev, enum rpmh_state state, return -ENOMEM; rpm_msg->needs_free = true; - ret = __fill_rpmh_msg(rpm_msg, state, cmd, n); + ret = __fill_rpmh_msg(rpm_msg, state, cmd, n, false); if (ret) { kfree(rpm_msg); return ret; @@ -257,7 +296,7 @@ int rpmh_write(const struct device *dev, enum rpmh_state state, DEFINE_RPMH_MSG_ONSTACK(dev, state, &compl, rpm_msg); int ret; - ret = __fill_rpmh_msg(&rpm_msg, state, cmd, n); + ret = __fill_rpmh_msg(&rpm_msg, state, cmd, n, false); if (ret) return ret; @@ -352,7 +391,7 @@ int rpmh_write_batch(const struct device *dev, enum rpmh_state state, rpm_msgs = req->rpm_msgs; for (i = 0; i < count; i++) { - __fill_rpmh_msg(rpm_msgs + i, state, cmd, n[i]); + __fill_rpmh_msg(rpm_msgs + i, state, cmd, n[i], false); cmd += n[i]; } diff --git a/include/soc/qcom/rpmh.h b/include/soc/qcom/rpmh.h index bdbee1a97d3685d8a6153d586ddf650bd3bd3dde..14ecbf242b6bd67c8167c176ed0970f42432f4f4 100644 --- a/include/soc/qcom/rpmh.h +++ b/include/soc/qcom/rpmh.h @@ -11,6 +11,8 @@ #if IS_ENABLED(CONFIG_QCOM_RPMH) +int rpmh_read(const struct device *dev, struct tcs_cmd *cmd); + int rpmh_write(const struct device *dev, enum rpmh_state state, const struct tcs_cmd *cmd, u32 n); @@ -24,6 +26,9 @@ void rpmh_invalidate(const struct device *dev); #else +static inline int rpmh_read(const struct device *dev, struct tcs_cmd *cmd) +{ return -ENODEV; } + static inline int rpmh_write(const struct device *dev, enum rpmh_state state, const struct tcs_cmd *cmd, u32 n) { return -ENODEV; } diff --git a/include/soc/qcom/tcs.h b/include/soc/qcom/tcs.h index cff67ce25488e2d3603a7707af2ca77f8266a713..45b8513be2f9bb0957796476f6031146ee34e931 100644 --- a/include/soc/qcom/tcs.h +++ b/include/soc/qcom/tcs.h @@ -51,6 +51,7 @@ struct tcs_cmd { * struct tcs_request: A set of tcs_cmds sent together in a TCS * * @state: state for the request. + * @is_read: set for read only requests * @wait_for_compl: wait until we get a response from the h/w accelerator * (same as setting cmd->wait for all commands in the request) * @num_cmds: the number of @cmds in this request @@ -58,6 +59,7 @@ struct tcs_cmd { */ struct tcs_request { enum rpmh_state state; + bool is_read; u32 wait_for_compl; u32 num_cmds; struct tcs_cmd *cmds; -- 2.25.1