From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC433256C6C for ; Sun, 19 Apr 2026 16:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776614918; cv=none; b=q9Hsr/geCFu0UWeh/YBd4quXYSWfCnAVzTS4ryVQ2Mu8t8DLc79q94HU2knBaj2FdnJRpGdrhTTW8IGOWEYzUmm7CCCf2SGotTMUsctY+tXaDMpOB5x8zuhvKMEEjUSSQ9gkVnTmd/UC6pssATrQz07m+5eBdKcs53SYhJrOV98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776614918; c=relaxed/simple; bh=NKEaAD+3eWl4gKIG7zdM0p5hQ+JhG/r/VXWI2wvbm4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jFaK3YUl3rDhSrm3UEWRstfB+SdX7YQLJQyUpBhPiyeNN1L/lojTPAG0bmH5cVuKY94o6m7jCVoRKu5WnUl3qwQzFNpmuG4nwsyVEZGJBcYKnfQDLXdKlgLHszeuJ5g994BT5OMWJ30io+V63GP+L6BOXoRhVNzi7qXI45945KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IOhg0ybS; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IOhg0ybS" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b23fcf90b2so22638335ad.3 for ; Sun, 19 Apr 2026 09:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776614917; x=1777219717; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ndJBZ7UPSsArKlwCUxRT5c8CBnik95cDzWoK3nnYb3s=; b=IOhg0ybS2NX+i5sHbjlZLkBeIUh2Ww9KocRb3BM+o5WvMHH29HMV9ewlwqL42qFv2G qUtQbqAI4Wv6HZfPbPak1UOaG77xxg6lbBmbT20uU0UM0US4ebKvY+dmELseZOFVTbYP ZQLF/TDHn+jQB6sf7OugH5zbrEckN6hVTP/MzcGNVcn8sFOYA3L1SdMRTxz8Qb+kw28c AY+62yilZV/xjrUHSVBwXapSyT1+yxbNWuYM4mhFc5LfyhkViKgZ0U5mblP22ZCurpAk /38wdb8tJx2Me2R42ur3YurpM0X4IXwMJCz2Xt9GxH2LXkDC303S6nYqXkdfw7dm1q8r jPQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776614917; x=1777219717; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ndJBZ7UPSsArKlwCUxRT5c8CBnik95cDzWoK3nnYb3s=; b=bXoOrIap4JUrdqlWXfTf3D55Uneforn7rul5ioH5BNoEHwB8DfHVREFW7QA46foYTR ocfmH43jepjHrdvT3RP4iMagdPopxVlikRIxDwbdOIkt6ScbNla6jttLeDRvljpNzw59 URPk+KQQqRPFJeq7AgTGM5VnmgTX5nPVxa/wmXQZ5ihtditE0+nOB8sTSGJ4xrDxoLJW n5CozNVTe29fPfijabX1byUvC4BDsFkKRaq5kZZc14eOf0srDaZQQrO4MPGZ2iOZlnBx aGEA32lMgw+do4jx6FTmcb1wqEXvcWLNnjGpkUgV6yWApqbu5j6j7RTPk/9A0SZdapUZ qUwA== X-Forwarded-Encrypted: i=1; AFNElJ/50C3yDTJW0Axu1IgAj/VGcmFdzgeXwP/M2NIt4f1fS11hjPmNC5EDF47jXZKdo/kVpFbSqf6voeyii7A=@vger.kernel.org X-Gm-Message-State: AOJu0YzgTz7nvoJQu5mQ00chLUIt/I+/hCvHRe7Ir2j3wKd98wZmZNI9 LM+lJ2etZnmcey9Ud2XHw+vr5gUv+sxSM2CSaZZldev5sJhMKgM4WxYi X-Gm-Gg: AeBDietk8Hb+bchLn/x1LddB6H8aII+dhtXwXKbKN5CejcTaj02Qm9fL8Fwx7j+CE6o FqN83Dc+oTgdQxs3+TLvRBChpHYLleErxveVMuPP6OK2Buorwe3PhPuXee6/JjDcrxhPx12Sy6T BU04+kUYW7dar8tqBE34MiIqgiU6vVypg5VM16KyXfz2b3aLtH12eONXnKpzYbu69AJShrVYEL6 pXiddc4hErq+Owt0jyzNmYYhiK4UEEszdFhHGP4Dve2Bj5ygOtLTPbs32CTjqAWtyKXSKCfuHFg HCbftirvYE3BBXqk6DpU1dT522XnhMf4XT4pmuJm+yTxTtMyDZ9psvjPdDTSJ72oBloQm1J9Iws 9eoOVeG66Q7zJScOpTKihPkhzlZE4EtSzAag0eQO7zyiRFjHPH1EuT5mHTHvHQOr7YCm2KmEwvb 7m6lyc8/BgmIF/NuM80djDUKFZNza6i56Eslk2gpbe3Ia8OQV3XWUabzhntTLG3IAyV0/Qd9XXp Kn+urdkQGDxLBLc X-Received: by 2002:a17:903:1ac6:b0:2b0:c90f:44b2 with SMTP id d9443c01a7336-2b5f9e8252bmr110521715ad.12.1776614917063; Sun, 19 Apr 2026 09:08:37 -0700 (PDT) Received: from cchengyang.duckdns.org (36-225-119-66.dynamic-ip.hinet.net. [36.225.119.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab3bd2bsm81058875ad.74.2026.04.19.09.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 09:08:36 -0700 (PDT) Date: Mon, 20 Apr 2026 00:08:33 +0800 From: Cheng-Yang Chou To: Tejun Heo Cc: sched-ext@lists.linux.dev, David Vernet , Andrea Righi , Changwoo Min , Ching-Chun Huang , Chia-Ping Tsai , Emil Tsalapatis , linux-kernel@vger.kernel.org Subject: Re: [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg Message-ID: <20260420000646.G9266@cchengyang.duckdns.org> References: <20260418092247.1541377-1-yphbchou0911@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Tejun, On Sun, Apr 19, 2026 at 06:04:34AM -1000, Tejun Heo wrote: > -d is dead code - it just sets dump_cgrps which is only echoed in the > status-line printf, nothing actually dumps the cgroup hierarchy. The > right thing to do is remove the whole thing - the 'd' in getopt(), case > 'd':, the dump_cgrps variable and its printf - rather than document dead > code as a feature. > > Want to spin a removal patch? Yeah, for sure! Thanks for the explanation, will do! -- Cheers, Cheng-Yang