From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FBE39B976 for ; Mon, 20 Apr 2026 11:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683357; cv=none; b=Ux8ICs65zuUW9/bqLGWoGFhW4hVIAoN9dMBrbyPgCSGHOlWtN/ydt5DVRfDlzp0SaWWHqq48EXRqNfRnMxpmRsvtPmVbT64frIi1mL5H0/jdIHaSegU4P2y1nST2yKq8GwrpPv3PtDj4suNrZSHEIjjVN6eomjCD94vKIE7EAhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683357; c=relaxed/simple; bh=Gj9u0n6M04mVAFyvRZaeIEMfKTHjfAR9dbZpYgpDyfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l4jElSWkMYxqbfUQDRjjJZJkXrogp3wfO802c89Q9ywHvReGu1WVgpowIMxevL7Ob5BwogBu/Qk7EvNpYlseIpaWhwunVgtmNP86mvw1hlLsPDJDr4LMr2cJf4SeilM6jnMdHPH7GBm11k+iJD5EwSJBubAiL+D8ZJKtFPoZfEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=moGZ1TqC; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="moGZ1TqC" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-65c4152313fso3959347a12.1 for ; Mon, 20 Apr 2026 04:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776683348; x=1777288148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6N2bcOzuNhie0n79Zbzqw5jabBLf8p/cWOSMWKiL5F8=; b=moGZ1TqCEcKYiLqBpWdbvSvBqn/Wmw1i6vxdYa8fT42T2BgDg0zk7B0sdFa6Q5I1q2 cs0fzhuLtMHgDg9DO/HPuGnamlO9sxRpi9bx/I9+vBVrhSeRRR2DQm943nl6ndfu2/2z L6jAot06avgMoXHtX9geawuWLOTNyfOzi4p6Re92JH6iVZYF4UcwlZJe4KGJNkyy2rBc lJXT5OQsj0gJKODa9ZKfyHJj8XkTzf/g7KCHtuZ6faRjZJG2C16vzgoJxyvo18S1TpPC mw5l/LX+7715g6cSEChYrucB4i+tgsb7z1245HbL5X80ZO4LEOZb0A0xjG89t4rrzG9F 3vWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776683348; x=1777288148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6N2bcOzuNhie0n79Zbzqw5jabBLf8p/cWOSMWKiL5F8=; b=QVmAIR/ehLZ8xS2CURZSbUZRo7wJNJKfvsB9mI2Sj3n1Y7RrOn1OWuFZDFS51fUwW3 +Bap3/uGV+EfOVqM4XLxgWbUQdEPOqjbyIFH77ufzo3rSnSLDe3OUcLwl2EVN2lOLbqF 4Huvu+aoaORfhUNP5S6EHzd2bI1W+knupVC2BH+sAQgRPtch6z5yK0grzgS/v+t4uBga zCWwWqEfeSZhO02fjzA3gPlLdmkABclNp+d6weTRiYHQpUx4WSPJ4e+8r+foEYH36L62 7EVTWTnEoFsrBTifpbPYKidchIcRy+hJAZvb2q5SYDtmqF8la3d2Nm59P5hBvwCnteuh chNQ== X-Forwarded-Encrypted: i=1; AFNElJ+mZKR1ggo5I2EynlCaBX1chu0T4WpxbhyfktMxurU0xvHZ3j/6H5BY5aVaw8oZGPaunl6PFsCUnpfHCAE=@vger.kernel.org X-Gm-Message-State: AOJu0YxNU0ItJggEvP+4OwtmI0RiNOKuDYmXGAPXOYOuAG7a6D//tjed Yt+tHO8DbtQWJV95Gx7aLbt1q8cWMgBbVD9cE4hBdXIeVOv/bnGpj+x7iXuong7k/E4fbQ== X-Gm-Gg: AeBDietKe9GgbWwSM5Jjsz1c14Jacv6frU2s1r1bPzpanm/HqcEnsWjRCIFenElsWGE I5lViIvpkvhYuiUiSeD7kxl6T8OmJp20GLQdBXZR2+oCAf0rVHhLCUbPeDsi+xDoUTa+Vtksn1X qOupKMcoq3SsKk7NYdxjasw7H9FqiuILKNSUBqW/N0t7j6uJoL4xKssNQ7+J7u5KGI9F0j/Hqiz 4Pc1sTJL8wBx/W57kVuISBAvbCGJJChaza4arcD4TAQ9PScs50cyK+zM3cmIM9ms05FdtqAZY41 AUqyrrQWV6r1r7mzi2kti1jlF6cpsxlg4cHFjbsNqxZl9vzCtyG7qY5dTg0MiogoXh2wERCEioC NZvlhjYI61IItV3X2fEwhu6tOeKNTgXDWIgDWLB4E9TY7FUDYvSy0R4+huSeBqKRNs6Pf6Pi8ES gUwNtwno+1vT6zHaWNrmDUYMH8slSX9EtwYfZqfepkUuhFNNCEU4eQHQ+v6S+D2HhuPS3iv7naU 3PVaY0LM2fBnF3ZwMjBOHraGng6lHvU3jjeFJa/QfBFx3nHzRaRq50jxW6GnmxXa2aE/HJm4Iuk SUrwlpCaTjwB+qVx+jXKhSnFzneDVgweYlOpdLgHaVoU3EYX2+k9QenXYpc/YsybSta8rN8ZXqL B56DKlwM5gGBGNkWCOUt4QdborD9QEZFMAJPpnMmQ21WPlqmKyXF3OO+dvPTV5mJolTzrko0QlT dwAIkefO2RDedlI4mj/g== X-Received: by 2002:a05:6402:2b98:b0:672:a20b:3781 with SMTP id 4fb4d7f45d1cf-672bfc12952mr5457229a12.0.1776683347651; Mon, 20 Apr 2026 04:09:07 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (254.196.90.34.bc.googleusercontent.com. [34.90.196.254]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c47fe8a0sm1947664a12.5.2026.04.20.04.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 04:09:06 -0700 (PDT) From: Joshua Crofts To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH 4/4] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Date: Mon, 20 Apr 2026 11:08:04 +0000 Message-ID: <20260420110804.1353-5-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260420110804.1353-1-joshua.crofts1@gmail.com> References: <20260420110804.1353-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver currently uses while loops and msleep() for polling during conversion waits. Replace the custom polling loops with readx_poll_timeout() and read_poll_timeout() macros from . This reduces boilerplate, standardizes timeout handling and improves overall code readability, keeping the original timing and error behaviour. Assisted-by: Gemini:3.1-Pro Signed-off-by: Joshua Crofts --- drivers/iio/magnetometer/ak8975.c | 44 ++++++++++++++----------------- 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index c57ff6d99f3..86b4149e77b 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -651,17 +652,15 @@ static int ak8975_setup(struct i2c_client *client) static int wait_conversion_complete_gpio(struct ak8975_data *data) { struct i2c_client *client = data->client; - u32 timeout_ms = AK8975_MAX_CONVERSION_TIMEOUT; int ret; + int val; /* Wait for the conversion to complete. */ - while (timeout_ms) { - msleep(AK8975_CONVERSION_DONE_POLL_TIME); - if (gpiod_get_value(data->eoc_gpiod)) - break; - timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME; - } - if (!timeout_ms) { + ret = readx_poll_timeout(gpiod_get_value, data->eoc_gpiod, val, val != 0, + AK8975_CONVERSION_DONE_POLL_TIME * 1000, + AK8975_MAX_CONVERSION_TIMEOUT * 1000); + + if (ret) { dev_err(&client->dev, "Conversion timeout happened\n"); return -EINVAL; } @@ -676,30 +675,27 @@ static int wait_conversion_complete_gpio(struct ak8975_data *data) static int wait_conversion_complete_polled(struct ak8975_data *data) { struct i2c_client *client = data->client; - u8 read_status; - u32 timeout_ms = AK8975_MAX_CONVERSION_TIMEOUT; int ret; + int val; /* Wait for the conversion to complete. */ - while (timeout_ms) { - msleep(AK8975_CONVERSION_DONE_POLL_TIME); - ret = i2c_smbus_read_byte_data(client, - data->def->ctrl_regs[ST1]); - if (ret < 0) { - dev_err(&client->dev, "Error in reading ST1\n"); - return ret; - } - read_status = ret; - if (read_status) - break; - timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME; + ret = read_poll_timeout(i2c_smbus_read_byte_data, val, val != 0, + AK8975_CONVERSION_DONE_POLL_TIME * 1000, + AK8975_MAX_CONVERSION_TIMEOUT * 1000, + true, + client, data->def->ctrl_regs[ST1]); + + if (val < 0) { + dev_err(&client->dev, "Error in reading ST1\n"); + return val; } - if (!timeout_ms) { + + if (ret == -ETIMEDOUT) { dev_err(&client->dev, "Conversion timeout happened\n"); return -EINVAL; } - return read_status; + return val; } /* Returns 0 if the end of conversion interrupt occurred or -ETIME otherwise */ -- 2.47.3