From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B201235F5F2 for ; Mon, 20 Apr 2026 14:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776693969; cv=none; b=P5p+Hj8yLKAFswlDsVQP/vHYYbaT4yEahOzRtffwiDxbGmoVERmkYIntO9DdeqbsjHkdEEHDPFCsqLLviBtNSPbzYD+KpyhQn1VKS7RiX/7V9WDNtvza8A/e6mrUnN0tubGm4wAIDKRUrUC1cFD/AT1t879lsqtgQ5EXZrQYXrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776693969; c=relaxed/simple; bh=uxYQuB4zCIHMUo5lGPq/D+Ib/tJBDBnqjcU2qW38Yms=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qFCnp7/pYc/2fcmRkwJ2dt3pNPeWakpbTmqGrApJ0bUXLoQZfp6QW44i5mJjwd9QpRflk2xkKOSBFrm2apaLaRRR/x6tJdOFRdHjlv/UfNoLDxFyK8FmSso2lSvKpeaNWSXZSHS13DJ/1gUFkyI15YVdkGCTZFnzPJJMG95xFhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m4NT9y+N; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m4NT9y+N" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b8f97c626aaso483973466b.2 for ; Mon, 20 Apr 2026 07:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776693966; x=1777298766; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=97974GtdtwWe6NOkpQCqCEwwPqvlp2vIawuZ+Sj53rM=; b=m4NT9y+NN2/xRWc/adOSaYA1+JyKAfH/nbnZsZ4797rMAJOP6XpQRRlckkxn1hTFQI KDMrhbZBq7FkZu19iv77ZK2OX4mEIRQV7o8aC125NqifnjaW7W6ViqXRsrDn6w5uWKWV ksu2vDnPLIezQjJ5h5zaeSNCZazib+8h6ACYwERUseeGb2HlnVT7VvbhsWmUJKZ+KphQ LNys6VtCwsU9KAAnLjN/hxs2TKn5IJRxKS4Z7z0mdcLEEQdeey2RGc0iv/XFltub2ios V5NSGHvHiC944QriYzjeelC6HY8lsE+Vj5k5D5T2q05rYjG2WNbvCGfuJZlIqalpbYoy eY4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776693966; x=1777298766; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=97974GtdtwWe6NOkpQCqCEwwPqvlp2vIawuZ+Sj53rM=; b=BD5c0gLNsyTgyWnR+Yr3yo4xbGwF2uIXuOYdVbaAtzUm+G/zwnLGLWPegFZ9ftVXRr BOgXcbAkxI6WyqW03aTGmJ5ZzPGB6NKyYNcr1Q40O2D1WwOJrlywUxs3I6FIYQxc3o7J JsAjZ1rM5lED27nIntOa8tMglGhKYNjLgNzNAuiSCe8M6PugrBQosaUU9RGTjMao1Xc2 g4VU9iM+JKWYF9HEqO4OsAcrjWP2zMHtdEu5fiQGUsIWVljklZPUWXN8WP1ipqBUtijS WFfM6wd2TIQwodQBdXNlaoZ+a/Pnvbi87mIZG3NaTMt9dAaCPFnkBi8CS8XKEph7NnOo Vw3A== X-Forwarded-Encrypted: i=1; AFNElJ9471qOpBmzJm9vjrin8LnFeJ2wJPiVphAaXTP46YcFg158TNcIN/Fwwy+fyD9lmPNuD2iHthWx8MjtKFI=@vger.kernel.org X-Gm-Message-State: AOJu0YwijxFW9SX1MTQds2Txkr2Aetnuc803N1VJTx2n9N0OWgfA4dEh PTvJ8xzug9pkPNQfXHXlkYS9SrbrPGr5Di/nRDrO7xMZNEi+CJvod3zM X-Gm-Gg: AeBDietVkGeVtAka6VntR6TXkFDoS2v7zAsB9tG7KS98gT5ueovKtR8X2HUOps89pHH tj0QzUSPx8X1Ph1xizrYPYtqWSMjSrmFxhXgAczd65ZKzHy9H46nyBcUdcWkeaW7bahLrNUZgR/ qr7f8cs5xDE9x7l2xHvDBZCsjIGrBMpCpgjUB4o3vsSume+nMmflLcNjmP5CMWDtpgfudeAf/7T yLkrvi7p7gsQgF0HO9Yg82MRSsT/P9JruWZu9f2b6sEN2a9pCkpDFHPJM4jAMVbDpJ+lKS7kzT2 UQ0I6ql+bDqAyD34wk9u94ZG1JumyS18Q+hfVRx9GmDKD0iAoBRz1TExogzyZdAPUub46eX/h0+ zFQNy0gwFJyffof+wWG3h80gjIFLLP0OIgBMBO1vXgm0W0AKqzGtIZnZgUDUL957UH08NnSO9JK GjUKebXzwBsGBQTG+ts6JbrYqcByKfJiuCP5TRvr+16KYcgcAClyUOelGO6zlk1VhK4gNnBEzmC i/M85GvnXSW3ZcFwJRJcC+rrUlNEq85nvgW9M7F4KpcI4eHR0FTOu7jWwpEoPledFdyrvotHWum JL22lCdcLVYsYoO96+YRgUG519Y= X-Received: by 2002:a17:907:2d0b:b0:b98:50b:e94a with SMTP id a640c23a62f3a-ba41c2ab6c0mr660897366b.16.1776693965861; Mon, 20 Apr 2026 07:06:05 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45121109csm358128966b.6.2026.04.20.07.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:06:05 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Alexandru Hossu Subject: [PATCH 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler() Date: Mon, 20 Apr 2026 16:04:31 +0200 Message-ID: <20260420140432.150431-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandru Hossu HT_caps_handler() iterates pIE->length bytes and writes into HT_caps.u.HT_cap[], which is a fixed 26-byte array (sizeof struct HT_caps_element). Because pIE->length is a raw u8 from an over-the-air 802.11 AssocResponse frame and is never validated, a malicious AP can set it up to 255, causing up to 229 bytes of out-of-bounds writes into adjacent fields of struct mlme_ext_info. The parallel function HT_info_handler() already carries the correct guard: if (pIE->length > sizeof(struct HT_info_element)) return; Apply the same pattern to HT_caps_handler(). Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4..b75e7f4f8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -934,6 +934,9 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE) if (phtpriv->ht_option == false) return; + if (pIE->length > sizeof(struct HT_caps_element)) + return; + pmlmeinfo->HT_caps_enable = 1; for (i = 0; i < (pIE->length); i++) { -- 2.53.0