From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CFD436BCC0 for ; Mon, 20 Apr 2026 14:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694185; cv=none; b=Ne/jPHL7rUJ97TBqK+yDRwIHsJ84aeuOmQw8mg8efipgwibs53mLaexhNsMRAeio5qSVBU2yetSBB/Kg7En0ddXSAmi4FBCNh6RHeFwAtZzlSFiVF9SFBCDxUgFsLKSQezB43vyWZPPRx50g7FkVe60GXFQRG6oV/nu8IT3+vw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694185; c=relaxed/simple; bh=x/aNAmwUYBnigl4ojqcwpNW/UE42YjbUCHfVQ0xHA4E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cr83klBC/Dhukp6xvadO0DTW9VaX0qDkOysGOL9dHV8r/wHq0YlBOrlCitPAaU1CPCD23GMCWH3S6l2MJBMYmSqBsEPJa7QvQ9DVOOKiUQom9KPOL43gslGUV7+kT4ogcQZ/6072aeGCr/ntMbxCBTYE/zrfgo43zckuE7YJz2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lcF3jBOX; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lcF3jBOX" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-671d60ef9c6so3983631a12.2 for ; Mon, 20 Apr 2026 07:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776694182; x=1777298982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jlnvteOKBJSDUMvxczhYyGCSUQ6dxtzv1BsshS4BqVc=; b=lcF3jBOXGb+kc59BiIKNa5eMJ5ZyP6V1YD+tWPYeaUU++4PPkw85yDj8teE3nbnex9 /1XyTUzjc+KV3IVb4dOfl2i1MC0sYHLoirkIPXTybR63z0t72/8OfcV4rp7dKY/UK2JD mCTiNEGHOTzMWPYPEN7/spEi9uVmcNi8gJI7nKr86enTthPAxZEZPYy93Qz1awpP2BNP UTeqJfRLJrDG00RpL2kXHoTXMS3Hu7owavTDURQVJUADb++FKMEAhmsEQClIfJ4rj5v1 tfDOFYThnmQv1dNIkDN2XNGkZ3oRNgbTpBTHmskntJkI+6wPKAXGNGN+hM8FHvFUIPmP eJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694182; x=1777298982; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jlnvteOKBJSDUMvxczhYyGCSUQ6dxtzv1BsshS4BqVc=; b=GAJtq9/3kOVxafelK21gxNYuRQVGOfx7Ai7ytVArurAJPr1LYqgI6haCMu/bbqTm/s rmfzh9siM9E0GWQCZemOPIDLHiCyLcEOUoPgiuAKyzz7tRNE+HSTRC0yLmwSwH5jkVHm zBYOttihfa21FSmlhTIrF79ltWyJl30HjuFK196lOAeDqRskv4tyVPApPvsaV+5BVmQM 7qlFGcBi2gcmUSBRh8RyJNif0cJHzp1JgfbsdxC61DXLXwJdVGk4NLtv3oIOgb/16xyh t+SODed8kCePVIt4xyMtAa5K3KgYLu0KhNMl0M9UKCb53qmf0zZ12ByWHJ+vFf0SQFQN 0dcQ== X-Forwarded-Encrypted: i=1; AFNElJ869vTI/7LzA91Eqbcx/v9PnEIdIjASRUaEMhMyvy3gCdpURbpu2ucs2WR+HFIAvg1I/snkHQcXr6CjINs=@vger.kernel.org X-Gm-Message-State: AOJu0YwirbPXOgf6WXA6r78uMe8WbB/v7RlR5zAdXQRp6BLOsTXGbDpH HQpjSEIqFiYylbIpUt6A39b0e+3gCGACgEris2YSc8hN00AM5WaJy85j X-Gm-Gg: AeBDieuygtlsSc7bfVNw2HnwfR1Zj4Csd0Oy7RCQtQfPUF3m7Qo24oKxbMvN9Y+8SrS X+8SysEJVfb20+DqPDQ+0F0aEWgplcRPlUMhCiOsk/mIvmfiHbsLvNUXoJ1Pv5wVdR0+NGxfY1j FA509EX2iwI05MfdoEO1hSzQmVLpkaDYkcidbLnf5Rtd+ZPg4506YuZ8k/zwG002iNRk1FhIctQ UwlUCS/crMze/cbyAy9cVgKp5RjG4XVFmcMiTJ7Gzmfjl3+mmW1Ac6Wi3KBCe1+RHvdg8T4Oirn HsEXhfbieb15/3A7ygBWe6HonAjattOyjLmAR6cvleJzZXocx1bVXTOpvyCdRZsr/+ZGrEQBXew dA9XArRvj4Z15lNkWFAqQ4LHFeol+hPeYg1fmC8St9yGc0d9Mrq2Cl0jqMj9rNCn5VgW/UrD7Ug vgBRaKRlHQf7IYJmCiJkhPPB8ZM91C1sac9Hwp9m9y/ySgt/+9xu5EXEyTzvownlqIbfjnJFcuK g683jopXxv7sKBhPreW6EwetaN1+MikrQ7Ols5dhaCXDOKZBrmQfv83RTTGKWWC7rJmEdsTvCAS FhAkRDUuTzOw0581 X-Received: by 2002:a17:906:c10f:b0:ba7:636d:e285 with SMTP id a640c23a62f3a-ba7636de4a3mr220293166b.7.1776694181922; Mon, 20 Apr 2026 07:09:41 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45121109csm358377866b.6.2026.04.20.07.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:09:41 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Alexandru Hossu Subject: [PATCH 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler() Date: Mon, 20 Apr 2026 16:08:06 +0200 Message-ID: <20260420140807.152739-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit HT_caps_handler() iterates pIE->length bytes and writes into HT_caps.u.HT_cap[], which is a fixed 26-byte array (sizeof struct HT_caps_element). Because pIE->length is a raw u8 from an over-the-air 802.11 AssocResponse frame and is never validated, a malicious AP can set it up to 255, causing up to 229 bytes of out-of-bounds writes into adjacent fields of struct mlme_ext_info. The parallel function HT_info_handler() already carries the correct guard: if (pIE->length > sizeof(struct HT_info_element)) return; Apply the same pattern to HT_caps_handler(). Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4..b75e7f4f8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -934,6 +934,9 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE) if (phtpriv->ht_option == false) return; + if (pIE->length > sizeof(struct HT_caps_element)) + return; + pmlmeinfo->HT_caps_enable = 1; for (i = 0; i < (pIE->length); i++) { -- 2.53.0