From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8EB236F429 for ; Mon, 20 Apr 2026 14:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694188; cv=none; b=puOKJFFVPeJ3XF5V4JYkuHiYXpkK8ywNPg/XKXOHzl7Njqa0snUQsGnkzE2I7R8Jo3p6d62YrTubz2/CXc3T5q4mh4NgvOpuswDvB9gyy+7UNh4rJKUYc5Ci953GJ4CxjeBFi6rd2i42HgbVfA305Rjgt6HSoAUyeyp5EPma/Zg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776694188; c=relaxed/simple; bh=zl/btun4vswcZCKNwdf7yHrhdjLCThX8GH22GKnU9pY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CdXmlqQbkqu8NdWCH4b61YO2hHAhZA1uvz0SEAOUPSdFNiQuKUoSAKtUtVbQp9cuzVDwJFmBxCWmwf3vbywI7bfMxc7gEOdrvzYYQ4AsZhP6qleS2uJYZ6l+NxVRVdJAsDdZhphEAQ6L3+uwvpbV3190/JSRc9l5k+WCrIqRhd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TwkB2egW; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TwkB2egW" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-672645dbfeaso3364465a12.0 for ; Mon, 20 Apr 2026 07:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776694185; x=1777298985; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YdmSEBxLsk8sxmN+On4zurEXd2v6gvfUnEqAFEIij1E=; b=TwkB2egWDDqa0hc1OEzXTR/UsIGC+f1KmzRDwk5rNMjbfSSzHK92UTp/xNBgAHID9n V52IptvIZ8n3Rl0R8D3xOTAmE7FXLUHSO8HjIyagu1prNla+zoGRSmpDUxpESEcI/r9c etAqL00xqKvJzEXN7g8fMlXZJ85XkfLX1ylnyxUeXLWQsIRA7SJNPOduIGwg4pXiAdzB 1a7iGPvhGgYLeByPM98psNjO/mcQvdxvzo0I/fX2tSLr+8L5lSkgfAsYQXS2qtZA7mX1 cVRxBN37FHaqJyvkNapivmWG9s5YxPnJtwnyRijDqBXqoQa5JRhku0hZdgyd53vyNDeu q5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694185; x=1777298985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YdmSEBxLsk8sxmN+On4zurEXd2v6gvfUnEqAFEIij1E=; b=OF3Ow9MGijvaJLJ3iJLYpAL6X63wvhIxvad0bD5lXGXGwZDMv/R3MWybVTZMA9MHuF 3Ure/Fw2pqT+raJ26iS1OP1FPH9r4C5bP9MoOdmn27V9a97nF/aJaOuxdRUcTxN/Hw5U zUfZ22zVcrZr1+3OWopDaXgkoH4e9TaUjS+UJAJD6wyzHQpQOT6LK6NI7y60YYSWXB0n JBS75lC4T3LytdCllo5zINkmY7/0mBAzQhj6SuHzjMNW7n4vcTYqY9qqfUuS7vgn/SX1 L5jP1igRCj9q9SrP3UHA7DHPK1to5qBZUCUUB6mykPNSd2aE0EncHcaO2pTV3IRhOkth nKbg== X-Forwarded-Encrypted: i=1; AFNElJ/WIlBE2NxjcBFm3b7aGz/qT2ZgQZTXdBFJ+MeYzWcsCgcmQVi6tC5cctJmiE/jM4ccajjJ+qEFgeJywoE=@vger.kernel.org X-Gm-Message-State: AOJu0YwOu7LOTi+PE0br8RXb76a5/teiNuVWiAWO+IawK5M1aA8PTb3w a5/WbIMdLfpEyRIvBDhtEyoU/VYrWb1+rlfRa4MY+b+hAblniIoT5C4K X-Gm-Gg: AeBDievMH0oP10LBDomdrp0dB6qleDWQDQ07E3pK6XWZItpJBLviS62STpYEr6jxSK0 KEpT9KXAole8B+ROLS49XyH8okgrMvSqGePWXaAPEZfVEQqJPr9NY8olvbwKNR4eR+thltHhq/A qX+wuYD0fta5AAMx95PO6vojIKlzM5T7v5bxXa30Dc0QQqngWL2R/EAlwfWY4ZMcFbvoSFX50Ez 5Xiy/t/di2dMYDF/UXwDp2MhmLWUWjlrxvy/iRy5rBPQZrF6wCrnKkJUzGbYbCy19DOJ001mNRd GWl/B+5NMn0L/CQpacxpX4+wRbBJCBZb4j9OkJ03ARtqttmgyZGVePJUiksWhniJGvH2IC8d+oL kn0oNP+AC5eE4FcfsUVgN9XbISBybKHimUX6HoCuGw6nMFGYv/nM2j9m0KBeGHRrCo1B+pOIQ3i cv/baG2OIZLu7NGTCLqmDmdHEJr93XD6Y/AkKd3gyHd7TF1EcwF/9+h8mk331zmdCeTVBWeaFJ0 skyQ24Gpn91/3pO+LANHMuihAZCd44tb+Y6uvrTBOdiWjdnkNaPacJmJgC0FR6rf5W3byYsATGD j1UXfGTQXON/YBD8P6cNIaVIk8A= X-Received: by 2002:a17:906:4fc5:b0:b9b:ddb2:b1c1 with SMTP id a640c23a62f3a-ba418f7f625mr565611866b.21.1776694183240; Mon, 20 Apr 2026 07:09:43 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba45121109csm358377866b.6.2026.04.20.07.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:09:42 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Alexandru Hossu Subject: [PATCH 2/2] staging: rtl8723bs: fix OOB read in OnAssocRsp() IE loop Date: Mon, 20 Apr 2026 16:08:07 +0200 Message-ID: <20260420140807.152739-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420140807.152739-1-hossu.alexandru@gmail.com> References: <20260420140807.152739-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IE parsing loop in OnAssocRsp() advances by (pIE->length + 2) each iteration but only guards on i < pkt_len. When a malicious AP sends an AssocResponse whose last IE has only one byte remaining in the frame (the element_id byte lands at pkt_len-1), the loop reads pIE->length from pframe[pkt_len], which is one byte past the allocated receive buffer. Additionally, even when the header bytes are in bounds, pIE->length itself can extend the data window beyond pkt_len, silently passing a truncated IE to the handler functions. Add two guards at the top of the loop body: 1. Break if fewer than sizeof(*pIE) bytes remain (can't read the header). 2. Break if the IE's declared data extends past pkt_len. Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282..9666226a6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1400,7 +1400,11 @@ unsigned int OnAssocRsp(struct adapter *padapter, union recv_frame *precv_frame) /* to handle HT, WMM, rate adaptive, update MAC reg */ /* for not to handle the synchronous IO in the tasklet */ for (i = (6 + WLAN_HDR_A3_LEN); i < pkt_len;) { + if (i + sizeof(*pIE) > pkt_len) + break; pIE = (struct ndis_80211_var_ie *)(pframe + i); + if (i + sizeof(*pIE) + pIE->length > pkt_len) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: -- 2.53.0