From: neilfsun <loyou85@gmail.com>
To: 18255117159@163.com
Cc: bhelgaas@google.com, hans.zhang@cixtech.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
loyou85@gmail.com, neilfsun@tencent.com,
shawn.lin@rock-chips.com, tglx@kernel.org
Subject: [PATCH v2 v2] PCI/MSI: Fix memory leak in pci_alloc_irq_vectors_affinity INTx path
Date: Tue, 21 Apr 2026 11:20:44 +0800 [thread overview]
Message-ID: <20260421032044.55948-1-neilfsun@tencent.com> (raw)
In-Reply-To: <2caa071e-85ee-4e76-bb33-8f27a4579fac@163.com>
In the INTx fallback path of pci_alloc_irq_vectors_affinity(),
affinity masks are created and never freed.
Signed-off-by: neilfsun <neilfsun@tencent.com>
Signed-off-by: Sun Feng <loyou85@gmail.com>
Reviewed-by: Hans Zhang <18255117159@163.com>
---
v2: use __free to auto-release pointers
---
drivers/pci/msi/api.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c
index c18559b6272c..994f12813ce3 100644
--- a/drivers/pci/msi/api.c
+++ b/drivers/pci/msi/api.c
@@ -285,8 +285,10 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
* the device driver can adjust queue configuration
* for the single interrupt case.
*/
- if (affd)
- irq_create_affinity_masks(1, affd);
+ if (affd) {
+ struct irq_affinity_desc *masks __free(kfree) =
+ irq_create_affinity_masks(1, affd);
+ }
pci_intx(dev, 1);
return 1;
}
--
2.52.0
next prev parent reply other threads:[~2026-04-21 3:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 4:09 [PATCH] " neilfsun
2026-04-20 4:47 ` Hans Zhang
2026-04-21 3:20 ` neilfsun [this message]
2026-04-21 6:24 ` [PATCH v2 v2] " Shawn Lin
2026-04-21 8:06 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421032044.55948-1-neilfsun@tencent.com \
--to=loyou85@gmail.com \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=hans.zhang@cixtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=neilfsun@tencent.com \
--cc=shawn.lin@rock-chips.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®